Bug 100470

Summary: Use switch/case statements instead of if/elseif in CSSSelector.cpp
Product: WebKit Reporter: Hayato Ito <hayato>
Component: CSSAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Use switch statements.
none
Patch for landing none

Hayato Ito
Reported 2012-10-25 23:49:43 PDT
We can get compiler warnings in the future if we use switch/case statements here.
Attachments
Use switch statements. (2.26 KB, patch)
2012-10-25 23:57 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.29 KB, patch)
2012-11-05 22:00 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-10-25 23:57:04 PDT
Created attachment 170833 [details] Use switch statements.
Hayato Ito
Comment 2 2012-11-05 22:00:24 PST
Created attachment 172485 [details] Patch for landing
WebKit Review Bot
Comment 3 2012-11-05 22:26:06 PST
Comment on attachment 172485 [details] Patch for landing Clearing flags on attachment: 172485 Committed r133561: <http://trac.webkit.org/changeset/133561>
WebKit Review Bot
Comment 4 2012-11-05 22:26:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.