Bug 100468

Summary: [EFL][WK2] Move input method code out of EwkViewImpl
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100226    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-10-25 23:35:36 PDT
The input method code is currently in EwkViewImpl but it would be better to create a new class for it, to avoid cluttering the view code.
Attachments
Patch (19.34 KB, patch)
2012-10-25 23:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-25 23:48:33 PDT
Created attachment 170829 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-26 01:06:50 PDT
Comment on attachment 170829 [details] Patch Do you know whether we have code like Qt (and iOS etc) to only pop up vkb as a result of a user action? Would be great to have (with tests)
WebKit Review Bot
Comment 3 2012-10-26 02:40:38 PDT
Comment on attachment 170829 [details] Patch Clearing flags on attachment: 170829 Committed r132594: <http://trac.webkit.org/changeset/132594>
WebKit Review Bot
Comment 4 2012-10-26 02:40:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.