Bug 100450

Summary:

x32 backend of the JIT compilers

Product:

WebKit

Reporter:

Yuqiang Xian <yuqiang.xian>

Component:

JavaScriptCore

Assignee:

Yuqiang Xian <yuqiang.xian>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

barraclough, benjamin, bfulgham, cmarcelo, commit-queue, fpizlo, nrotem, ojan.autocc, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

100909

Bug Blocks:

99153, 101325

Attachments:

Description	Flags
patch	none
Rebased patch	buildbot: commit-queue-
Rebased again	none
Rebased again	none
Rebased again	none
Rebased again	none

Yuqiang Xian

Reported 2012-10-25 20:29:19 PDT

Add the x32 backend to the JIT compilers.

Attachments
patch (24.80 KB, patch) 2012-10-25 20:58 PDT, Yuqiang Xian	no flags	Details Formatted Diff Diff
Rebased patch (27.23 KB, patch) 2012-11-14 01:42 PST, Yuqiang Xian	buildbot: commit-queue-	Details Formatted Diff Diff
Rebased again (27.64 KB, patch) 2012-11-27 18:06 PST, Yuqiang Xian	no flags	Details Formatted Diff Diff
Rebased again (28.19 KB, patch) 2013-01-03 19:42 PST, Yuqiang Xian	no flags	Details Formatted Diff Diff
Rebased again (33.13 KB, patch) 2013-03-25 18:55 PDT, Yuqiang Xian	no flags	Details Formatted Diff Diff
Rebased again (33.53 KB, patch) 2013-04-11 19:45 PDT, Yuqiang Xian	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Yuqiang Xian

Comment 1 2012-10-25 20:58:49 PDT

Created attachment 170800 [details] patch Could you please take a look? Thanks

WebKit Review Bot

Comment 2 2012-10-25 21:02:06 PDT

Attachment 170800 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:477: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:479: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:486: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:488: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:500: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yuqiang Xian

Comment 3 2012-11-14 01:42:37 PST

Created attachment 174108 [details] Rebased patch Rebased.

WebKit Review Bot

Comment 4 2012-11-14 01:46:07 PST

Attachment 174108 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:477: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:479: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:486: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:488: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:500: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 5 2012-11-14 20:20:18 PST

Comment on attachment 174108 [details] Rebased patch Attachment 174108 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14831603 New failing tests: inspector-protocol/nmi-webaudio.html

Yuqiang Xian

Comment 6 2012-11-27 18:06:37 PST

Created attachment 176380 [details] Rebased again

WebKit Review Bot

Comment 7 2012-11-27 18:09:47 PST

Attachment 176380 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:477: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:479: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:486: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:488: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:500: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yuqiang Xian

Comment 8 2013-01-03 19:42:56 PST

Created attachment 181267 [details] Rebased again

WebKit Review Bot

Comment 9 2013-01-03 19:46:02 PST

Attachment 181267 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:441: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:477: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:479: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:486: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:488: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:500: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yuqiang Xian

Comment 10 2013-03-25 18:55:36 PDT

Created attachment 194975 [details] Rebased again

WebKit Review Bot

Comment 11 2013-03-25 18:59:14 PDT

Attachment 194975 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/AbstractMacroAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h', u'Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h', u'Source/JavaScriptCore/assembler/X86Assembler.h', u'Source/JavaScriptCore/dfg/DFGEdge.h', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/jit/ExecutableAllocator.h', u'Source/JavaScriptCore/jit/JITCall.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/runtime/MatchResult.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:445: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:481: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:483: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:490: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:492: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:504: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yuqiang Xian

Comment 12 2013-04-11 19:45:48 PDT

Created attachment 197712 [details] Rebased again

WebKit Commit Bot

Comment 13 2013-04-11 19:48:38 PDT

Attachment 197712 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/AbstractMacroAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssembler.h', u'Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h', u'Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h', u'Source/JavaScriptCore/assembler/X86Assembler.h', u'Source/JavaScriptCore/dfg/DFGEdge.h', u'Source/JavaScriptCore/dfg/DFGNode.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/heap/Region.h', u'Source/JavaScriptCore/jit/ExecutableAllocator.h', u'Source/JavaScriptCore/jit/JITCall.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/runtime/MatchResult.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Platform.h']" exit_code: 1 Source/JavaScriptCore/jit/JITStubs.cpp:445: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:481: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:483: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:490: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITStubs.cpp:492: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/jit/JITStubs.cpp:504: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Nadav Rotem

Comment 14 2013-10-31 11:40:20 PDT

Is this worth the extra complexity ? X32 has very little adoption. Does it even make sense in the context of a browser ?

Filip Pizlo

Comment 15 2013-10-31 11:53:21 PDT

(In reply to comment #14) > Is this worth the extra complexity ? X32 has very little adoption. Does it even make sense in the context of a browser ? I agree, I don't think it's worth the complexity.

Brent Fulgham

Comment 16 2013-10-31 13:00:55 PDT

Comment on attachment 197712 [details] Rebased again Cleared flag to remove from review queue. It doesn't seem like X32 has enough adoption to warrant it being added to our shipping browser code.

Brent Fulgham

Comment 17 2013-11-18 10:35:17 PST

It looks like x32 support is not planned at this time.

Note You need to log in before you can comment on or make changes to this bug.