Bug 100438

Summary: Apply transformation for highlights on non-composited contents
Product: WebKit Reporter: Tien-Ren Chen <trchen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, trchen, webkit.review.bot, wjmaclean
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tien-Ren Chen
Reported 2012-10-25 17:50:23 PDT
Apply transformation for highlights on non-composited contents
Attachments
Patch (2.82 KB, patch)
2012-10-25 17:52 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch (19.30 KB, patch)
2012-10-30 14:38 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2012-10-25 17:52:31 PDT
Created attachment 170773 [details] Patch
Alexandre Elias
Comment 2 2012-10-25 18:19:32 PDT
LGTM. James, Adam?
W. James MacLean
Comment 3 2012-10-26 10:46:44 PDT
(In reply to comment #2) > LGTM. James, Adam? Sure, looks reasonable to me.
Adam Barth
Comment 4 2012-10-26 14:04:01 PDT
Comment on attachment 170773 [details] Patch Can you test this change?
Adam Barth
Comment 5 2012-10-26 14:04:19 PDT
As a general rule, changes to WebKit require tests.
Tien-Ren Chen
Comment 6 2012-10-30 14:38:00 PDT
Created attachment 171522 [details] Patch
WebKit Review Bot
Comment 7 2012-10-31 15:28:09 PDT
Comment on attachment 171522 [details] Patch Clearing flags on attachment: 171522 Committed r133085: <http://trac.webkit.org/changeset/133085>
WebKit Review Bot
Comment 8 2012-10-31 15:28:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.