Bug 100402

Summary:

WebGLRenderingContext::handleNPOTTextures uses incorrect texture names

Product:

WebKit

Reporter:

Elijah Taylor <elijah.taylor+webkitbugzilla>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Trivial

CC:

bfulgham

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fixes handleNPOTTextures	none

Elijah Taylor

Reported 2012-10-25 11:55:37 PDT

WebGLRenderingContext::handleNPOTTextures incorrectly uses the index values of m_textureUnits to set the context's active texture, which expects a proper GL_TEXTUREn value instead. I got GL_INVALID_ENUM from glActiveTexture to show up when rendering with drawArrays using multiple NPOT textures that were incomplete (they were using GL_REPEAT instead of GL_CLAMP_TO_EDGE against spec), and handleNPOTTextures tried to set the black texture for the non-active textures. Please find the attached trivial patch to fix this.

Attachments
Fixes handleNPOTTextures (1.39 KB, patch) 2012-10-25 11:56 PDT, Elijah Taylor	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Elijah Taylor

Comment 1 2012-10-25 11:56:36 PDT

Created attachment 170703 [details] Fixes handleNPOTTextures

Brent Fulgham

Comment 2 2016-03-21 17:11:43 PDT

This same change was made as part of Bug 148020, and landed in r188666 <http://trac.webkit.org/changeset/188666>. *** This bug has been marked as a duplicate of bug 148020 ***

Note You need to log in before you can comment on or make changes to this bug.