Bug 100395

Summary: Avoid unnecessary style recalcs on id attribute mutation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-10-25 10:32:13 PDT
There is no need to invalidate element style on id attribute change if neither the old nor the new id were mentioned in any stylesheet. This is similar to the optimization we already have for class attributes.
Attachments
patch (4.30 KB, patch)
2012-10-25 10:47 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-10-25 10:47:13 PDT
Created attachment 170690 [details] patch
Andreas Kling
Comment 2 2012-10-25 10:55:21 PDT
Comment on attachment 170690 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=170690&action=review Why didn't we do this already? r=me > Source/WebCore/css/StyleResolver.cpp:4241 > +bool StyleResolver::hasSelectorForId(const AtomicString &idValue) const OH GOD & PLACEMENT > Source/WebCore/dom/Element.cpp:716 > + StyleResolver* styleResolver = document()->styleResolverIfExists(); Indentation derp.
Antti Koivisto
Comment 3 2012-10-25 12:35:32 PDT
http://trac.webkit.org/changeset/132516
Alexey Proskuryakov
Comment 4 2012-11-02 12:38:03 PDT
This has caused bug 101047.
Note You need to log in before you can comment on or make changes to this bug.