Bug 100373

Summary:

Web Inspector: Fix vertical alignment in toolbar backgrounds and overflow button.

Product:

WebKit

Reporter:

dubroy

Component:

Web Inspector (Deprecated)

Assignee:

dubroy

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Screenshot of proposed changes.	none
Fix misalignment issues in toolbar, and make it more adaptable to diff't heights.	none

dubroy

Reported 2012-10-25 06:40:32 PDT

Web Inspector: Fix vertical alignment in toolbar backgrounds and overflow button.

Attachments
Patch (4.79 KB, patch) 2012-10-25 06:43 PDT, dubroy	no flags	Details Formatted Diff Diff
Screenshot of proposed changes. (123.25 KB, image/png) 2012-10-25 06:46 PDT, dubroy	no flags	Details
Fix misalignment issues in toolbar, and make it more adaptable to diff't heights. (5.32 KB, patch) 2012-10-26 02:17 PDT, dubroy	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

dubroy

Comment 1 2012-10-25 06:43:09 PDT

Created attachment 170629 [details] Patch

dubroy

Comment 2 2012-10-25 06:46:07 PDT

Created attachment 170631 [details] Screenshot of proposed changes.

dubroy

Comment 3 2012-10-25 06:47:03 PDT

This patch was split off from https://bugs.webkit.org/show_bug.cgi?id=95654.

dubroy

Comment 4 2012-10-26 02:17:24 PDT

Created attachment 170855 [details] Fix misalignment issues in toolbar, and make it more adaptable to diff't heights.

dubroy

Comment 5 2012-10-26 02:19:12 PDT

Previous patch had a small issue on Linux that caused the toolbar to be too tall. Current patch fixes the issue.

WebKit Review Bot

Comment 6 2012-10-29 05:24:50 PDT

Comment on attachment 170855 [details] Fix misalignment issues in toolbar, and make it more adaptable to diff't heights. Rejecting attachment 170855 [details] from commit-queue. dubroy@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Review Bot

Comment 7 2012-10-29 05:48:25 PDT

Comment on attachment 170855 [details] Fix misalignment issues in toolbar, and make it more adaptable to diff't heights. Clearing flags on attachment: 170855 Committed r132790: <http://trac.webkit.org/changeset/132790>

WebKit Review Bot

Comment 8 2012-10-29 05:48:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.