Bug 100363

Summary:

Remove a timing function in AnimationValue.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Layout and Rendering

Assignee:

Dongseong Hwang <dongseong.hwang>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cc-bugs, dglazkov, eric, jamesr, koivisto, mifenton, pdr, peter+ews, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	dongseong.hwang: review-, dongseong.hwang: commit-queue-

Dongseong Hwang

Reported 2012-10-25 04:00:59 PDT

A KeyframeAnimation has a timing function. RenderLlayerBacking misunderstands that a KeyframeAnimation can have many timing functions, so AnimationValue, which is used to send a keyframe value to GraphicsLayer, has a timing function. This made all Accelerated Compositing implementations complex. This patch corrects this complexity.

Attachments
Patch (20.59 KB, patch) 2012-10-25 15:58 PDT, Dongseong Hwang	no flags	Details Formatted Diff Diff
Patch (22.93 KB, patch) 2012-10-26 02:40 PDT, Dongseong Hwang	dongseong.hwang: review- dongseong.hwang: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dongseong Hwang

Comment 1 2012-10-25 15:58:28 PDT

Created attachment 170756 [details] Patch

Build Bot

Comment 2 2012-10-25 16:17:31 PDT

Comment on attachment 170756 [details] Patch Attachment 170756 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14559794

Peter Beverloo (cr-android ews)

Comment 3 2012-10-25 17:16:52 PDT

Comment on attachment 170756 [details] Patch Attachment 170756 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14544811

Build Bot

Comment 4 2012-10-25 17:37:57 PDT

Comment on attachment 170756 [details] Patch Attachment 170756 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14552799

WebKit Review Bot

Comment 5 2012-10-25 18:18:47 PDT

Comment on attachment 170756 [details] Patch Attachment 170756 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14593434

Dongseong Hwang

Comment 6 2012-10-26 02:40:47 PDT

Created attachment 170857 [details] Patch

Dongseong Hwang

Comment 7 2012-10-26 03:36:45 PDT

I misunderstood. The spec said "A keyframe style rule may also declare the timing function that is to be used as the animation moves to the next keyframe." http://www.w3.org/TR/css3-animations/#timing-functions

Note You need to log in before you can comment on or make changes to this bug.