Bug 100346

Summary:

[EFL] DRT doesn't clean up after itself

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

Tools / Tests

Assignee:

Thiago Marcos P. Santos <tmpsantos>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, laszlo.gombos, ojan, pnormand, rakuco, tmpsantos, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

100678

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Dominik Röttsches (drott)

Reported 2012-10-25 00:45:58 PDT

leaving a lot of DumpRenderTree-Efl-CacheDir-* files in /tmp.

Attachments
Patch (1.67 KB, patch) 2012-10-30 05:37 PDT, Thiago Marcos P. Santos	no flags	Details Formatted Diff Diff
Patch (1.83 KB, patch) 2012-10-31 04:27 PDT, Thiago Marcos P. Santos	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Thiago Marcos P. Santos

Comment 1 2012-10-30 05:37:16 PDT

Created attachment 171428 [details] Patch

Dominik Röttsches (drott)

Comment 2 2012-10-30 08:10:55 PDT

Comment on attachment 171428 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171428&action=review > Tools/ChangeLog:10 > + set on both WebKitTestRunner and DumpRenderTree. As discussed, would be good to explain how the manually set directory gets created (as you said, by the test driver, earlier).

Thiago Marcos P. Santos

Comment 3 2012-10-31 04:27:47 PDT

Created attachment 171618 [details] Patch

Laszlo Gombos

Comment 4 2012-10-31 04:41:10 PDT

xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ?

Thiago Marcos P. Santos

Comment 5 2012-10-31 04:53:28 PDT

(In reply to comment #4) > xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ? xvfb uses case is different, it is using XDG_CACHE_HOME to store the results of the test run. I checked if it was really necessary and looks like it is.

Thiago Marcos P. Santos

Comment 6 2012-10-31 08:21:57 PDT

(In reply to comment #5) > (In reply to comment #4) > > xvfb driver is using DG_CACHE_HOME variable in webkitpy/layout_tests/port/xvfbdriver.py - perhaps that should be removed as well together with this patch ? > > xvfb uses case is different, it is using XDG_CACHE_HOME to store the results of the test run. I checked if it was really necessary and looks like it is. OK, I did a investigation here. Currently there is no way of setting the Application cache via code. The only way is by setting XDG_CACHE_HOME. That means the xvfb test driver is wrong and should be setting it to inside DUMPRENDERTREE_TEMP/something. Gonna fix that on another bug though.

WebKit Review Bot

Comment 7 2012-10-31 08:54:16 PDT

Comment on attachment 171618 [details] Patch Clearing flags on attachment: 171618 Committed r133036: <http://trac.webkit.org/changeset/133036>

WebKit Review Bot

Comment 8 2012-10-31 08:54:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.