Bug 100338

Summary: Everything that sets RenderObject::m_style should go through setStyleInternal
Product: WebKit Reporter: Elliott Sprehn <esprehn>
Component: New BugsAssignee: Elliott Sprehn <esprehn>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gustavo, ojan, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Elliott Sprehn
Reported 2012-10-24 23:42:03 PDT
Everything that sets RenderObject::m_style should go through setStyleInternal
Attachments
Patch (3.71 KB, patch)
2012-10-24 23:44 PDT, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2012-10-25 00:13 PDT, Elliott Sprehn 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Elliott Sprehn
Comment 1 2012-10-24 23:44:34 PDT
Created attachment 170564 [details] Patch
Early Warning System Bot
Comment 2 2012-10-24 23:49:59 PDT
Comment on attachment 170564 [details] Patch Attachment 170564 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14569480
Early Warning System Bot
Comment 3 2012-10-24 23:53:10 PDT
Comment on attachment 170564 [details] Patch Attachment 170564 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14563512
Elliott Sprehn
Comment 4 2012-10-25 00:13:14 PDT
Created attachment 170567 [details] Patch Include the heright headers
Ojan Vafai
Comment 5 2012-10-25 10:35:49 PDT
Comment on attachment 170567 [details] Patch Seems reasonable.
WebKit Review Bot
Comment 6 2012-10-25 11:00:36 PDT
Comment on attachment 170567 [details] Patch Clearing flags on attachment: 170567 Committed r132503: <http://trac.webkit.org/changeset/132503>
WebKit Review Bot
Comment 7 2012-10-25 11:00:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.