Bug 100298

Summary: [cairo] unneeded FloatRect object creation in BitmapImage::draw
Product: WebKit Reporter: arno. <a.renevier>
Component: PlatformAssignee: arno. <a.renevier>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

arno.
Reported 2012-10-24 15:50:07 PDT
Hi, in BitmapImage::draw, FloatRect& arguments are copied to srcRect and dstRect variables. But srcRect and dstRect are not modified, and we could use dst and src directly.
Attachments
Patch (2.93 KB, patch)
2012-10-24 15:56 PDT, arno. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2012-10-24 15:56:19 PDT
Created attachment 170498 [details] Patch patch proposal
WebKit Review Bot
Comment 2 2012-10-24 18:26:15 PDT
Comment on attachment 170498 [details] Patch Clearing flags on attachment: 170498 Committed r132438: <http://trac.webkit.org/changeset/132438>
WebKit Review Bot
Comment 3 2012-10-24 18:26:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.