[WK2][Qt] Enable hover and mouse events in flickable WebView

• Component: New Bugs
• Status: RESOLVED FIXED

[Sergio Villar Senin]

[WK2][Qt] Enable hover and mouse events in flickable WebView

[Sergio Villar Senin]

Created attachment 170488 [details]
Patch

[Sergio Villar Senin]

So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling.

Apart from that I talked to Kenneth on IRC and he told me that the idea of the WebKitQt maintainers is to move towards having all the functionality of the legacy webView to the flickable one. So this might be a step in the right direction.

I was not sure if I should include a patch to the MiniBrowser also, because right now it's generating touch events from mouse events and we might think about removing that. I guess it was done for testing purposes or the like, but don't know all the details as I'm more familiar with the Gtk+ port.

[Andras Becsi]

(In reply to comment #2)
> So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling.

Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also.

> 
> Apart from that I talked to Kenneth on IRC and he told me that the idea of the WebKitQt maintainers is to move towards having all the functionality of the legacy webView to the flickable one. So this might be a step in the right direction.
> 
> I was not sure if I should include a patch to the MiniBrowser also, because right now it's generating touch events from mouse events and we might think about removing that. I guess it was done for testing purposes or the like, but don't know all the details as I'm more familiar with the Gtk+ port.

MiniBrowser also does multi-touch mocking for mouse events when pressing the Ctrl key which is useful for testing pinch-zoom on a desktop without a touch device, thus it should remain as is for testing purposes.

[Andras Becsi]

Comment on attachment 170488 [details]
Patch

Enabling hover events should be safe now, I think, so the patch looks OK.

[Andras Becsi]

(In reply to comment #3)
> (In reply to comment #2)
> > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling.
> 
> Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also.
> 

That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events.
This should be addressed later.

[Sergio Villar Senin]

(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling.
> > 
> > Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also.
> > 
> 
> That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events.
> This should be addressed later.

That's true but might be it should be addressed in a separate bug. So anything to change in the current patch?

[Andras Becsi]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > So this is basically a follow up of a discussion that started in bug 80542. It was mentioned that hybrid devices (mixing touch and pointing interfaces) like the ones that will be likely shipped with Windows 8 or devices with pointing controllers (similar to Wii) will likely use a flickable webview and would require mouse event handling.
> > > 
> > > Since http://trac.webkit.org/changeset/124455 the code paths for mouse and touch are unified and mouse events were enabled for the flickable webview also.
> > > 
> > 
> > That said, having a device that has both mouse and touch capabilities might result in some unexpected behaviour, especially because the gesture recognition logic is not prepared for some possible corner cases with alternating input events.
> > This should be addressed later.
> 
> That's true but might be it should be addressed in a separate bug. So anything to change in the current patch?

The patch is fine.
Of course other issues we find in relation to mouse and touch at the same time should be addressed in separate bugs.

[Sergio Villar Senin]

Comment on attachment 170488 [details]
Patch

Clearing flags on attachment: 170488

Committed r132919: <http://trac.webkit.org/changeset/132919>

[Sergio Villar Senin]

All reviewed patches have been landed.  Closing bug.