Bug 100272 – Layout Test fast/media/w3c/test_media_queries.html is slow on Chromium debug bots after r132352

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Levi Weintraub]

It may just be slow. I'm updating test expectations and watching to find out.

[Levi Weintraub]

It looks like they really are just slow... First bot just passed at 12 seconds, the cutoff for Timeout when not marked slow.

[Levi Weintraub]

Confirmed, they're all passing now, just slow (as much as 17 seconds!).

[Kenneth Rohde Christiansen]

Maybe interesting for the performance people/bots :-)

[Alexander Shalamov]

(In reply to comment #3)
> Maybe interesting for the performance people/bots :-)

Yes, looks strange. I tested on quite slow machine, gtk and efl debug builds with RESOLUTION_MEDIA_QUERY disabled and test was executed within few seconds.

If slowness is a problem, we could relax W3C resolution tests and reduce number of queries that are trying to find dpi of the media.

  // Find the resolution using max-resolution
    var resolution = 0;
    do {
      ++resolution;
      if (resolution > 10000) {
        break;
      }
    } while (!query_applies("(max-resolution: " + resolution + "dpi)"));

I think we could change it to "resolution > 500".
Kenneth, what do you think?

[Kenneth Rohde Christiansen]

(In reply to comment #4)
> (In reply to comment #3)
> > Maybe interesting for the performance people/bots :-)
> 
> Yes, looks strange. I tested on quite slow machine, gtk and efl debug builds with RESOLUTION_MEDIA_QUERY disabled and test was executed within few seconds.
> 
> If slowness is a problem, we could relax W3C resolution tests and reduce number of queries that are trying to find dpi of the media.
> 
>   // Find the resolution using max-resolution
>     var resolution = 0;
>     do {
>       ++resolution;
>       if (resolution > 10000) {
>         break;
>       }
>     } while (!query_applies("(max-resolution: " + resolution + "dpi)"));
> 
> I think we could change it to "resolution > 500".
> Kenneth, what do you think?

I am pretty sure it will bail out way before 500, anyway. Ah you are right, it won't if they have it disabled. We should run (resolution) first to check whether it is supported or not.

[Alexander Shalamov]

Created attachment 170584 [details]
Patch 1

- Added check for resolution media query tests

[WebKit Review Bot]

Comment on attachment 170584 [details]
Patch 1

Clearing flags on attachment: 170584

Committed r132461: <http://trac.webkit.org/changeset/132461>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.