Bug 100256

Summary: change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
Product: WebKit Reporter: Michael Carmody <mcarmody>
Component: WebKit BlackBerryAssignee: Michael Carmody <mcarmody>
Status: RESOLVED FIXED    
Severity: Enhancement CC: gyuyoung.kim, mcarmody, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.3   
Attachments:
Description Flags
Patch
none
Patch none

Michael Carmody
Reported 2012-10-24 08:35:16 PDT
If BB_RELEASE_FLAGS or BB_DEBUG_FLAGS are present in enviroment copy values to resppect cmake flags.
Attachments
Patch (1.84 KB, patch)
2012-10-24 12:30 PDT, Michael Carmody 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2012-10-24 13:44 PDT, Michael Carmody 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Carmody
Comment 1 2012-10-24 12:30:12 PDT
Created attachment 170448 [details] Patch
Rob Buis
Comment 2 2012-10-24 13:22:26 PDT
Comment on attachment 170448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170448&action=review I agree this is useful! Please fix the minor issues. > Source/cmake/OptionsBlackBerry.cmake:129 > + message( "<<<< ENV Overide RELEASE ${CMAKE_CXX_FLAGS_RELEASE}" ) Better use == instead of <<<< to match our style elsewhere. Also it is override. > Source/cmake/OptionsBlackBerry.cmake:134 > + message( "<<<< ENV Overide DEBUG ${CMAKE_CXX_FLAGS_DEBUG}") Ditto.
Michael Carmody
Comment 3 2012-10-24 13:44:12 PDT
Created attachment 170463 [details] Patch
Rob Buis
Comment 4 2012-10-24 14:01:38 PDT
Comment on attachment 170463 [details] Patch Ok.
WebKit Review Bot
Comment 5 2012-10-24 15:49:15 PDT
Comment on attachment 170463 [details] Patch Clearing flags on attachment: 170463 Committed r132414: <http://trac.webkit.org/changeset/132414>
WebKit Review Bot
Comment 6 2012-10-24 15:49:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.