Bug 100210

Summary:

[BlackBerry] Support pixel tests for BlackBerry DRT

Product:

WebKit

Reporter:

Xiaobo Wang <xiaobwang>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mifenton, mxie, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
patch	rwlbuis: review+
patch - updated	none
patch - updated	none
patch - updated 2	charles.wei: commit-queue-
patch	none

Xiaobo Wang

Reported 2012-10-24 00:52:36 PDT

Our DRTs do not support "pixel tests" (i.e. pixel-by-pixel comparison). However, they should. RIM PR #142681

Attachments
patch (22.77 KB, patch) 2012-10-25 04:02 PDT, Xiaobo Wang	rwlbuis: review+	Details Formatted Diff Diff
patch - updated (22.64 KB, patch) 2012-10-25 22:13 PDT, Xiaobo Wang	no flags	Details Formatted Diff Diff
patch - updated (22.62 KB, patch) 2012-10-25 22:26 PDT, Xiaobo Wang	no flags	Details Formatted Diff Diff
patch - updated 2 (1.65 KB, patch) 2012-10-26 03:09 PDT, Xiaobo Wang	charles.wei: commit-queue-	Details Formatted Diff Diff
patch (2.51 KB, patch) 2012-10-26 03:23 PDT, Xiaobo Wang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Xiaobo Wang

Comment 1 2012-10-25 04:02:48 PDT

Created attachment 170605 [details] patch

Rob Buis

Comment 2 2012-10-25 07:59:35 PDT

Comment on attachment 170605 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=170605&action=review Looks good, please fix before landing. > Source/WebKit/ChangeLog:8 > + Adds a step to build ImageDiff from Qt for DRT. In general you probably want to credit Chris Wells, he did most of this patch AFAIK. > Tools/DumpRenderTree/blackberry/PNGImageEncoder.cpp:27 > +#endif Is this block really needed now that you got rid of Skia below? > Tools/DumpRenderTree/blackberry/build:4 > +# the ~/dev/webplatform/tools/binding_generator folder. These two lines are not relevant, please remove.

Xiaobo Wang

Comment 3 2012-10-25 21:08:48 PDT

Comment on attachment 170605 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=170605&action=review >> Source/WebKit/ChangeLog:8 >> + Adds a step to build ImageDiff from Qt for DRT. > > In general you probably want to credit Chris Wells, he did most of this patch AFAIK. OK. >> Tools/DumpRenderTree/blackberry/PNGImageEncoder.cpp:27 >> +#endif > > Is this block really needed now that you got rid of Skia below? I copied the PNGImageEncoder.cpp/h files from master_40 and added them to the patch. But yes, they can be removed. >> Tools/DumpRenderTree/blackberry/build:4 >> +# the ~/dev/webplatform/tools/binding_generator folder. > > These two lines are not relevant, please remove. OK.

Xiaobo Wang

Comment 4 2012-10-25 22:13:58 PDT

Created attachment 170811 [details] patch - updated

Xiaobo Wang

Comment 5 2012-10-25 22:26:38 PDT

Created attachment 170814 [details] patch - updated Reviewed by Rob Buis.

Charles Wei

Comment 6 2012-10-25 23:25:13 PDT

Comment on attachment 170814 [details] patch - updated commit.

WebKit Review Bot

Comment 7 2012-10-26 01:11:52 PDT

Comment on attachment 170814 [details] patch - updated Clearing flags on attachment: 170814 Committed r132582: <http://trac.webkit.org/changeset/132582>

Xiaobo Wang

Comment 8 2012-10-26 03:09:30 PDT

Created attachment 170864 [details] patch - updated 2

Charles Wei

Comment 9 2012-10-26 03:16:44 PDT

Comment on attachment 170864 [details] patch - updated 2 Please make a full patch with right commit log.

Xiaobo Wang

Comment 10 2012-10-26 03:23:39 PDT

Created attachment 170868 [details] patch Adding 2 missed files.

Charles Wei

Comment 11 2012-10-26 03:43:08 PDT

Comment on attachment 170868 [details] patch ok.

WebKit Review Bot

Comment 12 2012-10-26 04:08:12 PDT

Comment on attachment 170868 [details] patch Clearing flags on attachment: 170868 Committed r132610: <http://trac.webkit.org/changeset/132610>

Rob Buis

Comment 13 2013-01-04 09:53:35 PST

This was landed with two revisions, closing.

Note You need to log in before you can comment on or make changes to this bug.