Bug 100135

Summary: Code cleanup after r132165
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: DOMAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2012-10-23 09:22:17 PDT
From comment https://bugs.webkit.org/show_bug.cgi?id=99889#c4: (From update of attachment 169729 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=169729&action=review > Source/WebCore/xml/parser/MarkupTokenBase.h:148 > + void beginEndTag(Vector<LChar, 32> characters) This argument type should be const Vector&, unless we want to copy a vector each time for some reason! > Source/WebCore/xml/parser/MarkupTokenBase.h:396 > + inline const String nameString() const The const in this return type “const String” doesn’t add value and should be removed. The inline keyword also adds nothing. Not sure why surrounding functions are using it. --- There is another Vector argument that should be made a reference.
Attachments
Patch (2.41 KB, patch)
2012-10-23 13:20 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-23 13:20:25 PDT
Created attachment 170215 [details] Patch
Geoffrey Garen
Comment 2 2012-10-24 10:54:32 PDT
Comment on attachment 170215 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-10-24 11:00:46 PDT
Comment on attachment 170215 [details] Patch Clearing flags on attachment: 170215 Committed r132373: <http://trac.webkit.org/changeset/132373>
WebKit Review Bot
Comment 4 2012-10-24 11:00:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.