Bug 100114

Summary: Web Inspector: Timeline: nest time/timeEnd records when possible (in glue-mode)
Product: WebKit Reporter: eustas.bug
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 100936    
Bug Blocks: 99830    
Attachments:
Description Flags
Snapshot
none
Patch
none
Patch none

eustas.bug
Reported 2012-10-23 06:09:24 PDT
Created attachment 170140 [details] Snapshot Nesting time/timeEnd intervals will provide a better overview on what is happening.
Attachments
Snapshot (57.53 KB, image/png)
2012-10-23 06:09 PDT, eustas.bug 		no flags
Details
Patch (5.29 KB, patch)
2012-11-08 04:05 PST, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (5.25 KB, patch)
2012-12-29 00:20 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-11-08 04:05:58 PST
Created attachment 173004 [details] Patch
Pavel Feldman
Comment 2 2012-11-14 00:03:49 PST
Comment on attachment 173004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173004&action=review > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:602 > + openRecord.children.splice(insertionIndexForObjectInListSortedByFunction(timeRecord.startTime, openRecord.children, compareStartTime), 0, timeRecord); We only glue causation. I.e. we can glue TimerFire to TimerInstall. We can't glue timeEnd to anything, because it already has a parent. The rules for glueing should stay simple.
Eugene Klyuchnikov
Comment 3 2012-12-29 00:18:53 PST
Comment on attachment 173004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173004&action=review >> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:602 >> + openRecord.children.splice(insertionIndexForObjectInListSortedByFunction(timeRecord.startTime, openRecord.children, compareStartTime), 0, timeRecord); > > We only glue causation. I.e. we can glue TimerFire to TimerInstall. We can't glue timeEnd to anything, because it already has a parent. The rules for glueing should stay simple. To be more precise, we do not glue, but set correct parents to records to highlight their causation. In this case, developers would be happy to see how time/timeEnd relate to each other.
Eugene Klyuchnikov
Comment 4 2012-12-29 00:20:41 PST
Created attachment 180921 [details] Patch rebased
WebKit Review Bot
Comment 5 2013-01-18 04:21:32 PST
Comment on attachment 180921 [details] Patch Clearing flags on attachment: 180921 Committed r140123: <http://trac.webkit.org/changeset/140123>
WebKit Review Bot
Comment 6 2013-01-18 04:21:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.