Web Inspector: Timeline: nest time/timeEnd records when possible (in glue-mode)

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

Created attachment 170140 [details]
Snapshot

Nesting time/timeEnd intervals will provide a better overview on what is happening.

Created attachment 173004 [details]
Patch

[Pavel Feldman]

Comment on attachment 173004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173004&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:602
> +                openRecord.children.splice(insertionIndexForObjectInListSortedByFunction(timeRecord.startTime, openRecord.children, compareStartTime), 0, timeRecord);

We only glue causation. I.e. we can glue TimerFire to TimerInstall. We can't glue timeEnd to anything, because it already has a parent. The rules for glueing should stay simple.

[Eugene Klyuchnikov]

Comment on attachment 173004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173004&action=review

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:602
>> +                openRecord.children.splice(insertionIndexForObjectInListSortedByFunction(timeRecord.startTime, openRecord.children, compareStartTime), 0, timeRecord);
> 
> We only glue causation. I.e. we can glue TimerFire to TimerInstall. We can't glue timeEnd to anything, because it already has a parent. The rules for glueing should stay simple.

To be more precise, we do not glue, but set correct parents to records to highlight their causation.
In this case, developers would be happy to see how time/timeEnd relate to each other.

[Eugene Klyuchnikov]

Created attachment 180921 [details]
Patch

rebased

[WebKit Review Bot]

Comment on attachment 180921 [details]
Patch

Clearing flags on attachment: 180921

Committed r140123: <http://trac.webkit.org/changeset/140123>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.