Bug 100071 – Add canvas blending modes for chromium

• Component: Canvas
• Status: RESOLVED WONTFIX

[Rik Cabanier]

This bug will add the canvas blend modes using the chromium backend

[Rik Cabanier]

Created attachment 192946 [details]
not for review. awaiting fixes in skia

[WebKit Review Bot]

Comment on attachment 192946 [details]
not for review. awaiting fixes in skia

Attachment 192946 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17179068

New failing tests:
fast/canvas/canvas-blend-solid.html

[Justin Novosad]

Comment on attachment 192946 [details]
not for review. awaiting fixes in skia

View in context: https://bugs.webkit.org/attachment.cgi?id=192946&action=review

What are the skia fixes this is blocked on?

Why the expected test results with FAILs in them?

> Source/WebCore/platform/graphics/skia/SkiaUtils.cpp:89
> +        for (unsigned i = 0; i < SK_ARRAY_COUNT(gMapBlendOpsToXfermodeModes); i++) {

This loop is unfortunate. Is there no way we could turn this into: return gMapBlendOpsToXfermodeModes[blendMode]

[Rik Cabanier]

(In reply to comment #3)
> (From update of attachment 192946 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192946&action=review
> 
> What are the skia fixes this is blocked on?

https://chromiumcodereview.appspot.com/12662006/

> 
> Why the expected test results with FAILs in them?

The core graphics libraries don't follow the blending modes exactly. I'm trying to get Apple to fix them.
If they won't fix them, I will have to put platform specific test results in.

> 
> > Source/WebCore/platform/graphics/skia/SkiaUtils.cpp:89
> > +        for (unsigned i = 0; i < SK_ARRAY_COUNT(gMapBlendOpsToXfermodeModes); i++) {
> 
> This loop is unfortunate. Is there no way we could turn this into: return gMapBlendOpsToXfermodeModes[blendMode]

I agree. I followed the example right under my new code that sets up the compositing

[Rik Cabanier]

Created attachment 194595 [details]
Patch

[WebKit Review Bot]

Comment on attachment 194595 [details]
Patch

Attachment 194595 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17200676

New failing tests:
fast/canvas/canvas-blend-solid.html

[WebKit Review Bot]

Created attachment 194609 [details]
Archive of layout-test-results from gce-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Rik Cabanier]

Created attachment 195334 [details]
Patch

[Ion Rosca]

Created attachment 195701 [details]
Patch

[Darin Adler]

Comment on attachment 195701 [details]
Patch

Clearing flags from a Skia-specific patch.

[Stephen Chenney]

(In reply to comment #10)
> (From update of attachment 195701 [details])
> Clearing flags from a Skia-specific patch.

Sorry, from now on I'll make sure to clear flags as I migrate bugs.