Bug 100044

Summary: [Mac] Remove extraneous conversion to String->NSString
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, apinheiro, cfleizach, dmazzoni, japhet, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2012-10-22 15:57:02 PDT
Improve some unfortunate cases of implicit conversion.
Attachments
Patch (9.83 KB, patch)
2012-10-22 16:59 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-22 16:59:30 PDT
Created attachment 170029 [details] Patch
Darin Adler
Comment 2 2012-10-22 18:26:34 PDT
Comment on attachment 170029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170029&action=review > Source/WebCore/loader/mac/LoaderNSURLExtras.mm:75 > + if ((mimeType == "application/tar" || mimeType == "application/x-tar") Why is it OK for us to check something case insensitive (a MIME type) with a case sensitive comparison?
Benjamin Poulain
Comment 3 2012-10-23 14:32:27 PDT
> View in context: https://bugs.webkit.org/attachment.cgi?id=170029&action=review > > > Source/WebCore/loader/mac/LoaderNSURLExtras.mm:75 > > + if ((mimeType == "application/tar" || mimeType == "application/x-tar") > > Why is it OK for us to check something case insensitive (a MIME type) with a case sensitive comparison? I am not familiar with that code but it looks like MIMETypes are always compared lowercase in WebKit. I dug a little bit and it looks like NSURLResponse take care of converting the incoming bytes to a lowercase MIMEType.
Benjamin Poulain
Comment 4 2012-10-23 15:02:47 PDT
Comment on attachment 170029 [details] Patch Clearing flags on attachment: 170029 Committed r132272: <http://trac.webkit.org/changeset/132272>
Benjamin Poulain
Comment 5 2012-10-23 15:02:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.