Bug 100020

Summary:

[BlackBerry] Improve the use of stencil buffer during compositing

Product:

WebKit

Reporter:

Filip Spacek <fspacek>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, cmarcelo, macpherson, menard, mifenton, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Improve stenciling	none
improve stenciling	buildbot: commit-queue-
stencil patch	none

Filip Spacek

Reported 2012-10-22 13:26:30 PDT

Stenciling is required only rarely so the common code path should not touch the stencil buffer at all and setup any stenciling state on-demand. In particular, currently LayerRenderer::setViewport unconditionally clears the stencil buffer even in the case where there is nothing at all to composite. This patch also removes the ENABLE_SCISSOR define as it has been empirically determined that careful scissoring is always a win on all platforms.

Attachments
Improve stenciling (1.41 KB, patch) 2012-10-22 13:34 PDT, Filip Spacek	no flags	Details Formatted Diff Diff
improve stenciling (7.69 KB, patch) 2012-10-22 13:41 PDT, Filip Spacek	buildbot: commit-queue-	Details Formatted Diff Diff
stencil patch (7.69 KB, patch) 2012-10-23 04:59 PDT, Filip Spacek	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Spacek

Comment 1 2012-10-22 13:34:02 PDT

Created attachment 169970 [details] Improve stenciling

Filip Spacek

Comment 2 2012-10-22 13:41:46 PDT

Created attachment 169972 [details] improve stenciling

WebKit Review Bot

Comment 3 2012-10-22 13:44:55 PDT

Attachment 169972 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:978: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 4 2012-10-22 14:48:05 PDT

Comment on attachment 169972 [details] improve stenciling Attachment 169972 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14488574 New failing tests: inspector/profiler/heap-snapshot.html

Filip Spacek

Comment 5 2012-10-23 04:59:48 PDT

Created attachment 170127 [details] stencil patch

Rob Buis

Comment 6 2012-10-23 07:24:08 PDT

Comment on attachment 170127 [details] stencil patch LGTM.

WebKit Review Bot

Comment 7 2012-10-23 07:29:28 PDT

Comment on attachment 170127 [details] stencil patch Clearing flags on attachment: 170127 Committed r132219: <http://trac.webkit.org/changeset/132219>

WebKit Review Bot

Comment 8 2012-10-23 07:29:32 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.