Bug 76531

Summary: [GTK] platform/gtk/accessibility/combo-box-collapsed-selection-changed.html is failing after r105253
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: pnormand, tkent, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 76620    
Bug Blocks: 25531    
Attachments:
Description Flags
Patch proposal
none
Patch proposal none

Description Mario Sanchez Prada 2012-01-18 04:56:32 PST 
This test has started failing after r105253, which made the 'selected' and 'focused' events to be emitted anymore for AtkObjects representing list boxes and menu lists.

As the failure is localized in the GTK port only, I think it's sensible to skip the test for now, while working on a real patch that gets everything working fine in that port back again (see original bug 53146)
Comment 1 Mario Sanchez Prada 2012-01-18 04:59:24 PST 
This blocks basic a11y support
Comment 2 Mario Sanchez Prada 2012-01-19 04:38:02 PST 
Created attachment 123105 [details]
Patch proposal
Comment 3 Mario Sanchez Prada 2012-01-19 04:39:51 PST 
Created attachment 123106 [details]
Patch proposal

Sorry, this one is the good one.
Comment 4 Martin Robinson 2012-01-19 09:29:01 PST 
Comment on attachment 123106 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=123106&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:978
> -#if !PLATFORM(WIN) || OS(WINCE)
> +#if !PLATFORM(GTK) && !PLATFORM(WIN) || OS(WINCE)

Couldn't you achieve the same effect by returning something different from popsMenuByArrowKeys?
Comment 5 Kent Tamura 2012-01-19 16:16:44 PST 
Wasn't it fixed by http://trac.webkit.org/changeset/105286 ?
Comment 6 Mario Sanchez Prada 2012-01-20 03:40:20 PST 
(In reply to comment #5)
> Wasn't it fixed by http://trac.webkit.org/changeset/105286 ?

You are right. I didn't realize of that commit, which actually looks like a better fix than this one.

So, I'm now resolving this one as duplicate, and soon pushing an unreviewed patch to unskip this test.

Thanks!

*** This bug has been marked as a duplicate of bug 76549 ***