Bug 60477

Summary: [Qt] Tab not working in editing/inserting/typing-tab-designmode-forms.html
Product: WebKit Reporter: Chang Shu <cshu>
Component: HTML EditingAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ademar, commit-queue, eric, rniwa, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 60554    
Bug Blocks:    
Attachments:
Description Flags
fix patch none

Description Chang Shu 2011-05-09 08:53:34 PDT 
In the above test, type 'tab' should insert tab-space in the form. But it didn't happen.
Comment 1 Chang Shu 2011-05-09 08:54:57 PDT 
editing/inserting/typing-tab-designmode.html
seems to have the same problem.
Comment 2 Chang Shu 2011-05-10 10:54:40 PDT 
Created attachment 92982 [details]
fix patch
Comment 3 Ryosuke Niwa 2011-05-11 08:34:34 PDT 
Comment on attachment 92982 [details]
fix patch

Looks sane to me but I guess someone from Qt port should review it.
Comment 4 Chang Shu 2011-05-11 09:12:18 PDT 
Comment on attachment 92982 [details]
fix patch

thanks, guys.
Comment 5 WebKit Commit Bot 2011-05-11 09:54:20 PDT 
The commit-queue encountered the following flaky tests while processing attachment 92982 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-05-11 09:59:25 PDT 
Comment on attachment 92982 [details]
fix patch

Clearing flags on attachment: 92982

Committed r86243: <http://trac.webkit.org/changeset/86243>
Comment 7 WebKit Commit Bot 2011-05-11 09:59:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-05-11 11:52:09 PDT 
http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests)
The following tests are not passing:
inspector/debugger/source-frame.html
inspector/extensions/extensions.html
media/controls-without-preload.html
Comment 9 Chang Shu 2011-05-11 12:14:48 PDT 
(In reply to comment #8)
> http://trac.webkit.org/changeset/86243 might have broken Windows XP Debug (Tests)
> The following tests are not passing:
> inspector/debugger/source-frame.html
> inspector/extensions/extensions.html
> media/controls-without-preload.html

The patch only touched Qt code.
Comment 10 Ademar Reis 2011-05-16 14:04:04 PDT 
Revision r86243 cherry-picked into qtwebkit-2.2 with commit 614ea61 <http://gitorious.org/webkit/qtwebkit/commit/614ea61>