|Summary:||Move makeSecure from WTF::String to renderText|
|Product:||WebKit||Reporter:||Chang Shu <cshu>|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Chang Shu 2011-04-21 10:33:37 PDT
makeSecure is not a general-purpose string utility but a particular operation intended for rendertext only. We should move it to the right place to avoid layering violation.
Comment 2 Alexey Proskuryakov 2011-04-22 12:50:38 PDT
Comment 3 Chang Shu 2011-07-06 09:01:29 PDT
The dependency from 32509 is removed. No emergency to fix this issue.
Comment 5 Chang Shu 2011-07-08 08:48:02 PDT
found a solution.
Comment 6 Alexey Proskuryakov 2011-07-08 09:04:44 PDT
Comment 7 Chang Shu 2011-07-08 09:10:22 PDT
Comment 8 Chang Shu 2011-07-08 09:15:37 PDT
Created attachment 100125 [details] patch 3: minor changes after r+
Comment 9 Alexey Proskuryakov 2011-07-08 09:43:23 PDT
> The style script reports this: The script is not a reviewer :)
Comment 10 Alexey Proskuryakov 2011-07-08 09:49:44 PDT
I think that consistency is more important in this case than style script suggestions.
Comment 11 Chang Shu 2011-07-08 10:03:13 PDT
(In reply to comment #10) > I think that consistency is more important in this case than style script suggestions. Would the patch be committed if not passing style check?
Comment 12 Chang Shu 2011-07-08 10:15:11 PDT
Created attachment 100129 [details] patch 4: minor changes after r+
Comment 13 WebKit Review Bot 2011-07-08 10:17:45 PDT
Comment 14 WebKit Review Bot 2011-07-08 10:54:18 PDT
Comment on attachment 100129 [details] patch 4: minor changes after r+ Clearing flags on attachment: 100129 Committed r90643: <http://trac.webkit.org/changeset/90643>
Comment 15 WebKit Review Bot 2011-07-08 10:54:23 PDT
All reviewed patches have been landed. Closing bug.