Summary: | Implement HTML5 <hgroup> element. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, gustavo, mjs, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | HTML5 | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
URL: | http://www.w3.org/TR/html5/semantics.html#the-hgroup-element | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 32934 | ||||||||
Attachments: |
|
Description
Kent Tamura
2010-01-08 01:48:34 PST
Created attachment 46119 [details]
Proposed patch
style-queue ran check-webkit-style on attachment 46119 [details] without any errors.
Comment on attachment 46119 [details]
Proposed patch
The ChangeLog talks about <aside>?
(In reply to comment #3) > The ChangeLog talks about <aside>? Oh, silly copy&paste mistake. I'll update the patch... Created attachment 47477 [details]
Proposed patch (rev.2)
Every time I see this change in the review queue I skip over it becase I don't know what this is for or why we'd want it. I guess I just need to read the html5 spec. Could you explain in the bug what <hgroup> is and why we would want it? (In reply to comment #7) > Could you explain in the bug what <hgroup> is and why we would want it? Because it is defined in HTML5. http://www.w3.org/TR/html5/semantics.html#the-hgroup-element Though I feel the benefit of <hgroup>is less than other sectioning elements such as <section> <article> we already have, the example in the specification is reasonable and <hgroup> is not harmful. Comment on attachment 47477 [details]
Proposed patch (rev.2)
Sorry this took so long to review. HTML5++.
Landed as r55710. It appears this checkin broke the Gtk bot: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r55710%20(589)/results.html (Or possibly the Gtk bot simply got itself wedged). (In reply to comment #11) > It appears this checkin broke the Gtk bot: > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r55710%20(589)/results.html > > (Or possibly the Gtk bot simply got itself wedged). Yes, looks like a temporary failure of the bot there, should be fixed now. |