|Product:||WebKit||Reporter:||Dirk Pranke <dpranke>|
|Component:||Tools / Tests||Assignee:||Dirk Pranke <dpranke>|
|Severity:||Normal||CC:||andersca, aroben, commit-queue, darin, eric, jam, mbelshe, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Dirk Pranke 2009-12-18 18:49:28 PST
Upstreaming a test from chromium.org - Chromium has chosen to implement slightly different behavior for LayoutTests/plugins/get-url-with-blank-target.html . See http://code.google.com/p/chromium/issues/detail?id=24186 for more context.
Comment 2 WebKit Review Bot 2009-12-18 18:52:39 PST
style-queue ran check-webkit-style on attachment 45218 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-19 11:45:47 PST
I'm confused by how this is different from the original and if this test still needs to be forked now that chromium is not secret.
Comment 4 Dirk Pranke 2009-12-21 14:51:47 PST
I'm not sure I fully understand how it's different, either, but according to http://code.google.com/p/chromium/issues/detail?id=24186 it is, and we don't want to merge the two.
Comment 5 Eric Seidel (no email) 2009-12-22 14:08:06 PST
That bug seems to suggest that WebKit's existing behavior, at least on the Mac, is wrong. So I'm not sure that adding this test is the correct fix.
Comment 6 Dirk Pranke 2009-12-22 14:18:50 PST
Okay. I suggest then that we remove this test downstream, change this bug to suggest that the generic test is wrong (and WebKit Mac is wrong), and then either fix the test, fix the code, or then agree to disagree. Sound good?
Comment 7 Eric Seidel (no email) 2009-12-22 14:55:45 PST
The relevant comments from the Chromium bug: I'm in this code, and ran into this bug. I think the idea that webkit wants this window to not open is incorrect. Reasons: 1) The spec doesn't say so 2) Firefox doesn't behave that way. (It does open the window but does not callback to the JS notify routine at all) 3) Safari 3.1 for windows does not behave that way. (It opens the apple.com URL in a new window and returns error success). mbelshe on March 31 2008 12:09 (Fixed / Fixed) Notes I fixed the layout test for this to reflect my latest comments.
Comment 8 Eric Seidel (no email) 2009-12-22 14:56:36 PST
The original test was written by Anders, and reviewed by aroben and darin.
Comment 9 Eric Seidel (no email) 2009-12-22 15:09:20 PST
Comment on attachment 45218 [details] Patch I don't think it makes sense to block upstreaming of Chromium's tests. However, i do think it makes sense to have a bug about the differing behavior between this test and the original. This bug could serve that purpose. "behavior. i" seems to be a typo in the ChangeLog. I think we should probably just land this as-is, and follow-up with a more informed fix to make Chromium and other WebKit ports agree here. Lets fix the ChangeLog to note that this behavior difference should be remedied but for now we're at least testing the behavior. +var NPERR_GENERIC_ERROR = 1; line isn't really needed in this edited version of the test, but does no harm. So I'll r+ this one, but since you're not a committer quiet yet, please post a new patch which updates the changelog to explain the intent to unify these behaviors.
Comment 10 Dirk Pranke 2009-12-22 15:10:33 PST
Comment 11 Dirk Pranke 2009-12-22 15:28:46 PST
Created attachment 45408 [details] patch w/ revised ChangeLog entry
Comment 12 WebKit Review Bot 2009-12-22 15:29:57 PST
style-queue ran check-webkit-style on attachment 45408 [details] without any errors.
Comment 13 WebKit Commit Bot 2009-12-22 15:50:12 PST
Comment on attachment 45408 [details] patch w/ revised ChangeLog entry Clearing flags on attachment: 45408 Committed r52506: <http://trac.webkit.org/changeset/52506>
Comment 14 WebKit Commit Bot 2009-12-22 15:50:17 PST
All reviewed patches have been landed. Closing bug.