Summary: | SVG filter on filter don't work | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 525.x (Safari 3.1) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68469, 26389 | ||||||||
Attachments: |
|
Description
Dirk Schulze
2009-12-18 03:56:17 PST
I don't see a reason, why a tspan element shouldn't be rendered with a filter, if the text is rendered with the same filter? I couldn't find anythink about this strange behavior in the spec. Why should it only be possible that both, tspan and text, use filters, if the filters differ? Only batik and WebKit are doing this. I would like to delete this constraints if there is no plaussible reason to do that. Hm interessting, I can't remember for which testcase this "hack" has been added, can you just try to delete the checks, and see what breaks? I run all svg tests and none of them break after deleting this check. There is still no reason for me to use this constraint beside to be compatible with batik. FF and Opera allow filters on text and tspan and also use them seperatly. I'll write a patch with a simple test to get rid of this limitation. Created attachment 57807 [details]
Patch
Attachment 57807 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3013040 (In reply to comment #5) > Attachment 57807 [details] did not build on mac: > Build output: http://webkit-commit-queue.appspot.com/results/3013040 Sorry buildbot, but it doesn't look like it was my fault. Comment on attachment 57807 [details]
Patch
r=me, mac ews has a problem unrelated to your patch "distccd[37387] (dcc_writex) ERROR: failed to write: No space left on device".
Please change the text to "This is for filter on filter", instead of "This is a for filter on filter" before landing :-)
(In reply to comment #7) > (From update of attachment 57807 [details]) > r=me, mac ews has a problem unrelated to your patch "distccd[37387] (dcc_writex) ERROR: failed to write: No space left on device". > Please change the text to "This is for filter on filter", instead of "This is a for filter on filter" before landing :-) ? Really? the mac-ews bot is only using 13% of its disk. Maybe one of the other machines in teh cluster is out of space? Thanks. I've notified the admin of that machine and it shoudl be fixed soon. Committed r60689: <http://trac.webkit.org/changeset/60689> |