Bug 30799

Summary: [Gtk] Implement the remainder of the AtkTable interface
Product: WebKit Reporter: Joanmarie Diggs (irc: joanie) <jdiggs>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: brian.holt, bugs-noreply, jmalonzo, mario, walker.willie
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 30796, 98380    

Description Joanmarie Diggs (irc: joanie) 2009-10-26 16:56:56 PDT
The following AtkTable functions will need to be implemented in order for a user to interact with editable, web-based tables (e.g. Google docs):

* atk_table_set_caption 
* atk_table_set_row_description
* atk_table_set_column_description 
* atk_table_set_row_header         
* atk_table_set_column_header      
* atk_table_set_summary            
* atk_table_get_selected_columns   
* atk_table_get_selected_rows      
* atk_table_is_column_selected     
* atk_table_is_row_selected        
* atk_table_is_selected            
* atk_table_add_column_selection   
* atk_table_add_row_selection      
* atk_table_remove_column_selection
* atk_table_remove_row_selection
Comment 1 Joanmarie Diggs (irc: joanie) 2009-10-26 17:41:26 PDT
Signals too.

  "column-deleted" 
  "column-inserted"  
  "column-reordered" 
  "model-changed"    
  "row-deleted"      
  "row-inserted" 
  "row-reordered"
Comment 2 Brian Holt 2013-02-06 01:45:02 PST
Is this bug still an issue? If so I wonder if it would be suitable for a newbie like me to gain some familiarity with WebKit a11y?
Comment 3 Mario Sanchez Prada 2013-02-06 02:49:39 PST
(In reply to comment #2)
> Is this bug still an issue? If so I wonder if it would be
> suitable for a newbie like me to gain some familiarity with WebKit a11y?

This bug is one of those blocking the RIA bug (bug 30796) and so I guess it's perhaps not the easiest start point. I would suggest picking up one of the bugs blocking bug 25531, which is about non-RIA stuff.

You can take a look into the tree of current bugs there here:
https://bugs.webkit.org/show_bug.cgi?id=25531

Perhaps a good thing could be to try to resurrect the patch for bug 59737? :)
Comment 4 Mario Sanchez Prada 2013-07-29 06:31:58 PDT
I've been taking a look to this bug for a while and I would like to share some comments/thoughts here...

(In reply to comment #0)
> [...]
> * atk_table_set_caption 
> * atk_table_set_row_description
> * atk_table_set_column_description 
> * atk_table_set_row_header         
> * atk_table_set_column_header      
> * atk_table_set_summary            

The methods above do not seem to be implemented in the ATK bridge for at-spi2 at all, so I guess it's not worth implementing them yet. Joanie, what's your take on this?

> * atk_table_get_selected_columns   
> * atk_table_is_column_selected         
> * atk_table_add_column_selection   
> * atk_table_remove_column_selection

According to what I've seen by looking at the code in accessibility/ and the Mac wrapper, it seems that column selections is not supported yet for HTML tables, but Chris will probably be able to expand a bit more on this.

> * atk_table_get_selected_rows 
> * atk_table_is_row_selected        
> * atk_table_is_selected

These three should be easily implementable right now, by using the current a11y API. Not sure whether that would cover all the expected cases such as the one Joanie mentioned when reporting this bug (Google docs), but that would be a start.

> * atk_table_add_row_selection      
> * atk_table_remove_row_selection

I've taken a look to setSelected() and setSelectedRows() (which relies on setSelected(), but it seems setSelected() will only do something for instances of AccessibilityListBoxOption() and AccessibilityMenuListOption() which is not the case for data tables, like those used in spreadsheets.

I'm probably missing something here, so I'd certainly would appreciate if someone could enlighten me a bit on this on this too. Thanks