| Summary: | SVG wrong filterRegions for userSpaceOnUse and percentage values | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||||
| Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | zimmermann | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 525.x (Safari 3.1) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 68469, 26389 | ||||||||||||
| Attachments: |
|
||||||||||||
Own tests show, that the filterRegion works like expected. It's just effect subRegion that need improvement. Created attachment 41121 [details]
Filter code clean-up
This clean-up helps to catch the bug. This patch makes the code more look like Masker and Clipping. Moved complete calculation of filterRegion from SVGResourceFilter to SVGFilterElement. This doesn't change functionality. So ne new test needed.
Comment on attachment 41121 [details]
Filter code clean-up
I'll upload an new patch with further clean-up and a fix of the problem.
Created attachment 41180 [details]
Fix for effectRect values and userSpaceOnUse
Created attachment 41182 [details]
Fix for effectRect values and userSpaceOnUse
Mixed up some patches. Here the correct one.
Comment on attachment 41182 [details]
Fix for effectRect values and userSpaceOnUse
Looks great, r=me.
|
Created attachment 41096 [details] Example for fFilerRegions problem, should see red,white,blue rects The calculation of filterRegion and subRegions are wrong when filterUnits or filterPrimitiveUnits use userSpaceOnUse and percentage values for x,y,width,height. It would be the best, but difficult to move the complete region code to SVGFilterElement and SVGFilterPrimitiveStandardAttributes. I think we didn't Move it there from the beginning because we need to wait till the rendered object is drawn before we can calculate the regions. I'll investigate this a bit more.