Summary: | Rename MediaStreamSource to RealtimeMediaSource | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adam.bergkvist, commit-queue, eric.carlson, pnormand | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 143211 | ||||||||
Attachments: |
|
Description
Philippe Normand
2015-03-05 01:43:01 PST
Created attachment 247953 [details]
patch
Attachment 247953 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:40: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaStream.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVAudioCaptureSource.mm:34: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mock/MockMediaStreamCenter.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.h:32: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:36: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSourceStates.cpp:35: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:37: You should not add a blank line before implementation file's own header. [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/UserMediaRequest.h:40: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/Modules/mediastream/MediaStreamTrack.h:35: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/MediaStreamPrivate.h:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 11 in 49 files
If any of these errors are false positives, please file a bug against check-webkit-style.
You need to modify the names in the Xcode project. Right, I'll take care of this and other code style issues as well :) Comment on attachment 247953 [details]
patch
Looks like you missed something, which is why the build is failing. I suggest doing this rename with the do-webcore-rename script.
Created attachment 248050 [details]
patch
Committed r181152: <http://trac.webkit.org/changeset/181152> |