Summary: | Add tests to check filter, mask, clip, opacity and marker ordering | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, krit, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Bug Depends on: | 14012 | ||||||||
Bug Blocks: | 68469, 26389 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-06-06 02:25:32 PDT
We realy use the wrong order. At first the filter should be applied to the object, than masker/clipping and opacity at the end. The order of masker and clipper doesn't realy matter. Either we clip the content away and mask afterwards or we mask the content and clip it afterwards. There is no difference in the result. I'll upload a patch. Created attachment 45139 [details]
Correct order of filter clipper and masker
Correct order of filter clipper and masker.
style-queue ran check-webkit-style on attachment 45139 [details] without any errors.
Comment on attachment 45139 [details]
Correct order of filter clipper and masker
Ideally your ChangeLog should link to the relevant section of the spec. Or at least the bug should.
It looks like the rect in the mask you made doesn't do anything. It's not clear to me from the example how it would have changed from the old behavior ro the new one, but I believe you when you say it changed.
Created attachment 45181 [details]
Correct order of filter clipper and masker
The mask on the example just dims the contrast and shows, that it doesn't have any affect on the clipping. You can still see, that the clipper affects on top of the filtering.
I changed the Changelog and mention the part of the spec. I swiched the masker and clipper. We might profit of clipping away some context before the masking process later.
style-queue ran check-webkit-style on attachment 45181 [details] without any errors.
Comment on attachment 45181 [details]
Correct order of filter clipper and masker
krit++ Finally! r=me.
Comment on attachment 45181 [details] Correct order of filter clipper and masker Clearing flags on attachment: 45181 Committed r52394: <http://trac.webkit.org/changeset/52394> All reviewed patches have been landed. Closing bug. |