99993 2012-10-22 06:51:53 -0700 [EFL][WK2] Memory leak in Ewk_Form_Submission_Request::fieldValue() 2012-10-22 08:03:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 747495 0 cdumez 2012-10-22 06:51:53 -0700 In Ewk_Form_Submission_Request::fieldValue(), we should adopt the WKStringRef returned by toCopiedAPI() to avoid a leak. 747497 1 169900 cdumez 2012-10-22 06:53:57 -0700 Created attachment 169900 Patch 747549 2 169900 webkit.review.bot 2012-10-22 08:03:15 -0700 Comment on attachment 169900 Patch Clearing flags on attachment: 169900 Committed r132073: <http://trac.webkit.org/changeset/132073> 747550 3 webkit.review.bot 2012-10-22 08:03:20 -0700 All reviewed patches have been landed. Closing bug. 169900 2012-10-22 06:53:57 -0700 2012-10-22 08:03:15 -0700 Patch 99993_memory_leak.patch text/plain 1677 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMGZiNjUwLi4wNmY5MmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTItMTAtMjIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIE1lbW9yeSBsZWFrIGluIEV3a19Gb3JtX1N1Ym1p c3Npb25fUmVxdWVzdDo6ZmllbGRWYWx1ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05OTk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkb3B0IHRoZSBXS1N0cmluZ1JlZiByZXR1cm5lZCBieSB0b0Nv cGllZEFQSSgpIGluCisgICAgICAgIEV3a19Gb3JtX1N1Ym1pc3Npb25fUmVxdWVzdDo6ZmllbGRW YWx1ZSgpIHRvIGF2b2lkCisgICAgICAgIGEgbWVtb3J5IGxlYWsuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2VmbC9ld2tfZm9ybV9zdWJtaXNzaW9uX3JlcXVlc3QuY3BwOgorICAgICAgICAo RXdrX0Zvcm1fU3VibWlzc2lvbl9SZXF1ZXN0OjpmaWVsZFZhbHVlKToKKworMjAxMi0xMC0yMiAg Q2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCiAgICAgICAg IFtFRkxdW1dLMl0gTWFrZSB0aGUgcmVzb3VyY2UgbG9hZCBjbGllbnQgYSBDKysgY2xhc3MKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5OTgyCiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19mb3JtX3N1Ym1p c3Npb25fcmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf Zm9ybV9zdWJtaXNzaW9uX3JlcXVlc3QuY3BwCmluZGV4IDc2ZGUyMWEuLmNlY2FkNzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19mb3JtX3N1Ym1pc3Np b25fcmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr X2Zvcm1fc3VibWlzc2lvbl9yZXF1ZXN0LmNwcApAQCAtNTEsNyArNTEsNyBAQCBFd2tfRm9ybV9T dWJtaXNzaW9uX1JlcXVlc3Q6On5Fd2tfRm9ybV9TdWJtaXNzaW9uX1JlcXVlc3QoKQogU3RyaW5n IEV3a19Gb3JtX1N1Ym1pc3Npb25fUmVxdWVzdDo6ZmllbGRWYWx1ZShjb25zdCBTdHJpbmcmIGZp ZWxkTmFtZSkgY29uc3QKIHsKICAgICBBU1NFUlQoZmllbGROYW1lKTsKLSAgICBXS1JldGFpblB0 cjxXS1N0cmluZ1JlZj4gd2tGaWVsZE5hbWUgPSB0b0NvcGllZEFQSShmaWVsZE5hbWUpOworICAg IFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB3a0ZpZWxkTmFtZSA9IGFkb3B0V0sodG9Db3BpZWRB UEkoZmllbGROYW1lKSk7CiAgICAgV0tTdHJpbmdSZWYgd2tWYWx1ZSA9IHN0YXRpY19jYXN0PFdL U3RyaW5nUmVmPihXS0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KG1fd2tWYWx1ZXMuZ2V0KCksIHdr RmllbGROYW1lLmdldCgpKSk7CiAKICAgICByZXR1cm4gd2tWYWx1ZSA/IHRvSW1wbCh3a1ZhbHVl KS0+c3RyaW5nKCkgOiBTdHJpbmcoKTsK