99981 2012-10-22 05:21:27 -0700 [Qt] Fix build without QtWidgets 2012-10-22 06:36:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hausmann hausmann abecsi cmarcelo menard webkit.review.bot oldest_to_newest 747448 0 hausmann 2012-10-22 05:21:27 -0700 [Qt] Fix build without QtWidgets 747450 1 169881 hausmann 2012-10-22 05:23:01 -0700 Created attachment 169881 Patch 747455 2 169881 vestbo 2012-10-22 05:30:47 -0700 Comment on attachment 169881 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169881&action=review r with minor comment > Source/WebKit2/WebProcess.pro:17 > +!isEmpty(QT.widgets.name): QT += widgets haveQtModule() ? 747489 3 hausmann 2012-10-22 06:36:31 -0700 Committed r132066: <http://trac.webkit.org/changeset/132066> 169881 2012-10-22 05:23:01 -0700 2012-10-22 05:30:46 -0700 Patch bug-99981-20121022142140.patch text/plain 4304 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDA1MTkyMTJhOWRm ODMxNTMyMzIzMTU0YmMwZWYxOTI0NzM4MzQ4YTguLjRiYTI1ZTQzZjgwM2FhM2M4MmZjZTRjM2Qz N2Q2NTg0NjNlNTdjMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MjIgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgorCisgICAgICAg IFtRdF0gRml4IGJ1aWxkIHdpdGhvdXQgUXRXaWRnZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBkZXBlbmRlbmN5IHRvIFF0V2lkZ2V0cyB0 aGF0IGlzIG5vdCBuZWVkZWQgaGVyZSBhbnltb3JlIHNpbmNlCisgICAgICAgIHRoZSByZW1vdmFs IG9mIHRoZSBRdFF1aWNrMSBjb2RlLgorCisgICAgICAgICogZGVjbGFyYXRpdmUvZXhwZXJpbWVu dGFsL2V4cGVyaW1lbnRhbC5wcmk6CisgICAgICAgICogZGVjbGFyYXRpdmUvcHVibGljLnByaToK KwogMjAxMi0xMC0yMiAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEu Y29tPgogCiAgICAgICAgIFtRdF0gRml4ICJBU1NFUlRJT04gRkFJTEVEOiAhZG9jdW1lbnQtPmlu UGFnZUNhY2hlKCkiIHdoZW4gbG9hZGluZyBhIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlNjY2ZmRkZTFj NzI3ZTAzZDU5NmJkNDUxNDJlNzA4NDkwNDg3MzRhLi5jNzdkODZlMDdkZDVjYjlkZWQ0MDg4OWEx YjhlNTU5OGNmMWQ0ZGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTAtMjIg IFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gRml4IGJ1aWxkIHdpdGhvdXQgUXRXaWRnZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gY29tcGlsZSBXZWJQcm9j ZXNzIHdpdGhvdXQgUXRXaWRnZXRzIGJ5IGluc3RhbnRpYXRpbmcgYQorICAgICAgICBRR3VpQXBw bGljYXRpb24gaW5zdGVhZCBvZiBhIFFBcHBsaWNhdGlvbiBpZiB3ZSdyZSBidWlsdCB3aXRob3V0 IHdpZGdldHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzLnBybzoKKyAgICAgICAgKiBxdC9NYWlu UXQuY3BwOgorICAgICAgICAobWFpbik6CisKIDIwMTItMTAtMjIgIFJ5dWFuIENob2kgIDxyeXVh bi5jaG9pQGdtYWlsLmNvbT4KIAogICAgICAgICBbRUZMXSBwYyBmaWxlcyBzaG91bGQgdXNlIERB VEFfSU5TVEFMTF9ESVIgZm9yIGRhdGFkaXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQv ZGVjbGFyYXRpdmUvZXhwZXJpbWVudGFsL2V4cGVyaW1lbnRhbC5wcmkgYi9Tb3VyY2UvV2ViS2l0 L3F0L2RlY2xhcmF0aXZlL2V4cGVyaW1lbnRhbC9leHBlcmltZW50YWwucHJpCmluZGV4IDE3OTJi MGViYmE3ZDNkMzA4OWIyNTZiNTMzMjIwYTliZDM0NmE4ODguLjM3NzUwNTZhYWU1YTE2YTU1ZGQ0 MDNkYjRhZTBhYThkNjZkYmI4NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvZGVjbGFy YXRpdmUvZXhwZXJpbWVudGFsL2V4cGVyaW1lbnRhbC5wcmkKKysrIGIvU291cmNlL1dlYktpdC9x dC9kZWNsYXJhdGl2ZS9leHBlcmltZW50YWwvZXhwZXJpbWVudGFsLnByaQpAQCAtMjQsNyArMjQs NyBAQCBjb250YWlucyhRVF9DT05GSUcsIHJlZHVjZV9leHBvcnRzKTpDT05GSUcgKz0gaGlkZV9z eW1ib2xzCiAKIHdpbmNlKjpMSUJTICs9ICQkUU1BS0VfTElCU19HVUkKIAotUVQgKz0gd2lkZ2V0 cyBuZXR3b3JrIHF1aWNrIHF1aWNrLXByaXZhdGUgd2Via2l0d2lkZ2V0cyB3ZWJraXR3aWRnZXRz LXByaXZhdGUKK1FUICs9IG5ldHdvcmsgcXVpY2sgcXVpY2stcHJpdmF0ZSB3ZWJraXR3aWRnZXRz IHdlYmtpdHdpZGdldHMtcHJpdmF0ZQogCiBERVNURElSID0gJCR7Uk9PVF9CVUlMRF9ESVJ9L2lt cG9ydHMvJCR7VEFSR0VULm1vZHVsZV9uYW1lfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L3F0L2RlY2xhcmF0aXZlL3B1YmxpYy5wcmkgYi9Tb3VyY2UvV2ViS2l0L3F0L2RlY2xhcmF0aXZl L3B1YmxpYy5wcmkKaW5kZXggYmY0ZTFmNzAxYzM2NmQ1NjNjMWZmNmEwZTViMjU4ODY4M2YzNGU1 MC4uOTIxNmE4YjY0NTE1YWFjNGY3ZjczZWVhOWExYWI3ZTBhNDdhOTQwOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS9wdWJsaWMucHJpCisrKyBiL1NvdXJjZS9XZWJL aXQvcXQvZGVjbGFyYXRpdmUvcHVibGljLnByaQpAQCAtMjQsNyArMjQsNyBAQCBjb250YWlucyhR VF9DT05GSUcsIHJlZHVjZV9leHBvcnRzKTpDT05GSUcgKz0gaGlkZV9zeW1ib2xzCiAKIHdpbmNl KjpMSUJTICs9ICQkUU1BS0VfTElCU19HVUkKIAotUVQgKz0gd2Via2l0d2lkZ2V0cyB3ZWJraXR3 aWRnZXRzLXByaXZhdGUgd2lkZ2V0cyBxdWljayBxdWljay1wcml2YXRlCitRVCArPSB3ZWJraXR3 aWRnZXRzIHdlYmtpdHdpZGdldHMtcHJpdmF0ZSBxdWljayBxdWljay1wcml2YXRlCiAKIFdFQktJ VCArPSB3dGYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy5wcm8gYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzLnBybwppbmRleCA1ZWJhN2FjNDI4MGU3ZDdkNjVhYTY0 NDRiMTM1OGE5YWRkYjZjNjE3Li4yYmFlNmRkZDM4NGJkZjRiNGMyOTVlYjcxNDhhNDNhMDljNGE5 NzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzLnBybworKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzLnBybwpAQCAtMTEsMTMgKzExLDEwIEBAIERFU1RESVIgPSAk JHtST09UX0JVSUxEX0RJUn0vYmluCiAKIFNPVVJDRVMgKz0gcXQvTWFpblF0LmNwcAogCi1RVCAr PSBuZXR3b3JrIHdlYmtpdHdpZGdldHMgd2lkZ2V0cworUVQgKz0gbmV0d29yayB3ZWJraXR3aWRn ZXRzCiBtYWN4OiBRVCArPSB4bWwKIAotY29udGFpbnMoUVRfQ09ORklHLCBvcGVuZ2wpIHsKLSAg ICBRVCArPSBvcGVuZ2wKLSAgICBERUZJTkVTICs9IFFUX0NPTkZJR1VSRURfV0lUSF9PUEVOR0wK LX0KKyFpc0VtcHR5KFFULndpZGdldHMubmFtZSk6IFFUICs9IHdpZGdldHMKIAogSU5TVEFMTFMg Kz0gdGFyZ2V0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL3F0L01haW5RdC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9xdC9NYWluUXQuY3BwCmluZGV4IDNmMGRjZTIyZjViZTM3NDc3MDE2YjIx Y2M2N2MzNjRlZTYzY2M4YjkuLjU2YjMyODkwOGY3ZjJhZjhmMjZkZjhlNmQzMmQ2OWJmNDAzMDUw MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL3F0L01haW5RdC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvcXQvTWFpblF0LmNwcApAQCAtMjQsNyArMjQsMTUgQEAKICAqIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjaW5jbHVkZSA8cWdsb2JhbC5oPgorCisjaWYg ZGVmaW5lZChRVF9OT19XSURHRVRTKQorI2luY2x1ZGUgPFFHdWlBcHBsaWNhdGlvbj4KK3R5cGVk ZWYgUUd1aUFwcGxpY2F0aW9uIEFwcGxpY2F0aW9uVHlwZTsKKyNlbHNlCiAjaW5jbHVkZSA8UUFw cGxpY2F0aW9uPgordHlwZWRlZiBRQXBwbGljYXRpb24gQXBwbGljYXRpb25UeXBlOworI2VuZGlm CiAKICNpbmNsdWRlIDxzdGRpby5oPgogI2lmICFkZWZpbmVkKE5ERUJVRykgJiYgZGVmaW5lZChR X09TX1VOSVgpCkBAIC04NCw1ICs5Miw1IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJn dikKICAgICBpZiAoIXN1cHByZXNzT3V0cHV0LmlzRW1wdHkoKSAmJiBzdXBwcmVzc091dHB1dCAh PSAiMCIpCiAgICAgICAgIHFJbnN0YWxsTWVzc2FnZUhhbmRsZXIobWVzc2FnZUhhbmRsZXIpOwog Ci0gICAgcmV0dXJuIFdlYktpdDo6V2ViUHJvY2Vzc01haW5RdChuZXcgUUFwcGxpY2F0aW9uKGFy Z2MsIGFyZ3YpKTsKKyAgICByZXR1cm4gV2ViS2l0OjpXZWJQcm9jZXNzTWFpblF0KG5ldyBBcHBs aWNhdGlvblR5cGUoYXJnYywgYXJndikpOwogfQo=