99968 2012-10-22 01:57:13 -0700 Refactoring around ContainerNode::attachChildren 2012-10-22 17:55:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shinyak shinyak cmarcelo morrita webkit.review.bot oldest_to_newest 747317 0 shinyak 2012-10-22 01:57:13 -0700 After Bug 99750 is resolved, attachChildrenIfNeeded is replaced with attachChildren. We will be able to remove a few more methods and make code simple. 747388 1 169870 shinyak 2012-10-22 03:33:55 -0700 Created attachment 169870 Patch 748137 2 169870 webkit.review.bot 2012-10-22 17:55:29 -0700 Comment on attachment 169870 Patch Clearing flags on attachment: 169870 Committed r132168: <http://trac.webkit.org/changeset/132168> 748138 3 webkit.review.bot 2012-10-22 17:55:33 -0700 All reviewed patches have been landed. Closing bug. 169870 2012-10-22 03:33:55 -0700 2012-10-22 17:55:29 -0700 Patch bug-99968-20121022193234.patch text/plain 3185 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY2ZGI3NzBmOTg4ZDY1 N2VmZjZiN2Q3MjhlMzkzMGZlOTFhYTg1NS4uMWU4OWUxNTZjMjIxYmRkNDBkOGNiYTk1ZjRhNzcy NjA1OTIwZDdiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTIyICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZWZhY3Rvcmlu ZyBhcm91bmQgQ29udGFpbmVyTm9kZTo6YXR0YWNoQ2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5OTY4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgQ29udGFpbmVyTm9kZTo6YXR0YWNo KCkgaXMgbm93IGVxdWl2YWxlbnQgdG8gQ29udGFpbmVyTm9kZTo6YXR0YWNoQ2hpbGRyZW4oKSAr IE5vZGU6OmF0dGFjaCgpLCB3ZSBzaG91bGQgY2FsbAorICAgICAgICBDb250YWluZXJOb2RlOjph dHRhY2goKSBpbnN0ZWFkIG9mIGNhbGxpbmcgdGhlbS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGRvbS9Db250YWluZXJOb2RlLmg6 CisgICAgICAgIChDb250YWluZXJOb2RlKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjphdHRhY2gpOgorICAgICAgICAqIGRvbS9TaGFkb3dS b290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd1Jvb3Q6OmF0dGFjaCk6CisKIDIwMTIt MTAtMjIgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBb R1RLXSBFbmFibGUgTWljcm9kYXRhIERPTSBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Db250YWluZXJOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5o CmluZGV4IGRkNGE5ODk4ZDI5NDZlZjY2MjM5ZjhiNzVjZjI5ZGFhZDQxZjE2ZmUuLjY5YjVmNDIx YWNlY2ZjMjYxZmI0ZWE0YzRlZDkxMTZjYmEzMWE5OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5l ck5vZGUuaApAQCAtMTI0LDcgKzEyNCw2IEBAIHB1YmxpYzoKICAgICAvLyBub2RlIHRoYXQgaXMg b2YgdGhlIHR5cGUgQ0RBVEFfU0VDVElPTl9OT0RFLCBURVhUX05PREUgb3IgQ09NTUVOVF9OT0RF IGhhcyBjaGFuZ2VkIGl0cyB2YWx1ZS4KICAgICB2aXJ0dWFsIHZvaWQgY2hpbGRyZW5DaGFuZ2Vk KGJvb2wgY3JlYXRlZEJ5UGFyc2VyID0gZmFsc2UsIE5vZGUqIGJlZm9yZUNoYW5nZSA9IDAsIE5v ZGUqIGFmdGVyQ2hhbmdlID0gMCwgaW50IGNoaWxkQ291bnREZWx0YSA9IDApOwogCi0gICAgdm9p ZCBhdHRhY2hBc05vZGUoKTsKICAgICB2b2lkIGF0dGFjaENoaWxkcmVuKCk7CiAgICAgdm9pZCBh dHRhY2hDaGlsZHJlbkxhemlseSgpOwogICAgIHZvaWQgZGV0YWNoQ2hpbGRyZW4oKTsKQEAgLTIw MCwxMSArMTk5LDYgQEAgaW5saW5lIENvbnRhaW5lck5vZGU6OkNvbnRhaW5lck5vZGUoRG9jdW1l bnQqIGRvY3VtZW50LCBDb25zdHJ1Y3Rpb25UeXBlIHR5cGUpCiB7CiB9CiAKLWlubGluZSB2b2lk IENvbnRhaW5lck5vZGU6OmF0dGFjaEFzTm9kZSgpCi17Ci0gICAgTm9kZTo6YXR0YWNoKCk7Ci19 Ci0KIGlubGluZSB2b2lkIENvbnRhaW5lck5vZGU6OmF0dGFjaENoaWxkcmVuKCkKIHsKICAgICBm b3IgKE5vZGUqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4 dFNpYmxpbmcoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDk3ZGM5YzlmNjUwNjBkZWM3 NDJhNzZiMzA3NWEwNzg0YTBkYmE3ODMuLjA1YzIyZTJhMmI4MzE0NDY2YzA0NTFkZmEzMmI4MTkz ODllMDhkNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTEwMTYsMTMgKzEwMTYsMTEgQEAg dm9pZCBFbGVtZW50OjphdHRhY2goKQogICAgIGlmIChFbGVtZW50U2hhZG93KiBzaGFkb3cgPSB0 aGlzLT5zaGFkb3coKSkgewogICAgICAgICBwYXJlbnRQdXNoZXIucHVzaCgpOwogICAgICAgICBz aGFkb3ctPmF0dGFjaCgpOwotICAgICAgICBhdHRhY2hDaGlsZHJlbigpOwotICAgICAgICBhdHRh Y2hBc05vZGUoKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAoZmlyc3RDaGlsZCgpKQogICAg ICAgICAgICAgcGFyZW50UHVzaGVyLnB1c2goKTsKLSAgICAgICAgQ29udGFpbmVyTm9kZTo6YXR0 YWNoKCk7CiAgICAgfQorICAgIENvbnRhaW5lck5vZGU6OmF0dGFjaCgpOwogCiAgICAgaWYgKGhh c1JhcmVEYXRhKCkpIHsgICAKICAgICAgICAgRWxlbWVudFJhcmVEYXRhKiBkYXRhID0gZWxlbWVu dFJhcmVEYXRhKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2hhZG93Um9vdC5jcHAKaW5kZXggMGRhOWYyN2E5ZWNh MGM5ZWJmNGM0OWNkMDE1NDQxOGRlYmI2NTg1Yi4uMTJkNDYxMjkyYjU0ZTVkOGI0ZDAwNWNhNzc1 OGMzOWVhMTBhY2QyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmNwcApAQCAtMjE1LDggKzIx NSw3IEBAIHZvaWQgU2hhZG93Um9vdDo6YXR0YWNoKCkKIHsKICAgICBTdHlsZVJlc29sdmVyKiBz dHlsZVJlc29sdmVyID0gZG9jdW1lbnQoKS0+c3R5bGVSZXNvbHZlcigpOwogICAgIHN0eWxlUmVz b2x2ZXItPnB1c2hQYXJlbnRTaGFkb3dSb290KHRoaXMpOwotICAgIGF0dGFjaENoaWxkcmVuKCk7 Ci0gICAgYXR0YWNoQXNOb2RlKCk7CisgICAgRG9jdW1lbnRGcmFnbWVudDo6YXR0YWNoKCk7CiAg ICAgc3R5bGVSZXNvbHZlci0+cG9wUGFyZW50U2hhZG93Um9vdCh0aGlzKTsKIH0KIAo=