99954 2012-10-21 22:32:10 -0700 [V8] V8EnablePerContext shouldn't require document() accessor to the native object. 2014-12-16 00:48:24 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 100097 1 morrita morrita abarth haraken japhet tkent webkit.review.bot oldest_to_newest 747230 0 morrita 2012-10-21 22:32:10 -0700 This is demanded by Bug 99780. 747231 1 169830 morrita 2012-10-21 22:35:48 -0700 Created attachment 169830 Patch 747255 2 169830 haraken 2012-10-21 23:36:13 -0700 Comment on attachment 169830 Patch Looks OK 747260 3 169830 webkit.review.bot 2012-10-21 23:44:19 -0700 Comment on attachment 169830 Patch Clearing flags on attachment: 169830 Committed r132033: <http://trac.webkit.org/changeset/132033> 747261 4 webkit.review.bot 2012-10-21 23:44:23 -0700 All reviewed patches have been landed. Closing bug. 748420 5 webkit.review.bot 2012-10-23 02:43:12 -0700 Re-opened since this is blocked by bug 100097 748430 6 tkent 2012-10-23 02:50:03 -0700 (In reply to comment #3) > (From update of attachment 169830 [details]) > Clearing flags on attachment: 169830 > > Committed r132033: <http://trac.webkit.org/changeset/132033> I rolled it out because it broke DOMWindow::pagePopupController. void V8DOMWindow::installPerContextProperties(v8::Handle<v8::Object> instance, DOMWindow* impl) { v8::Local<v8::Object> proto = v8::Local<v8::Object>::Cast(instance->GetPrototype()); ScriptExecutionContext* context = toScriptExecutionContext(proto->CreationContext()); "context" was null. 1055946 7 burg 2014-12-16 00:48:24 -0800 Closing some V8-related work items. 169830 2012-10-21 22:35:48 -0700 2012-10-21 23:44:19 -0700 Patch bug-99954-20121022143427.patch text/plain 2512 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRlN2EwYWJjY2MwZjA4 YmFhYzExZmYxYTAxMDA3ZWNhZTkyMTAyZi4uZjdlYzg2MjQ3OWE0Y2FlMjJmMGNlMTE2ZjU4NWQz OGU2NjFlMTFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTIxICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIFtWOF0gVjhFbmFibGVQ ZXJDb250ZXh0IHNob3VsZG4ndCByZXF1aXJlIGRvY3VtZW50KCkgYWNjZXNzb3IgdG8gdGhlIG5h dGl2ZSBvYmplY3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05OTk1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEl0IG5vdyByZWZlcnMgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCBvZiB0aGUgY3JlYXRpb24g Y29udGV4dCBpbnN0ZWFkIG9mIGRvY3VtZW50KCkgb2YKKyAgICAgICAgd3JhcHBlZCBvYmplY3Qu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBiZWhhdmlvciBjaGFuZ2UgYXQgdGhpcyB0aW1l LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAg ICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKwogMjAxMi0xMC0yMSAgS2Vpc2hpIEhhdHRv cmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZWZhY3RvciBwaWNrZXIgdGVzdHMg dG8gZml4IGZsYWtpbmVzcyBhbmQgc2hhcmUgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBiM2YzMGM2YTBkZjE2ZjYw ZmEzZGU0ZGFlMWFlNWM2OWVmMmQzMTNkLi5hOTAzMDZjZDRjN2U3MTJmYTc0Njc4ZWNjZjhhYjdm OTU5NTQ0ZmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzA1Nyw4ICszMDU3LDkgQEAgRU5ECiB2b2lkICR7Y2xhc3NO YW1lfTo6aW5zdGFsbFBlckNvbnRleHRQcm9wZXJ0aWVzKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4g aW5zdGFuY2UsICR7bmF0aXZlVHlwZX0qIGltcGwpCiB7CiAgICAgdjg6OkxvY2FsPHY4OjpPYmpl Y3Q+IHByb3RvID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpDYXN0KGluc3RhbmNlLT5HZXRQcm90 b3R5cGUoKSk7CisgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCA9IHRvU2NyaXB0 RXhlY3V0aW9uQ29udGV4dChwcm90by0+Q3JlYXRpb25Db250ZXh0KCkpOwogICAgIC8vIFdoZW4g YnVpbGRpbmcgUXRXZWJraXQgd2l0aCBWOCB0aGlzIHZhcmlhYmxlIGlzIHVudXNlZCB3aGVuIG5v bmUgb2YgdGhlIGZlYXR1cmVzIGFyZSBlbmFibGVkLgotICAgIFVOVVNFRF9QQVJBTShwcm90byk7 CisgICAgVU5VU0VEX1BBUkFNKGNvbnRleHQpOwogRU5ECiAKICAgICAgICAgIyBTZXR1cCB0aGUg ZW5hYmxlLWJ5LXNldHRpbmdzIGF0dHJzIGlmIHdlIGhhdmUgdGhlbQpAQCAtMzA2Niw3ICszMDY3 LDcgQEAgRU5ECiAgICAgICAgICAgICBteSAkZW5hYmxlRnVuY3Rpb24gPSBHZXRDb250ZXh0RW5h YmxlRnVuY3Rpb24oJHJ1bnRpbWVBdHRyLT5zaWduYXR1cmUpOwogICAgICAgICAgICAgbXkgJGNv bmRpdGlvbmFsU3RyaW5nID0gJGNvZGVHZW5lcmF0b3ItPkdlbmVyYXRlQ29uZGl0aW9uYWxTdHJp bmcoJHJ1bnRpbWVBdHRyLT5zaWduYXR1cmUpOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRl bnQsICJcbiNpZiAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5n OwotICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKCR7ZW5hYmxlRnVuY3Rp b259KGltcGwtPmRvY3VtZW50KCkpKSB7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250 ZW50LCAiICAgIGlmIChjb250ZXh0ICYmIGNvbnRleHQtPmlzRG9jdW1lbnQoKSAmJiAke2VuYWJs ZUZ1bmN0aW9ufShzdGF0aWNfY2FzdDxEb2N1bWVudCo+KGNvbnRleHQpKSkge1xuIik7CiAgICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICAgICAgc3RhdGljIGNvbnN0IFY4RE9NQ29u ZmlndXJhdGlvbjo6QmF0Y2hlZEF0dHJpYnV0ZSBhdHRyRGF0YSA9XFxcbiIpOwogICAgICAgICAg ICAgR2VuZXJhdGVTaW5nbGVCYXRjaGVkQXR0cmlidXRlKCRpbnRlcmZhY2VOYW1lLCAkcnVudGlt ZUF0dHIsICI7IiwgIiAgICAiKTsKICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVO RCk7Cg==