99950 2012-10-21 19:54:21 -0700 [BlackBerry] Missing some cookies in HTTP response header when set several cookies in one "Set-Cookie" header. 2012-10-22 21:33:22 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 PeterHWang webkit-unassigned charles.wei joenotcharles kpiascik mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 747200 0 169823 PeterHWang 2012-10-21 19:54:21 -0700 Created attachment 169823 test case Visit the attached test case, from Inspector we can see we've missed several cookies in response. I've checked this problem. The code of Inspector is ok, we really missed them when we made response headers. 747201 1 webkit.review.bot 2012-10-21 19:56:52 -0700 Attachment 169823 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 747208 2 169825 PeterHWang 2012-10-21 20:48:24 -0700 Created attachment 169825 Patch 747246 3 169825 charles.wei 2012-10-21 23:27:00 -0700 Comment on attachment 169825 Patch This looks good to me. 747248 4 169825 staikos 2012-10-21 23:28:55 -0700 Comment on attachment 169825 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169825&action=review Please make the comment clearer first. > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:338 > + // If there are several "Set-Cookie" headers, we should combine the followed with headed. "following ones with this header" is what is meant here? 747325 5 PeterHWang 2012-10-22 02:10:28 -0700 (In reply to comment #4) > (From update of attachment 169825 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169825&action=review > > Please make the comment clearer first. > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:338 > > + // If there are several "Set-Cookie" headers, we should combine the followed with headed. > > "following ones with this header" is what is meant here? ok. sorry. 747334 6 169857 PeterHWang 2012-10-22 02:21:26 -0700 Created attachment 169857 Patch 748249 7 169857 staikos 2012-10-22 21:28:25 -0700 Comment on attachment 169857 Patch I would have liked to see a test with this. Not sure how though. 748252 8 169857 webkit.review.bot 2012-10-22 21:33:18 -0700 Comment on attachment 169857 Patch Clearing flags on attachment: 169857 Committed r132177: <http://trac.webkit.org/changeset/132177> 748253 9 webkit.review.bot 2012-10-22 21:33:22 -0700 All reviewed patches have been landed. Closing bug. 169823 2012-10-21 19:54:21 -0700 2012-10-21 19:59:40 -0700 test case inspector_cookie.zip application/zip 705 PeterHWang UEsDBBQAAgAIAIFwR0DBBOvpugAAAFkBAAASAAAAc2V0Rm91ckNvb2tpZXMucGhwhZBBC4IwHMXv gt9heNEoNisoNNFDKB0iwYqOYTqYpG24v4e+fa5Zhwg8vcfb770/LIgEE6ZhGpJCwfm9oo6lNT3E 1gxZWqBqqDOZLleuO9n8gU+XVMFaRuFdFr+3P2askKTnTPGD/uCmwWhe0tax97zIoeIPHzEA4RMy d7Hn4oWH1x7RU5IAlUD6Ewnv2q3Ori2VXQ0S939hq8koNI2AQVOHar73N14+VSZCdKSAdA8FRKiQ DK/KfksvUEsDBBQAAgAIAFVyR0Ber4E5uQAAADABAAAaAAAAc2V0Rm91ckNvb2tpZXNfcmVzdWx0 cy5waHBVUEEKwjAQvBf6h6XkoKfeNYmIRBTBQFE8SptGKo0ktKnY35tti1hymGFmszsMrfzL8DjC Rwtb9oFTx2nBQXycVl6X0Oi2M75d0bQIRpOGEWVt/dTyLIAxCDCTLzeJcoC5fMjEMD+QmbWX1wwd xMmgqftF2Srf5QayvxxAN65ymJqMKxi576Q8HcU6jh620bmqYDF5kLdAat0zTt65WcaRVpWFJFzi KONlNJLwdcPHw0Mf6VQI0qmnL1BLAQIUABQAAgAIAIFwR0DBBOvpugAAAFkBAAASACQAAAAAAAEA IAAAAAAAAABzZXRGb3VyQ29va2llcy5waHAKACAAAAAAAAEAGACgbGpAy+XMAaBsakDL5cwB0H1r HsnlzAFQSwECFAAUAAIACABVckdAXq+BObkAAAAwAQAAGgAkAAAAAAABACAAAADqAAAAc2V0Rm91 ckNvb2tpZXNfcmVzdWx0cy5waHAKACAAAAAAAAEAGABwMfRMzeXMAXAx9EzN5cwBkE1FP8vlzAFQ SwUGAAAAAAIAAgDQAAAA2wEAAAAA 169825 2012-10-21 20:48:24 -0700 2012-10-22 02:21:20 -0700 Patch bug-99950-20121022114654.patch text/plain 2589 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTczNmIyMGYxNmIwMjFk MzI2MTE1NTUzMDUxZDhmNjYyZGZkZGZjYi4uN2QzMmY5NmFjMmM3ODhmYzA5YTdjYTA2YjU3ODgx NDRkYzlmMDA2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTIxICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNr QmVycnldIE1pc3Npbmcgc29tZSBjb29raWVzIGluIEhUVFAgcmVzcG9uc2UgaGVhZGVyIHdoZW4g c2V0IHNldmVyYWwgY29va2llcyBpbiBvbmUgIlNldC1Db29raWUiIGhlYWRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5OTUwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlcmUgYXJlIHNldmVy YWwgIlNldC1Db29raWUiIGhlYWRlcnMsIHdlIHNob3VsZCBjb21iaW5lIHRoZSBmb2xsb3dlZCB3 aXRoIGhlYWRlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKToKKwogMjAxMi0x MC0yMSAgSHl1bmdjaGFuIEtpbSAgPGh5dW5nY2hhbjIua2ltQGxnZS5jb20+CiAKICAgICAgICAg QWRkIGEgc2VwYXJhdGUgZmxhZyBmb3IgcmdiIHN3aXp6bGluZyB3aGV0aGVyIGl0IGNhbiBiZSBt b2RpZmllZCBvciBub3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCA3MjBiYTEzMzkwNjBkMzM5MmU1 MzI1OTNjOTc5Y2RkNDRjN2Q4YTY5Li5hNzdlYzdkOGU5NTU3MjliM2UwYjg2MDBjZWY5ODZkZDZl MmNkNmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0zMzMsMTIgKzMzMywxMyBAQCB2b2lkIE5l dHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKGNvbnN0IFN0cmluZyYga2V5LCBj b25zdCBTdHJpbmcmIHZhbAogICAgICAgICAvLyBGb3Igbm93IHdlIGNoZWNrIGZvciB0aGlzIGV4 cGxpY2l0bHkgYnkgY2hlY2tpbmcgbV9mcmFtZS0+cGFnZSgpLiBCdXQgd2Ugc2hvdWxkIGZpbmQg b3V0IHdoeSB0aGUgbmV0d29yayBqb2IgaGFzbid0IGJlZW4gY2FuY2VsbGVkIHdoZW4gdGhlIGZy YW1lIHdhcyBkZXRhY2hlZC4KICAgICAgICAgLy8gU2VlIFJJTSBQUiAxMzQyMDcKICAgICAgICAg aWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFnZSgpICYmIG1fZnJhbWUtPmxvYWRlcigpICYmIG1f ZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKQotICAgICAgICAgICAgJiYgc3RhdGljX2Nhc3Q8RnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4obV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgpKS0+ Y29va2llc0VuYWJsZWQoKSkKKyAgICAgICAgICAgICYmIHN0YXRpY19jYXN0PEZyYW1lTG9hZGVy Q2xpZW50QmxhY2tCZXJyeSo+KG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPmNvb2tpZXNF bmFibGVkKCkpIHsKICAgICAgICAgICAgIGhhbmRsZVNldENvb2tpZUhlYWRlcih2YWx1ZSk7Ci0K LSAgICAgICAgaWYgKG1fcmVzcG9uc2UuaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJTZXQt Q29va2llIikpIHsKLSAgICAgICAgICAgIG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtl eSwgbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoa2V5KSArICJcclxuIiArIHZhbHVlKTsKLSAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIC8vIElmIHRoZXJlIGFyZSBzZXZlcmFsICJT ZXQtQ29va2llIiBoZWFkZXJzLCB3ZSBzaG91bGQgY29tYmluZSB0aGUgZm9sbG93ZWQgd2l0aCBo ZWFkZWQuCisgICAgICAgICAgICBpZiAobV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGRzKCkuY29u dGFpbnMoIlNldC1Db29raWUiKSkgeworICAgICAgICAgICAgICAgIG1fcmVzcG9uc2Uuc2V0SFRU UEhlYWRlckZpZWxkKGtleSwgbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoa2V5KSArICIsICIg KyB2YWx1ZSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQogICAgICAg ICB9CiAgICAgfSBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShrZXksIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpOZXR3b3JrUmVxdWVzdDo6SEVBREVSX0JMQUNLQkVSUllfRlRQKSkKICAgICAgICAg aGFuZGxlRlRQSGVhZGVyKHZhbHVlKTsK 169857 2012-10-22 02:21:26 -0700 2012-10-22 21:33:18 -0700 Patch bug-99950-20121022171956.patch text/plain 2658 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTczNmIyMGYxNmIwMjFk MzI2MTE1NTUzMDUxZDhmNjYyZGZkZGZjYi4uOTg1NTFkN2ExM2UxYTNlZWVjZDBlNTllMGQ1MGJm Y2I2MTY3ZTg5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTIxICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNr QmVycnldIE1pc3Npbmcgc29tZSBjb29raWVzIGluIEhUVFAgcmVzcG9uc2UgaGVhZGVyIHdoZW4g c2V0IHNldmVyYWwgY29va2llcyBpbiBvbmUgIlNldC1Db29raWUiIGhlYWRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5OTUwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gIk5ldHdvcmtKb2I6Omhh bmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkIiwgaWYgdGhlcmUgYXJlIHNldmVyYWwgIlNldC1Db29r aWUiIGhlYWRlcnMsIAorICAgICAgICB3ZSBzaG91bGQgY29tYmluZSB0aGUgZm9sbG93aW5nIG9u ZXMgd2l0aCB0aGUgZmlyc3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3QgY2FzZS4KKworICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKToKKwogMjAx Mi0xMC0yMSAgSHl1bmdjaGFuIEtpbSAgPGh5dW5nY2hhbjIua2ltQGxnZS5jb20+CiAKICAgICAg ICAgQWRkIGEgc2VwYXJhdGUgZmxhZyBmb3IgcmdiIHN3aXp6bGluZyB3aGV0aGVyIGl0IGNhbiBi ZSBtb2RpZmllZCBvciBub3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCA3MjBiYTEzMzkwNjBkMzM5 MmU1MzI1OTNjOTc5Y2RkNDRjN2Q4YTY5Li4wNzlmZTUxYWU1ZjI2YjQ0MjY4OGViYTk3MmM4MzQx NzY1YjZmN2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Js YWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0zMzMsMTIgKzMzMywxMyBAQCB2b2lk IE5ldHdvcmtKb2I6OmhhbmRsZU5vdGlmeUhlYWRlclJlY2VpdmVkKGNvbnN0IFN0cmluZyYga2V5 LCBjb25zdCBTdHJpbmcmIHZhbAogICAgICAgICAvLyBGb3Igbm93IHdlIGNoZWNrIGZvciB0aGlz IGV4cGxpY2l0bHkgYnkgY2hlY2tpbmcgbV9mcmFtZS0+cGFnZSgpLiBCdXQgd2Ugc2hvdWxkIGZp bmQgb3V0IHdoeSB0aGUgbmV0d29yayBqb2IgaGFzbid0IGJlZW4gY2FuY2VsbGVkIHdoZW4gdGhl IGZyYW1lIHdhcyBkZXRhY2hlZC4KICAgICAgICAgLy8gU2VlIFJJTSBQUiAxMzQyMDcKICAgICAg ICAgaWYgKG1fZnJhbWUgJiYgbV9mcmFtZS0+cGFnZSgpICYmIG1fZnJhbWUtPmxvYWRlcigpICYm IG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKQotICAgICAgICAgICAgJiYgc3RhdGljX2Nhc3Q8 RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Kj4obV9mcmFtZS0+bG9hZGVyKCktPmNsaWVudCgp KS0+Y29va2llc0VuYWJsZWQoKSkKKyAgICAgICAgICAgICYmIHN0YXRpY19jYXN0PEZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeSo+KG1fZnJhbWUtPmxvYWRlcigpLT5jbGllbnQoKSktPmNvb2tp ZXNFbmFibGVkKCkpIHsKICAgICAgICAgICAgIGhhbmRsZVNldENvb2tpZUhlYWRlcih2YWx1ZSk7 Ci0KLSAgICAgICAgaWYgKG1fcmVzcG9uc2UuaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJT ZXQtQ29va2llIikpIHsKLSAgICAgICAgICAgIG1fcmVzcG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxk KGtleSwgbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQoa2V5KSArICJcclxuIiArIHZhbHVlKTsK LSAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIC8vIElmIHRoZXJlIGFyZSBzZXZlcmFs ICJTZXQtQ29va2llIiBoZWFkZXJzLCB3ZSBzaG91bGQgY29tYmluZSB0aGUgZm9sbG93aW5nIG9u ZXMgd2l0aCB0aGUgZmlyc3QuCisgICAgICAgICAgICBpZiAobV9yZXNwb25zZS5odHRwSGVhZGVy RmllbGRzKCkuY29udGFpbnMoIlNldC1Db29raWUiKSkgeworICAgICAgICAgICAgICAgIG1fcmVz cG9uc2Uuc2V0SFRUUEhlYWRlckZpZWxkKGtleSwgbV9yZXNwb25zZS5odHRwSGVhZGVyRmllbGQo a2V5KSArICIsICIgKyB2YWx1ZSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgfQogICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShrZXksIEJs YWNrQmVycnk6OlBsYXRmb3JtOjpOZXR3b3JrUmVxdWVzdDo6SEVBREVSX0JMQUNLQkVSUllfRlRQ KSkKICAgICAgICAgaGFuZGxlRlRQSGVhZGVyKHZhbHVlKTsK