99918 2012-10-20 17:38:24 -0700 [mac] Text with zero font size renders as 12px sometimes 2012-10-25 03:43:23 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 100115 1 mitz mitz dglazkov ggaren ossy webkit.review.bot oldest_to_newest 747012 0 mitz 2012-10-20 17:38:24 -0700 [mac] Text with zero font size renders as 12px sometimes 747013 1 mitz 2012-10-20 17:38:55 -0700 <rdar://problem/12512710> 747015 2 169778 mitz 2012-10-20 17:45:31 -0700 Created attachment 169778 Make Font::drawGlyphs() bail out if the font size is 0 747021 3 169778 ggaren 2012-10-20 18:48:47 -0700 Comment on attachment 169778 Make Font::drawGlyphs() bail out if the font size is 0 View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review r=me > LayoutTests/fast/text/zero-font-size-2.html:4 > + l o r e m i s u m d o l o r I believe you are missing a 'p'. 747025 4 169778 webkit.review.bot 2012-10-20 18:52:40 -0700 Comment on attachment 169778 Make Font::drawGlyphs() bail out if the font size is 0 Attachment 169778 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14462993 New failing tests: fast/text/zero-font-size-2.html 747026 5 mitz 2012-10-20 18:52:54 -0700 (In reply to comment #3) > (From update of attachment 169778 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review > > r=me > > > LayoutTests/fast/text/zero-font-size-2.html:4 > > + l o r e m i s u m d o l o r > > I believe you are missing a 'p'. The Ahem lowercase p is a thin rectangle below the baseline, and I wanted the failure case to show a simple red rectangle, so I dropped it. Thanks for the review! 747027 6 mitz 2012-10-20 18:55:18 -0700 (In reply to comment #4) > (From update of attachment 169778 [details]) > Attachment 169778 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/14462993 > > New failing tests: > fast/text/zero-font-size-2.html I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like. 747028 7 mitz 2012-10-20 18:57:58 -0700 Fixed in <http://trac.webkit.org/r131995>. 747031 8 mitz 2012-10-20 19:46:36 -0700 (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 169778 [details] [details]) > > Attachment 169778 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/14462993 > > > > New failing tests: > > fast/text/zero-font-size-2.html > > I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like. Indeed, the results at <http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r131995%20(40063)/fast/text/zero-font-size-2-diffs.html> confirm this. I’ve filed bug 99920. 750624 9 ossy 2012-10-25 03:43:14 -0700 I filed a new bug report to fix this fail on Qt too - https://bugs.webkit.org/show_bug.cgi?id=100115 169778 2012-10-20 17:45:31 -0700 2012-10-25 03:43:23 -0700 Make Font::drawGlyphs() bail out if the font size is 0 bug-99918-20121020174428.patch text/plain 3179 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTk5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTIwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNTEy NzEwPiBbbWFjXSBUZXh0IHdpdGggemVybyBmb250IHNpemUgcmVuZGVycyBhcyAxMnB4IHNvbWV0 aW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk5 MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtW05T Rm9udCBmb250V2l0aE5hbWU6c2l6ZTpdIHJldHVybnMgYW4gTlNGb250IG9mIHNpemUgMTIgKHRo ZSBkZWZhdWx0IFVzZXIgRm9udCBzaXplKSB3aGVuCisgICAgICAgIGFza2VkIGZvciBzaXplIDAs IGFuZCB0aGlzIGlzIHdoYXQgRm9udDo6ZHJhd0dseXBocyB1c2VzIHRvIGRyYXcgdGhlIHRleHQu CisKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L3plcm8tZm9udC1zaXplLTIuaHRtbAorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0ZvbnRNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpGb250OjpkcmF3R2x5cGhzKTogQWRkZWQgYW4gZWFybHkgcmV0dXJuIGlmIHRoZSBzaXplIGlz IHplcm8uCisKIDIwMTItMTAtMjAgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgog CiAgICAgICAgIENsZWFuIHVwIFF1YWxpZmllZE5hbWUtYXMtaGFzaC1rZXkgc2NlbmFyaW8uCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udE1hYy5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udE1hYy5t bQkocmV2aXNpb24gMTMxOTg4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv bWFjL0ZvbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEzOSw2ICsxMzksOSBAQCBzdGF0aWMg dm9pZCBzaG93R2x5cGhzV2l0aEFkdmFuY2VzKGNvbnN0CiAKIHZvaWQgRm9udDo6ZHJhd0dseXBo cyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IFNpbXBsZUZvbnREYXRhKiBmb250LCBj b25zdCBHbHlwaEJ1ZmZlciYgZ2x5cGhCdWZmZXIsIGludCBmcm9tLCBpbnQgbnVtR2x5cGhzLCBj b25zdCBGbG9hdFBvaW50JiBwb2ludCkgY29uc3QKIHsKKyAgICBpZiAoIWZvbnQtPnBsYXRmb3Jt RGF0YSgpLnNpemUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgQ0dDb250ZXh0UmVmIGNnQ29u dGV4dCA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpOwogCiAgICAgYm9vbCBzaG91bGRTbW9v dGhGb250cyA9IHRydWU7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzE5OTMpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMC0yMCAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xMjUxMjcxMD4gW21hY10gVGV4dCB3aXRoIHplcm8gZm9udCBzaXplIHJlbmRlcnMgYXMgMTJw eCBzb21ldGltZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk5OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBmYXN0L3RleHQvemVyby1mb250LXNpemUtMi1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L3RleHQvemVyby1mb250LXNpemUtMi5odG1sOiBBZGRlZC4KKwogMjAxMi0x MC0yMCAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVs LmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgbWlzc2luZyBleHBlY3RhdGlvbnMgZm9yIHNvbWUg dGVzdHMgaW4gc3ZnL2N1c3RvbS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC96ZXJvLWZv bnQtc2l6ZS0yLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L3plcm8tZm9udC1zaXplLTItZXhwZWN0ZWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvdGV4dC96ZXJvLWZvbnQtc2l6ZS0yLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMiBAQAorPGRpdiBzdHlsZT0icGFkZGluZy1sZWZ0OiAxMnB4OyBwYWRk aW5nLXRvcDogMjBweDsgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47IGhlaWdodDogMTJweDsiPgor PC9kaXY+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvemVyby1mb250LXNpemUtMi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC96ZXJvLWZvbnQtc2l6ZS0yLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvemVyby1mb250LXNpemUt Mi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKKzxkaXYgc3R5bGU9InBhZGRpbmct bGVmdDogMTJweDsgcGFkZGluZy10b3A6IDIwcHg7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyBo ZWlnaHQ6IDEycHg7Ij4KKyAgICA8c3BhbiBzdHlsZT0icGFkZGluZy10b3A6IDFweDsgZm9udC1m YW1pbHk6IGFoZW07IGZvbnQtc2l6ZTogMDsgd29yZC1zcGFjaW5nOiAxMnB4OyBjb2xvcjogcmVk OworICAgICAgICAtd2Via2l0LWZvbnQtc21vb3RoaW5nOiBub25lOyI+CisgICAgICAgIGwgbyBy IGUgbSBpIHMgdSBtIGQgbyBsIG8gcgorICAgIDwvc3Bhbj4KKzwvZGl2Pgo=