99916 2012-10-20 13:27:22 -0700 [BlackBerry] m_mainFrame should be null checked before use in WebPagePrivate destructor 2012-10-20 15:45:03 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo anilsson mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 746989 0 anlo 2012-10-20 13:27:22 -0700 When WebPagePrivate is being destroyed, m_mainFrame could be a null pointer. 746990 1 169772 anlo 2012-10-20 13:37:12 -0700 Created attachment 169772 Patch 746991 2 169772 staikos 2012-10-20 13:40:05 -0700 Comment on attachment 169772 Patch Merge error - clearly flags. 746992 3 169773 anlo 2012-10-20 13:51:15 -0700 Created attachment 169773 Patch 747004 4 169773 webkit.review.bot 2012-10-20 15:45:00 -0700 Comment on attachment 169773 Patch Clearing flags on attachment: 169773 Committed r131992: <http://trac.webkit.org/changeset/131992> 747005 5 webkit.review.bot 2012-10-20 15:45:03 -0700 All reviewed patches have been landed. Closing bug. 169772 2012-10-20 13:37:12 -0700 2012-10-20 13:51:10 -0700 Patch bug-99916-20121020164120.patch text/plain 2530 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhMzk0MGVjZDJmZWRlZTExOTcxODU1ODA2OWQyMDUyNjFiNDE4NjRkLi43ZGIxZTA1YTVl ZjdkNzA4MDZhMmNiODk5MWUxNDZlMTNmYzRmNWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMCAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBtX21haW5GcmFtZSBzaG91bGQgYmUgbnVsbCBj aGVja2VkIGJlZm9yZSB1c2UgaW4gV2ViUGFnZVByaXZhdGUgZGVzdHJ1Y3RvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk5MTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBi eSBBcnZpZCBOaWxzc29uLgorCisgICAgICAgIEludGVybmFsIFBSMjI4MDI5CisgICAgICAgIEFk ZCBudWxsIGNoZWNrcyBmb3IgbV9tYWluRnJhbWUgZm9yIHRoaW5ncyB0aGF0IGhhcHBlbiBkdXJp bmcKKyAgICAgICAgV2ViUGFnZSBkZXN0cnVjdGlvbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnNldFZp c2libGUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0 Q29tcG9zaXRvckRyYXdzUm9vdExheWVyKToKKwogMjAxMi0xMC0xOSAgQW5kcmV3IExvICA8YW5s b0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQgc3VzcGVuZCBBbmltYXRp b25Db250cm9sbGVyIHdoZW4gV2ViUGFnZSBiZWNvbWVzIGludmlzaWJsZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDg4MDhmM2Y3N2NjNmI4ZTg5OTM5ZDBk M2MzMDI4MzkzNWZhNGFhNWQuLjEwOGQ4OTdlMWJhMDI3ODM4OGFhNDI1NzlhMGZmODUwZjIyOGUz ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMzIxNiwx MSArMzIxNiwxMyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRWaXNpYmxlKGJvb2wgdmlzaWJs ZSkKIHsKICAgICBpZiAodmlzaWJsZSAhPSBtX3Zpc2libGUpIHsKICAgICAgICAgaWYgKHZpc2li bGUpIHsKLSAgICAgICAgICAgIG1haW5GcmFtZSgpLT5hbmltYXRpb24oKS0+cmVzdW1lQW5pbWF0 aW9ucygpOworICAgICAgICAgICAgaWYgKG1fbWFpbkZyYW1lKQorICAgICAgICAgICAgICAgIG1f bWFpbkZyYW1lLT5hbmltYXRpb24oKS0+cmVzdW1lQW5pbWF0aW9ucygpOwogICAgICAgICAgICAg aWYgKG1fcGFnZS0+c2NyaXB0ZWRBbmltYXRpb25zU3VzcGVuZGVkKCkpCiAgICAgICAgICAgICAg ICAgbV9wYWdlLT5yZXN1bWVTY3JpcHRlZEFuaW1hdGlvbnMoKTsKICAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgIG1haW5GcmFtZSgpLT5hbmltYXRpb24oKS0+c3VzcGVuZEFuaW1hdGlvbnMo KTsKKyAgICAgICAgICAgIGlmIChtX21haW5GcmFtZSkKKyAgICAgICAgICAgICAgICBtX21haW5G cmFtZS0+YW5pbWF0aW9uKCktPnN1c3BlbmRBbmltYXRpb25zKCk7CiAgICAgICAgICAgICBpZiAo IW1fcGFnZS0+c2NyaXB0ZWRBbmltYXRpb25zU3VzcGVuZGVkKCkpCiAgICAgICAgICAgICAgICAg bV9wYWdlLT5zdXNwZW5kU2NyaXB0ZWRBbmltYXRpb25zKCk7CiAgICAgICAgIH0KQEAgLTU0OTAs NiArNTQ5Miw4IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldENvbXBvc2l0b3JEcmF3c1Jvb3RM YXllcihib29sIGNvbXBvc2l0b3JEcmF3c1Jvb3RMYXllcikKICAgICAvLyBXaGVuIHRoZSBCbGFj a0JlcnJ5IHBvcnQgZm9yY2VzIGNvbXBvc2l0aW5nIG1vZGUsIHRoZSByb290IGxheWVyIHN0b3Bz CiAgICAgLy8gcGFpbnRpbmcgdG8gd2luZG93IGFuZCBzdGFydHMgcGFpbnRpbmcgdG8gbGF5ZXIg aW5zdGVhZC4KICAgICBtX3BhZ2UtPnNldHRpbmdzKCktPnNldEZvcmNlQ29tcG9zaXRpbmdNb2Rl KGNvbXBvc2l0b3JEcmF3c1Jvb3RMYXllcik7CisgICAgaWYgKCFtX21haW5GcmFtZSkKKyAgICAg ICAgcmV0dXJuOwogICAgIC8vIEZJWE1FOiByZWJhc2UuIENvbnNpZGVyIHVzaW5nIHVwZGF0ZUNv bXBvc2l0aW5nTGF5ZXJzQWZ0ZXJTdHlsZUNoYW5nZSgpOwogICAgIGlmIChGcmFtZVZpZXcqIHZp ZXcgPSBtX21haW5GcmFtZS0+dmlldygpKQogICAgICAgICB2aWV3LT51cGRhdGVDb21wb3NpdGlu Z0xheWVyc0FmdGVyTGF5b3V0KCk7Cg== 169773 2012-10-20 13:51:15 -0700 2012-10-20 15:45:00 -0700 Patch bug-99916-20121020165523.patch text/plain 2421 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzZjg1YTZhMmMwOWYxZDg0NGYyYWNhOTE5NjU4NTI0OGI0YWJhM2NhLi5mYmY0ZDAwNGU5 ZjE0MjM2MTcwODUxOWYwNGMwZDA1N2M3NzEyOGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0yMCAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBtX21haW5GcmFtZSBzaG91bGQgYmUgbnVsbCBj aGVja2VkIGJlZm9yZSB1c2UgaW4gV2ViUGFnZVByaXZhdGUgZGVzdHJ1Y3RvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk5MTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBi eSBBcnZpZCBOaWxzc29uLgorCisgICAgICAgIEludGVybmFsIFBSMjI4MDI5CisgICAgICAgIEFk ZCBudWxsIGNoZWNrcyBmb3IgbV9tYWluRnJhbWUgZm9yIHRoaW5ncyB0aGF0IGhhcHBlbiBkdXJp bmcKKyAgICAgICAgV2ViUGFnZSBkZXN0cnVjdGlvbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnNldFZp c2libGUpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0 Q29tcG9zaXRvckRyYXdzUm9vdExheWVyKToKKwogMjAxMi0xMC0xOSAgTWlrZSBGZW50b24gIDxt aWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBDb252ZXJ0IGlucHV0IHN0 eWxlIHRvIGludDY0X3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmlu ZGV4IGExODUyNTZmODM3N2JiZDdhZWRjNTgxODQyN2U4NzQxOGEzY2U5ZmEuLmQyYjdmNzg5ODg1 MWYyZTdlYmYzMmNjYjI3ODViMGE3OTk2NDJhZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcApAQCAtMzIwMiwxMSArMzIwMiwxMyBAQCB2b2lkIFdlYlBhZ2VQcml2 YXRlOjpzZXRWaXNpYmxlKGJvb2wgdmlzaWJsZSkKIHsKICAgICBpZiAodmlzaWJsZSAhPSBtX3Zp c2libGUpIHsKICAgICAgICAgaWYgKHZpc2libGUpIHsKLSAgICAgICAgICAgIG1haW5GcmFtZSgp LT5hbmltYXRpb24oKS0+cmVzdW1lQW5pbWF0aW9ucygpOworICAgICAgICAgICAgaWYgKG1fbWFp bkZyYW1lKQorICAgICAgICAgICAgICAgIG1fbWFpbkZyYW1lLT5hbmltYXRpb24oKS0+cmVzdW1l QW5pbWF0aW9ucygpOwogICAgICAgICAgICAgaWYgKG1fcGFnZS0+c2NyaXB0ZWRBbmltYXRpb25z U3VzcGVuZGVkKCkpCiAgICAgICAgICAgICAgICAgbV9wYWdlLT5yZXN1bWVTY3JpcHRlZEFuaW1h dGlvbnMoKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIG1haW5GcmFtZSgpLT5hbmlt YXRpb24oKS0+c3VzcGVuZEFuaW1hdGlvbnMoKTsKKyAgICAgICAgICAgIGlmIChtX21haW5GcmFt ZSkKKyAgICAgICAgICAgICAgICBtX21haW5GcmFtZS0+YW5pbWF0aW9uKCktPnN1c3BlbmRBbmlt YXRpb25zKCk7CiAgICAgICAgICAgICBpZiAoIW1fcGFnZS0+c2NyaXB0ZWRBbmltYXRpb25zU3Vz cGVuZGVkKCkpCiAgICAgICAgICAgICAgICAgbV9wYWdlLT5zdXNwZW5kU2NyaXB0ZWRBbmltYXRp b25zKCk7CiAgICAgICAgIH0KQEAgLTU0NjAsNiArNTQ2MiwxMCBAQCB2b2lkIFdlYlBhZ2VQcml2 YXRlOjpzZXRDb21wb3NpdG9yRHJhd3NSb290TGF5ZXIoYm9vbCBjb21wb3NpdG9yRHJhd3NSb290 TGF5ZXIpCiAgICAgLy8gV2hlbiB0aGUgQmxhY2tCZXJyeSBwb3J0IGZvcmNlcyBjb21wb3NpdGlu ZyBtb2RlLCB0aGUgcm9vdCBsYXllciBzdG9wcwogICAgIC8vIHBhaW50aW5nIHRvIHdpbmRvdyBh bmQgc3RhcnRzIHBhaW50aW5nIHRvIGxheWVyIGluc3RlYWQuCiAgICAgbV9wYWdlLT5zZXR0aW5n cygpLT5zZXRGb3JjZUNvbXBvc2l0aW5nTW9kZShjb21wb3NpdG9yRHJhd3NSb290TGF5ZXIpOwor CisgICAgaWYgKCFtX21haW5GcmFtZSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKEZyYW1l VmlldyogdmlldyA9IG1fbWFpbkZyYW1lLT52aWV3KCkpCiAgICAgICAgIHZpZXctPnVwZGF0ZUNv bXBvc2l0aW5nTGF5ZXJzKCk7CiAjZW5kaWYK