99908 2012-10-19 23:58:28 -0700 [CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded. 2012-10-23 14:48:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74651 98990 0 dongseong.hwang webkit-unassigned achicu eric noam simon.fraser webkit.review.bot oldest_to_newest 746930 0 dongseong.hwang 2012-10-19 23:58:28 -0700 CSS Shaders can not render anything until the program is loaded. If there is partial loaded shaders program, whole FilterOperations chain can not render anything. It occurs a flash. So We have to wait until the program is loaded, to prevent a flash as RenderLayerBacking::updateImageContents() waits until an image is fully loaded. 746931 1 169759 dongseong.hwang 2012-10-20 00:11:27 -0700 Created attachment 169759 Patch 746976 2 169759 noam 2012-10-20 09:12:38 -0700 Comment on attachment 169759 Patch This seems like a platform specific behavior - when we set the filters on a particular GraphicsLayer (e.g. CoordinatedGraphicsLayer) we can subscribe to the program as a client and reset the filters when the program is loaded. 747033 3 dongseong.hwang 2012-10-20 20:05:22 -0700 (In reply to comment #2) > (From update of attachment 169759 [details]) > This seems like a platform specific behavior - when we set the filters on a particular GraphicsLayer (e.g. CoordinatedGraphicsLayer) we can subscribe to the program as a client and reset the filters when the program is loaded. Thanks for good opinion. We already subscribe to the program when the program is loaded, because WebCore recalculates the style when the program is loaded. I think both approaches can be right. Each GraphicsLayer easily resets the filters, but I prefer this patch because of two reasons. 1. Each platform needs to have similar code to handle unloaded programs. 2. As I mentioned in Changelog, RenderLayerBacking::updateImageContents() already waits calling GraphicsLayer::setContentsToImage() until an image is fully loaded. I want RenderLayerBacking to handle CachedProgram similar to CachedImage. I think same policy increases code readability. I'm looking forward your feedback :) 748997 4 169759 dino 2012-10-23 14:36:47 -0700 Comment on attachment 169759 Patch I'm not sure this is the right thing to do, but I'll r+ so that we can live on it for a while. Sometimes I think a flash is better than nothing. 749008 5 169759 webkit.review.bot 2012-10-23 14:45:59 -0700 Comment on attachment 169759 Patch Clearing flags on attachment: 169759 Committed r132270: <http://trac.webkit.org/changeset/132270> 749009 6 webkit.review.bot 2012-10-23 14:46:04 -0700 All reviewed patches have been landed. Closing bug. 749014 7 dongseong.hwang 2012-10-23 14:48:13 -0700 (In reply to comment #4) > (From update of attachment 169759 [details]) > I'm not sure this is the right thing to do, but I'll r+ so that we can live on it for a while. Sometimes I think a flash is better than nothing. Thank you for your review. I think so, it is not the best way. We will find more proper solution. 169759 2012-10-20 00:11:27 -0700 2012-10-23 14:45:59 -0700 Patch bug-99908-20121020161006.patch text/plain 2641 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ1ZGRmZjkzMDQ5NTZk YWE4ZjM2YjMzZjliYjRhNDRlYWRiZThjMi4uMzkzYTQ2ZGU1OTA5MTQ1ZGZhMTQ1OGY3MTg5Zjgw M2FiN2JkY2E1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTE5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtDU1MgU2hh ZGVyc10gU2V0IEZpbHRlck9wZXJhdGlvbnMgb24gR3JhcGhpY3NMYXllciBhZnRlciB0aGUgcHJv Z3JhbSBvZiBDU1MgU2hhZGVycyBpcyBsb2FkZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENTUyBTaGFkZXJzIGNhbiBub3QgcmVuZGVyIGFueXRoaW5n IHVudGlsIHRoZSBwcm9ncmFtIGlzIGxvYWRlZC4gSWYgdGhlcmUgaXMKKyAgICAgICAgcGFydGlh bCBsb2FkZWQgc2hhZGVycyBwcm9ncmFtLCB3aG9sZSBGaWx0ZXJPcGVyYXRpb25zIGNoYWluIGNh biBub3QgcmVuZGVyCisgICAgICAgIGFueXRoaW5nLiBJdCBvY2N1cnMgYSBmbGFzaC4gU28gV2Ug aGF2ZSB0byB3YWl0IHVudGlsIHRoZSBwcm9ncmFtIGlzIGxvYWRlZCwgdG8KKyAgICAgICAgcHJl dmVudCBhIGZsYXNoIGFzIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlSW1hZ2VDb250ZW50cygp IHdhaXRzIHVudGlsIGFuCisgICAgICAgIGltYWdlIGlzIGZ1bGx5IGxvYWRlZC4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIENTUyBTaGFkZXJzIG9uIEFjY2VsZXJhdGVkIENvbXBvc2l0aW5nIGFy ZSBub3QgYWN0aXZhdGVkIHlldC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVG aWx0ZXJzKToKKwogMjAxMi0xMC0xOCAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55 MTAwLm5ldD4KIAogICAgICAgICBbQ1NTIFNoYWRlcnNdIEFkZCBDdXN0b21GaWx0ZXJSZW5kZXJl ciB0byByZXVzZSB0aGlzIGNsYXNzIGJ5IEFjY2VsZXJhdGVkIENvbXBvc2l0aW5nLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCA4YzE0 N2UxNDE3YmY3MWYxODE2OGEwMmZhZjk0NTNlOTc2OTI0NjFmLi4xODE3Y2ZmYTdjMjhkMTU0ZTlj ZmM4ODZiYzJlMjJkZmFmOWM1NGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtNjAsNiArNjAsOSBAQAogCiAjaWYgRU5BQkxFKENT U19GSUxURVJTKQogI2luY2x1ZGUgIkZpbHRlckVmZmVjdFJlbmRlcmVyLmgiCisjaWYgRU5BQkxF KENTU19TSEFERVJTKQorI2luY2x1ZGUgIkN1c3RvbUZpbHRlck9wZXJhdGlvbi5oIgorI2VuZGlm CiAjZW5kaWYKIAogI2lmIEVOQUJMRShXRUJHTCkgfHwgRU5BQkxFKEFDQ0VMRVJBVEVEXzJEX0NB TlZBUykKQEAgLTI1NCw2ICsyNTcsMTggQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0 ZVRyYW5zZm9ybShjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpCiAjaWYgRU5BQkxFKENTU19GSUxU RVJTKQogdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUZpbHRlcnMoY29uc3QgUmVuZGVy U3R5bGUqIHN0eWxlKQogeworI2lmIEVOQUJMRShDU1NfU0hBREVSUykKKyAgICBjb25zdCBGaWx0 ZXJPcGVyYXRpb25zJiBmaWx0ZXJzID0gc3R5bGUtPmZpbHRlcigpOworICAgIGlmIChmaWx0ZXJz Lmhhc0N1c3RvbUZpbHRlcigpKSB7CisgICAgICAgIGNvbnN0IEN1c3RvbUZpbHRlck9wZXJhdGlv biogY3VzdG9tT3BlcmF0aW9uOworICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGZpbHRl cnMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgICAgIGN1c3RvbU9wZXJhdGlvbiA9IHN0YXRpY19j YXN0PGNvbnN0IEN1c3RvbUZpbHRlck9wZXJhdGlvbio+KGZpbHRlcnMuYXQoaSkpOworICAgICAg ICAgICAgLy8gV2UgaGF2ZSB0byB3YWl0IHVudGlsIHRoZSBwcm9ncmFtIG9mIENTUyBTaGFkZXJz IGlzIGxvYWRlZCBiZWZvcmUgc2V0dGluZyBpdCBvbiB0aGUgbGF5ZXIuCisgICAgICAgICAgICBp ZiAoY3VzdG9tT3BlcmF0aW9uLT5nZXRPcGVyYXRpb25UeXBlKCkgPT0gRmlsdGVyT3BlcmF0aW9u OjpDVVNUT00gJiYgIWN1c3RvbU9wZXJhdGlvbi0+cHJvZ3JhbSgpLT5pc0xvYWRlZCgpKQorICAg ICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0KKyNlbmRpZgogICAgIG1fY2Fu Q29tcG9zaXRlRmlsdGVycyA9IG1fZ3JhcGhpY3NMYXllci0+c2V0RmlsdGVycyhzdHlsZS0+Zmls dGVyKCkpOwogfQogI2VuZGlmCg==