99902 2012-10-19 19:59:11 -0700 [WK2][EFL] Modify ewk_view_scale_set to public API 2012-10-19 21:52:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99451 1 ktf.kim ktf.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 746866 0 ktf.kim 2012-10-19 19:59:11 -0700 The function ewk_view_scale_set need to be public API for a scale setting on external programs. 746867 1 169749 ktf.kim 2012-10-19 20:01:55 -0700 Created attachment 169749 Patch 746878 2 169749 gyuyoung.kim 2012-10-19 21:18:31 -0700 Comment on attachment 169749 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review I think it would be good if you add test case as well. > Source/WebKit2/ChangeLog:3 > + [WK2][EFL] Modify ewk_view_scale_set to public API set to -> set to. Remove unneeded a space. 746880 3 169752 ktf.kim 2012-10-19 21:28:47 -0700 Created attachment 169752 Patch 746881 4 gyuyoung.kim 2012-10-19 21:31:46 -0700 (In reply to comment #2) > (From update of attachment 169749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169749&action=review > > I think it would be good if you add test case as well. I set r- because this patch should be added with test case. 746882 5 ktf.kim 2012-10-19 21:33:50 -0700 If the 'test case' means a unit test test case, it is on the other bug: https://bugs.webkit.org/show_bug.cgi?id=99451 This is for fixing error on the build bot for that and 99285. I uploaded without test case because a similar case was merged without test case before : ​https://bugs.webkit.org/show_bug.cgi?id=94589 746889 6 169752 webkit.review.bot 2012-10-19 21:52:41 -0700 Comment on attachment 169752 Patch Clearing flags on attachment: 169752 Committed r131976: <http://trac.webkit.org/changeset/131976> 746890 7 webkit.review.bot 2012-10-19 21:52:45 -0700 All reviewed patches have been landed. Closing bug. 169749 2012-10-19 20:01:55 -0700 2012-10-19 21:28:43 -0700 Patch bug-99902-20121020120038.patch text/plain 1407 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZlMGJhMjg4YmYwNGFm ZTgwZWQ3ZTUwZTI1Y2JhNDBkZWNiNDM1Ni4uMDM3NWJkOTYxNTRkN2Y4MzcxZjljZTVmNjNiNGEy N2UyYWI3OTFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTE5ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdW0VGTF0gTW9k aWZ5IGV3a192aWV3X3NjYWxlX3NldCAgdG8gcHVibGljIEFQSQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk5MDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZnkgZXdrX3ZpZXdfc2NhbGVfc2V0IHRv IHB1YmxpYyBBUEkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oOgor CiAyMDEyLTEwLTE5ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWJQcm9jZXNzIHNob3VsZCBvbmx5IGNvbm5lY3QgdG8gdGhlIE5ldHdvcmtQcm9jZXNzIGlm IE5ldHdvcmtQcm9jZXNzIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5oCmluZGV4IDM0YTA4MTdiYWUxNjg1MDc0NDhiN2ZhNWI0YTkxMWYxMmVk ZGU1OTAuLjU5ODA5ZmFiNmZlMzk0NGY2ZGYyYmZhNWMwMWE3M2UxYzdkMGY4YmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaApAQCAtNTI2LDcgKzUyNiw3 IEBAIEVBUEkgRWluYV9Cb29sIGV3a192aWV3X2h0bWxfc3RyaW5nX2xvYWQoRXZhc19PYmplY3Qg Km8sIGNvbnN0IGNoYXIgKmh0bWwsIGNvbnN0CiAgKgogICogQHJldHVybiBAYyBFSU5BX1RSVUUg b24gc3VjY2VzcyBvciBAYyBFSU5BX0ZBTFNFIG90aGVyd2lzZQogICovCi1FaW5hX0Jvb2wgZXdr X3ZpZXdfc2NhbGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBkb3VibGUgc2NhbGVGYWN0b3IsIGludCB4 LCBpbnQgeSk7CitFQVBJIEVpbmFfQm9vbCBld2tfdmlld19zY2FsZV9zZXQoRXZhc19PYmplY3Qg Km8sIGRvdWJsZSBzY2FsZUZhY3RvciwgaW50IHgsIGludCB5KTsKIAogLyoqCiAgKiBRdWVyaWVz IHRoZSBjdXJyZW50IHNjYWxlIGZhY3RvciBvZiB0aGUgcGFnZS4K 169752 2012-10-19 21:28:47 -0700 2012-10-19 21:52:40 -0700 Patch bug-99902-20121020132730.patch text/plain 1406 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZlMGJhMjg4YmYwNGFm ZTgwZWQ3ZTUwZTI1Y2JhNDBkZWNiNDM1Ni4uYzNlNTI0NjZhNzgxNmUyZGRkNWNkNWNkYjczOWY1 YTE0MWZiMzRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTE5ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXSzJdW0VGTF0gTW9k aWZ5IGV3a192aWV3X3NjYWxlX3NldCB0byBwdWJsaWMgQVBJCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTkwMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmeSBld2tfdmlld19zY2FsZV9zZXQgdG8g cHVibGljIEFQSS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3Lmg6CisK IDIwMTItMTAtMTkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYlByb2Nlc3Mgc2hvdWxkIG9ubHkgY29ubmVjdCB0byB0aGUgTmV0d29ya1Byb2Nlc3MgaWYg TmV0d29ya1Byb2Nlc3MgaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3LmgKaW5kZXggMzRhMDgxN2JhZTE2ODUwNzQ0OGI3ZmE1YjRhOTExZjEyZWRk ZTU5MC4uNTk4MDlmYWI2ZmUzOTQ0ZjZkZjJiZmE1YzAxYTczZTFjN2QwZjhiZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCkBAIC01MjYsNyArNTI2LDcg QEAgRUFQSSBFaW5hX0Jvb2wgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZChFdmFzX09iamVjdCAq bywgY29uc3QgY2hhciAqaHRtbCwgY29uc3QKICAqCiAgKiBAcmV0dXJuIEBjIEVJTkFfVFJVRSBv biBzdWNjZXNzIG9yIEBjIEVJTkFfRkFMU0Ugb3RoZXJ3aXNlCiAgKi8KLUVpbmFfQm9vbCBld2tf dmlld19zY2FsZV9zZXQoRXZhc19PYmplY3QgKm8sIGRvdWJsZSBzY2FsZUZhY3RvciwgaW50IHgs IGludCB5KTsKK0VBUEkgRWluYV9Cb29sIGV3a192aWV3X3NjYWxlX3NldChFdmFzX09iamVjdCAq bywgZG91YmxlIHNjYWxlRmFjdG9yLCBpbnQgeCwgaW50IHkpOwogCiAvKioKICAqIFF1ZXJpZXMg dGhlIGN1cnJlbnQgc2NhbGUgZmFjdG9yIG9mIHRoZSBwYWdlLgo=