99855 2012-10-19 11:10:10 -0700 Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers 2012-10-19 16:23:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 746459 0 msaboff 2012-10-19 11:10:10 -0700 Although the Lexer code has been modified to create 8 bit strings, there are two cases where 8 bit Identifiers could be created and aren't. 1. In scanRegExp(), if the source is 8 bits, both the pattern and flags can also be 8 bit identifiers. 2. When scanning an identifier in lexExpectIdentifier(), there is code to check for ASCII identifier characters and goes to a slow case for non-ASCII. The ASCII case can create 8 bit identifiers even if the source is 16 bit. 746483 1 169661 msaboff 2012-10-19 11:27:33 -0700 Created attachment 169661 Patch 746744 2 169661 webkit.review.bot 2012-10-19 16:23:41 -0700 Comment on attachment 169661 Patch Clearing flags on attachment: 169661 Committed r131956: <http://trac.webkit.org/changeset/131956> 746745 3 webkit.review.bot 2012-10-19 16:23:44 -0700 All reviewed patches have been landed. Closing bug. 169661 2012-10-19 11:27:33 -0700 2012-10-19 16:23:41 -0700 Patch 99855.patch text/plain 4557 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxOTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEyLTEwLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIExleGVyIHNob3VsZCBjcmVhdGUgOCBiaXQgSWRlbnRpZmllcnMgZm9yIFJlZ3VsYXJFeHBy ZXNzaW9ucyBhbmQgQVNDSUkgaWRlbnRpZmllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk5ODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbWFrZUlkZW50aWZpZXIgaGVscGVycyB0aGF0IHdp bGwgYWx3YXlzIG1ha2UgYW4gOCBiaXQgSWRlbnRpZmllciBvciBtYWtlIGFuCisgICAgICAgIElk ZW50aWZpZXIgdGhhdCBpcyB0aGUgc2FtZSBzaXplIGFzIHRoZSB0ZW1wbGF0ZSBwYXJhbWV0ZXIu ICBVc2VkIHRoZSBmaXJzdCBpbiB0aGUgZmFzdAorICAgICAgICBwYXRoIHdoZW4gbG9va2luZyBm b3IgYSBKUyBpZGVudGlmaWVyIGFuZCB0aGUgc2Vjb25kIHdoZW4gc2Nhbm5pbmcgcmVndWxhciBl eHByZXNzaW9ucy4KKworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6CisgICAgICAgIChKU0M6 Ojo6c2NhblJlZ0V4cCk6CisgICAgICAgICogcGFyc2VyL0xleGVyLmg6CisgICAgICAgIChMZXhl cik6CisgICAgICAgIChKU0M6Ojo6bWFrZUlkZW50aWZpZXJTYW1lVHlwZSk6CisgICAgICAgIChK U0M6Ojo6bWFrZUxDaGFySWRlbnRpZmllcik6CisgICAgICAgIChKU0M6Ojo6bGV4RXhwZWN0SWRl bnRpZmllcik6CisKIDIwMTItMTAtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBSZWdFeHBLZXkKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCShyZXZpc2lvbiAxMzE4MzYpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYxNyw3ICsxNjE3 LDcgQEAgYm9vbCBMZXhlcjxUPjo6c2NhblJlZ0V4cChjb25zdCBJZGVudGlmaQogICAgICAgICB9 CiAgICAgfQogCi0gICAgcGF0dGVybiA9IG1ha2VJZGVudGlmaWVyKG1fYnVmZmVyMTYuZGF0YSgp LCBtX2J1ZmZlcjE2LnNpemUoKSk7CisgICAgcGF0dGVybiA9IG1ha2VJZGVudGlmaWVyU2FtZVR5 cGUobV9idWZmZXIxNi5kYXRhKCksIG1fYnVmZmVyMTYuc2l6ZSgpKTsKICAgICBtX2J1ZmZlcjE2 LnJlc2l6ZSgwKTsKIAogICAgIHdoaWxlIChpc0lkZW50UGFydChtX2N1cnJlbnQpKSB7CkBAIC0x NjI1LDcgKzE2MjUsNyBAQCBib29sIExleGVyPFQ+OjpzY2FuUmVnRXhwKGNvbnN0IElkZW50aWZp CiAgICAgICAgIHNoaWZ0KCk7CiAgICAgfQogCi0gICAgZmxhZ3MgPSBtYWtlSWRlbnRpZmllciht X2J1ZmZlcjE2LmRhdGEoKSwgbV9idWZmZXIxNi5zaXplKCkpOworICAgIGZsYWdzID0gbWFrZUlk ZW50aWZpZXJTYW1lVHlwZShtX2J1ZmZlcjE2LmRhdGEoKSwgbV9idWZmZXIxNi5zaXplKCkpOwog ICAgIG1fYnVmZmVyMTYucmVzaXplKDApOwogCiAgICAgcmV0dXJuIHRydWU7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5oCShyZXZpc2lvbiAxMzE4MzYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Niw2ICsx NDYsOSBAQCBwcml2YXRlOgogCiAgICAgQUxXQVlTX0lOTElORSBjb25zdCBJZGVudGlmaWVyKiBt YWtlSWRlbnRpZmllcihjb25zdCBMQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCk7CiAg ICAgQUxXQVlTX0lOTElORSBjb25zdCBJZGVudGlmaWVyKiBtYWtlSWRlbnRpZmllcihjb25zdCBV Q2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCk7CisgICAgQUxXQVlTX0lOTElORSBjb25z dCBJZGVudGlmaWVyKiBtYWtlTENoYXJJZGVudGlmaWVyKGNvbnN0IExDaGFyKiBjaGFyYWN0ZXJz LCBzaXplX3QgbGVuZ3RoKTsKKyAgICBBTFdBWVNfSU5MSU5FIGNvbnN0IElkZW50aWZpZXIqIG1h a2VMQ2hhcklkZW50aWZpZXIoY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHNpemVfdCBsZW5ndGgp OworICAgIEFMV0FZU19JTkxJTkUgY29uc3QgSWRlbnRpZmllciogbWFrZUlkZW50aWZpZXJTYW1l VHlwZShjb25zdCBVQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCk7CiAgICAgQUxXQVlT X0lOTElORSBjb25zdCBJZGVudGlmaWVyKiBtYWtlSWRlbnRpZmllckxDaGFyRnJvbVVDaGFyKGNv bnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoKTsKIAogICAgIEFMV0FZU19JTkxJ TkUgYm9vbCBsYXN0VG9rZW5XYXNSZXN0cktleXdvcmQoKSBjb25zdDsKQEAgLTIzOSw2ICsyNDIs MTggQEAgQUxXQVlTX0lOTElORSBjb25zdCBJZGVudGlmaWVyKiBMZXhlcjxUPgogfQogCiB0ZW1w bGF0ZSA8PgorQUxXQVlTX0lOTElORSBjb25zdCBJZGVudGlmaWVyKiBMZXhlcjxMQ2hhcj46Om1h a2VJZGVudGlmaWVyU2FtZVR5cGUoY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHNpemVfdCBsZW5n dGgpCit7CisgICAgcmV0dXJuICZtX2FyZW5hLT5tYWtlSWRlbnRpZmllckxDaGFyRnJvbVVDaGFy KG1fZ2xvYmFsRGF0YSwgY2hhcmFjdGVycywgbGVuZ3RoKTsKK30KKwordGVtcGxhdGUgPD4KK0FM V0FZU19JTkxJTkUgY29uc3QgSWRlbnRpZmllciogTGV4ZXI8VUNoYXI+OjptYWtlSWRlbnRpZmll clNhbWVUeXBlKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoKQoreworICAg IHJldHVybiAmbV9hcmVuYS0+bWFrZUlkZW50aWZpZXIobV9nbG9iYWxEYXRhLCBjaGFyYWN0ZXJz LCBsZW5ndGgpOworfQorCit0ZW1wbGF0ZSA8PgogQUxXQVlTX0lOTElORSB2b2lkIExleGVyPExD aGFyPjo6c2V0Q29kZVN0YXJ0KGNvbnN0IFN0cmluZ0ltcGwqIHNvdXJjZVN0cmluZykKIHsKICAg ICBBU1NFUlQoc291cmNlU3RyaW5nLT5pczhCaXQoKSk7CkBAIC0yNTksNiArMjc0LDE4IEBAIEFM V0FZU19JTkxJTkUgY29uc3QgSWRlbnRpZmllciogTGV4ZXI8VD4KIH0KIAogdGVtcGxhdGUgPHR5 cGVuYW1lIFQ+CitBTFdBWVNfSU5MSU5FIGNvbnN0IElkZW50aWZpZXIqIExleGVyPFQ+OjptYWtl TENoYXJJZGVudGlmaWVyKGNvbnN0IExDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoKQor eworICAgIHJldHVybiAmbV9hcmVuYS0+bWFrZUlkZW50aWZpZXIobV9nbG9iYWxEYXRhLCBjaGFy YWN0ZXJzLCBsZW5ndGgpOworfQorCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KK0FMV0FZU19JTkxJ TkUgY29uc3QgSWRlbnRpZmllciogTGV4ZXI8VD46Om1ha2VMQ2hhcklkZW50aWZpZXIoY29uc3Qg VUNoYXIqIGNoYXJhY3RlcnMsIHNpemVfdCBsZW5ndGgpCit7CisgICAgcmV0dXJuICZtX2FyZW5h LT5tYWtlSWRlbnRpZmllckxDaGFyRnJvbVVDaGFyKG1fZ2xvYmFsRGF0YSwgY2hhcmFjdGVycywg bGVuZ3RoKTsKK30KKwordGVtcGxhdGUgPHR5cGVuYW1lIFQ+CiBBTFdBWVNfSU5MSU5FIEpTVG9r ZW5UeXBlIExleGVyPFQ+OjpsZXhFeHBlY3RJZGVudGlmaWVyKEpTVG9rZW5EYXRhKiB0b2tlbkRh dGEsIEpTVG9rZW5Mb2NhdGlvbiogdG9rZW5Mb2NhdGlvbiwgdW5zaWduZWQgbGV4ZXJGbGFncywg Ym9vbCBzdHJpY3RNb2RlKQogewogICAgIEFTU0VSVCgobGV4ZXJGbGFncyAmIExleGVyRmxhZ3NJ Z25vcmVSZXNlcnZlZFdvcmRzKSk7CkBAIC0yOTMsNyArMzIwLDcgQEAgQUxXQVlTX0lOTElORSBK U1Rva2VuVHlwZSBMZXhlcjxUPjo6bGV4RQogICAgIGlmIChsZXhlckZsYWdzICYgTGV4ZXhGbGFn c0RvbnRCdWlsZEtleXdvcmRzKQogICAgICAgICB0b2tlbkRhdGEtPmlkZW50ID0gMDsKICAgICBl bHNlCi0gICAgICAgIHRva2VuRGF0YS0+aWRlbnQgPSBtYWtlSWRlbnRpZmllcihzdGFydCwgcHRy IC0gc3RhcnQpOworICAgICAgICB0b2tlbkRhdGEtPmlkZW50ID0gbWFrZUxDaGFySWRlbnRpZmll cihzdGFydCwgcHRyIC0gc3RhcnQpOwogICAgIHRva2VuTG9jYXRpb24tPmxpbmUgPSBtX2xpbmVO dW1iZXI7CiAgICAgdG9rZW5Mb2NhdGlvbi0+c3RhcnRPZmZzZXQgPSBzdGFydCAtIG1fY29kZVN0 YXJ0OwogICAgIHRva2VuTG9jYXRpb24tPmVuZE9mZnNldCA9IGN1cnJlbnRPZmZzZXQoKTsK