<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99851</bug_id>
          
          <creation_ts>2012-10-19 10:12:30 -0700</creation_ts>
          <short_desc>Obsolete code in User Timing implementation</short_desc>
          <delta_ts>2012-10-22 15:34:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="pdeng6">pan.deng</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>tonyg</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>746405</commentid>
    <comment_count>0</comment_count>
    <who name="pdeng6">pan.deng</who>
    <bug_when>2012-10-19 10:12:30 -0700</bug_when>
    <thetext>PlatformString.h, prefix of webkitNow is removed.
&apos;first&apos; and &apos;second&apos; are replaced by &apos;key&apos; &apos;value&apos; for HashMap iterator</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>746412</commentid>
    <comment_count>1</comment_count>
      <attachid>169643</attachid>
    <who name="pdeng6">pan.deng</who>
    <bug_when>2012-10-19 10:16:34 -0700</bug_when>
    <thetext>Created attachment 169643
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>746448</commentid>
    <comment_count>2</comment_count>
      <attachid>169643</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-19 10:57:38 -0700</bug_when>
    <thetext>Comment on attachment 169643
Patch

Rejecting attachment 169643 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12732 --non-interactive --force --accept theirs-conflict --ignore-externals&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;
50&gt;At revision 12732.

________ running &apos;/usr/bin/python tools/clang/scripts/update.py --mac-only&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;

________ running &apos;/usr/bin/python gyp_webkit&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14465531</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>746812</commentid>
    <comment_count>3</comment_count>
      <attachid>169734</attachid>
    <who name="pdeng6">pan.deng</who>
    <bug_when>2012-10-19 18:00:38 -0700</bug_when>
    <thetext>Created attachment 169734
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>747965</commentid>
    <comment_count>4</comment_count>
      <attachid>169734</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-22 15:34:47 -0700</bug_when>
    <thetext>Comment on attachment 169734
Patch

Clearing flags on attachment: 169734

Committed r132146: &lt;http://trac.webkit.org/changeset/132146&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>747966</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-22 15:34:50 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>169643</attachid>
            <date>2012-10-19 10:16:34 -0700</date>
            <delta_ts>2012-10-19 18:00:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99851-20121020012049.patch</filename>
            <type>text/plain</type>
            <size>2965</size>
            <attacher name="pdeng6">pan.deng</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTlhZmI5OTA1MzRjYWFm
ZDI5YWE4MWM0ZTEwYWExZGNjMjk1NTNkOS4uNDIwNzNmMjdmZDdjZTMzZWE4NmQ4NmE1ZWRlN2Rl
ZTgwNmQzMDY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE5ICBQYW4g
RGVuZyAgPHBhbi5kZW5nQGludGVsLmNvbT4KKworICAgICAgICBNb2RpZnkgb2Jzb2xldGUgY29k
ZSBpbiBVc2VyIFRpbWluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9OTk4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBNb2RpZnkgdXNlciB0aW1pbmcgaW1wbGVtZW50YXRpb24gYXMgUGxhdGZvcm1TdHJp
bmcuaCwgcHJlZml4IG9mIHdlYmtpdE5vdyBpcyByZW1vdmVkLCBldGMuCisKKyAgICAgICAgTm8g
bmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlVXNlclRpbWlu
Zy5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbnNlcnRQZXJmb3JtYW5jZUVudHJ5KToKKyAgICAg
ICAgKFdlYkNvcmU6OlVzZXJUaW1pbmc6Om1hcmspOgorICAgICAgICAoV2ViQ29yZTo6VXNlclRp
bWluZzo6bWVhc3VyZSk6CisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuaDoK
KwogMjAxMi0xMC0xNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAg
ICAgICAgIEFYOiBSZWZhY3RvciBhY2Nlc3NpYmlsaXR5IG5hbWUgY29tcHV0YXRpb24gc28gaXQn
cyBtb3JlIHBsYXRmb3JtIGluZGVwZW5kZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
YWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZv
cm1hbmNlVXNlclRpbWluZy5jcHAKaW5kZXggYjVmNzI5Mjk0OTgzYmU0MmJkYzNkZmU3ZjVhMWRj
ZWRmMmYwMWNmOS4uYmM2MDkyMjJlN2VmZjdkNWFjNDExYmRiYmRiZDEyOGU3ODJhYjRlZCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmNwcApAQCAtODMs
NyArODMsNyBAQCBzdGF0aWMgdm9pZCBpbnNlcnRQZXJmb3JtYW5jZUVudHJ5KFBlcmZvcm1hbmNl
RW50cnlNYXAmIHBlcmZvcm1hbmNlRW50cnlNYXAsIFBhcwogICAgIFJlZlB0cjxQZXJmb3JtYW5j
ZUVudHJ5PiBlbnRyeSA9IHBlcmZvcm1hbmNlRW50cnk7CiAgICAgUGVyZm9ybWFuY2VFbnRyeU1h
cDo6aXRlcmF0b3IgaXQgPSBwZXJmb3JtYW5jZUVudHJ5TWFwLmZpbmQoZW50cnktPm5hbWUoKSk7
CiAgICAgaWYgKGl0ICE9IHBlcmZvcm1hbmNlRW50cnlNYXAuZW5kKCkpCi0gICAgICAgIGl0LT5z
ZWNvbmQuYXBwZW5kKGVudHJ5KTsKKyAgICAgICAgaXQtPnZhbHVlLmFwcGVuZChlbnRyeSk7CiAg
ICAgZWxzZSB7CiAgICAgICAgIFZlY3RvcjxSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4gPiB2KDEp
OwogICAgICAgICB2WzBdID0gZW50cnk7CkBAIC0xMTAsNyArMTEwLDcgQEAgdm9pZCBVc2VyVGlt
aW5nOjptYXJrKGNvbnN0IFN0cmluZyYgbWFya05hbWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAg
ICAgICByZXR1cm47CiAgICAgfQogCi0gICAgZG91YmxlIHN0YXJ0VGltZSA9IG1fcGVyZm9ybWFu
Y2UtPndlYmtpdE5vdygpOworICAgIGRvdWJsZSBzdGFydFRpbWUgPSBtX3BlcmZvcm1hbmNlLT5u
b3coKTsKICAgICBpbnNlcnRQZXJmb3JtYW5jZUVudHJ5KG1fbWFya3NNYXAsIFBlcmZvcm1hbmNl
TWFyazo6Y3JlYXRlKG1hcmtOYW1lLCBzdGFydFRpbWUpKTsKIH0KIApAQCAtMTM5LDkgKzEzOSw5
IEBAIHZvaWQgVXNlclRpbWluZzo6bWVhc3VyZShjb25zdCBTdHJpbmcmIG1lYXN1cmVOYW1lLCBj
b25zdCBTdHJpbmcmIHN0YXJ0TWFyaywgY29uCiAgICAgZG91YmxlIGVuZFRpbWUgPSAwLjA7CiAK
ICAgICBpZiAoc3RhcnRNYXJrLmlzTnVsbCgpKQotICAgICAgICBlbmRUaW1lID0gbV9wZXJmb3Jt
YW5jZS0+d2Via2l0Tm93KCk7CisgICAgICAgIGVuZFRpbWUgPSBtX3BlcmZvcm1hbmNlLT5ub3co
KTsKICAgICBlbHNlIGlmIChlbmRNYXJrLmlzTnVsbCgpKSB7Ci0gICAgICAgIGVuZFRpbWUgPSBt
X3BlcmZvcm1hbmNlLT53ZWJraXROb3coKTsKKyAgICAgICAgZW5kVGltZSA9IG1fcGVyZm9ybWFu
Y2UtPm5vdygpOwogICAgICAgICBzdGFydFRpbWUgPSBmaW5kRXhpc3RpbmdNYXJrU3RhcnRUaW1l
KHN0YXJ0TWFyaywgZWMpOwogICAgICAgICBpZiAoZWMpCiAgICAgICAgICAgICByZXR1cm47CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5oIGIv
U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuaAppbmRleCAwODQ0MWVl
ZTA4YmY1Yjc0MmE0OWE5NGY2OGFhYjZkNmUxNjBlZWJhLi44NGQ0OTQ3MjJlYWFkYzhhMDM0ODVj
OWNkNGE1NzNlZDI3NDMxOTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZv
cm1hbmNlVXNlclRpbWluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VV
c2VyVGltaW5nLmgKQEAgLTMyLDcgKzMyLDYgQEAKICNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgi
CiAjaW5jbHVkZSAiUGVyZm9ybWFuY2UuaCIKICNpbmNsdWRlICJQZXJmb3JtYW5jZVRpbWluZy5o
IgotI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4K
ICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkLmg+
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>169734</attachid>
            <date>2012-10-19 18:00:38 -0700</date>
            <delta_ts>2012-10-22 15:34:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99851-20121020090453.patch</filename>
            <type>text/plain</type>
            <size>2943</size>
            <attacher name="pdeng6">pan.deng</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmYzNjIyM2E0NmM3ZjNm
ODI3ZDg0ZmQ2N2I2YWY4NDg5NjkyYTRkNi4uYTdkNDg5YWFhMmM5ZWM4OTg0N2FmNzk5MzAzZThj
ZDlkMDJkZDcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE5ICBQYW4g
RGVuZyAgPHBhbi5kZW5nQGludGVsLmNvbT4KKworICAgICAgICBNb2RpZnkgb2Jzb2xldGUgY29k
ZSBpbiBVc2VyIFRpbWluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9OTk4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBNb2RpZnkgdXNlciB0aW1pbmcgaW1wbGVtZW50YXRpb24gYXMgUGxhdGZvcm1TdHJp
bmcuaCwgcHJlZml4IG9mIHdlYmtpdE5vdyBpcyByZW1vdmVkLCBldGMuCisKKyAgICAgICAgTm8g
bmV3IHRlc3RzLgorCisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6aW5zZXJ0UGVyZm9ybWFuY2VFbnRyeSk6CisgICAgICAgIChXZWJD
b3JlOjpVc2VyVGltaW5nOjptYXJrKToKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJUaW1pbmc6Om1l
YXN1cmUpOgorICAgICAgICAqIHBhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmg6CisKIDIwMTIt
MTAtMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg
UmVtb3ZlIC5nZXQoKSBjYWxscyBpbiBhc3NlcnRpb25zIGFzIHN1Z2dlc3RlZCBieSBEYXJpbiBB
ZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGlt
aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmNwcApp
bmRleCBiNWY3MjkyOTQ5ODNiZTQyYmRjM2RmZTdmNWExZGNlZGYyZjAxY2Y5Li5iYzYwOTIyMmU3
ZWZmN2Q1YWM0MTFiZGJiZGJkMTI4ZTc4MmFiNGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wYWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn
ZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuY3BwCkBAIC04Myw3ICs4Myw3IEBAIHN0YXRpYyB2b2lk
IGluc2VydFBlcmZvcm1hbmNlRW50cnkoUGVyZm9ybWFuY2VFbnRyeU1hcCYgcGVyZm9ybWFuY2VF
bnRyeU1hcCwgUGFzCiAgICAgUmVmUHRyPFBlcmZvcm1hbmNlRW50cnk+IGVudHJ5ID0gcGVyZm9y
bWFuY2VFbnRyeTsKICAgICBQZXJmb3JtYW5jZUVudHJ5TWFwOjppdGVyYXRvciBpdCA9IHBlcmZv
cm1hbmNlRW50cnlNYXAuZmluZChlbnRyeS0+bmFtZSgpKTsKICAgICBpZiAoaXQgIT0gcGVyZm9y
bWFuY2VFbnRyeU1hcC5lbmQoKSkKLSAgICAgICAgaXQtPnNlY29uZC5hcHBlbmQoZW50cnkpOwor
ICAgICAgICBpdC0+dmFsdWUuYXBwZW5kKGVudHJ5KTsKICAgICBlbHNlIHsKICAgICAgICAgVmVj
dG9yPFJlZlB0cjxQZXJmb3JtYW5jZUVudHJ5PiA+IHYoMSk7CiAgICAgICAgIHZbMF0gPSBlbnRy
eTsKQEAgLTExMCw3ICsxMTAsNyBAQCB2b2lkIFVzZXJUaW1pbmc6Om1hcmsoY29uc3QgU3RyaW5n
JiBtYXJrTmFtZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAK
LSAgICBkb3VibGUgc3RhcnRUaW1lID0gbV9wZXJmb3JtYW5jZS0+d2Via2l0Tm93KCk7CisgICAg
ZG91YmxlIHN0YXJ0VGltZSA9IG1fcGVyZm9ybWFuY2UtPm5vdygpOwogICAgIGluc2VydFBlcmZv
cm1hbmNlRW50cnkobV9tYXJrc01hcCwgUGVyZm9ybWFuY2VNYXJrOjpjcmVhdGUobWFya05hbWUs
IHN0YXJ0VGltZSkpOwogfQogCkBAIC0xMzksOSArMTM5LDkgQEAgdm9pZCBVc2VyVGltaW5nOjpt
ZWFzdXJlKGNvbnN0IFN0cmluZyYgbWVhc3VyZU5hbWUsIGNvbnN0IFN0cmluZyYgc3RhcnRNYXJr
LCBjb24KICAgICBkb3VibGUgZW5kVGltZSA9IDAuMDsKIAogICAgIGlmIChzdGFydE1hcmsuaXNO
dWxsKCkpCi0gICAgICAgIGVuZFRpbWUgPSBtX3BlcmZvcm1hbmNlLT53ZWJraXROb3coKTsKKyAg
ICAgICAgZW5kVGltZSA9IG1fcGVyZm9ybWFuY2UtPm5vdygpOwogICAgIGVsc2UgaWYgKGVuZE1h
cmsuaXNOdWxsKCkpIHsKLSAgICAgICAgZW5kVGltZSA9IG1fcGVyZm9ybWFuY2UtPndlYmtpdE5v
dygpOworICAgICAgICBlbmRUaW1lID0gbV9wZXJmb3JtYW5jZS0+bm93KCk7CiAgICAgICAgIHN0
YXJ0VGltZSA9IGZpbmRFeGlzdGluZ01hcmtTdGFydFRpbWUoc3RhcnRNYXJrLCBlYyk7CiAgICAg
ICAgIGlmIChlYykKICAgICAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bl
cmZvcm1hbmNlVXNlclRpbWluZy5oCmluZGV4IDA4NDQxZWVlMDhiZjViNzQyYTQ5YTk0ZjY4YWFi
NmQ2ZTE2MGVlYmEuLjg0ZDQ5NDcyMmVhYWRjOGEwMzQ4NWM5Y2Q0YTU3M2VkMjc0MzE5ODAgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VVc2VyVGltaW5nLmgKKysr
IGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVVzZXJUaW1pbmcuaApAQCAtMzIsNyAr
MzIsNiBAQAogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJQZXJmb3JtYW5j
ZS5oIgogI2luY2x1ZGUgIlBlcmZvcm1hbmNlVGltaW5nLmgiCi0jaW5jbHVkZSAiUGxhdGZvcm1T
dHJpbmcuaCIKICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVm
UHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>