99847 2012-10-19 10:02:55 -0700 [BlackBerry] Move all keyboard type calculations into InputHandler. 2012-10-19 13:09:12 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 746391 0 mifenton 2012-10-19 10:02:55 -0700 SSIA. 746394 1 169639 mifenton 2012-10-19 10:04:55 -0700 Created attachment 169639 Patch 746576 2 169639 webkit.review.bot 2012-10-19 13:09:09 -0700 Comment on attachment 169639 Patch Clearing flags on attachment: 169639 Committed r131937: <http://trac.webkit.org/changeset/131937> 746577 3 webkit.review.bot 2012-10-19 13:09:12 -0700 All reviewed patches have been landed. Closing bug. 169639 2012-10-19 10:04:55 -0700 2012-10-19 13:09:08 -0700 Patch 0001-2012-10-18-Mike-Fenton-mifenton-rim.com.patch text/plain 5037 mifenton RnJvbSA1MmZjN2M3MmYyOTRiMDI4OWJiZjUwMjQzNDk4Y2MyNDRiYmZhYjc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAxOCBPY3QgMjAxMiAxNjozMzo1OSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMTAt MTggIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgTmVlZCBhIHNob3J0 IGRlc2NyaXB0aW9uIChPT1BTISkuCiAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUFIgMjI3MzgxLgoK ICAgICAgICBNb3ZlIGFsbCBrZXlib2FyZCB0eXBlIGNhbGN1bGF0aW9ucyBpbnRvIHdlYmtpdCBh bmQgYXZvaWQgcGFzc2luZyB0eXBlCiAgICAgICAgaW5mb3JtYXRpb24gdG8gdGhlIHdlYnZpZXcu CgogICAgICAgICogQXBpL1dlYlBhZ2VDbGllbnQuaDoKICAgICAgICAqIFdlYktpdFN1cHBvcnQv SW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjppbnB1dFN0eWxl KToKICAgICAgICAoV2ViS2l0KToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0Ojpjb252ZXJ0 SW5wdXRUeXBlVG9WS0JUeXBlKToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhh bmRsZXI6OnVwZGF0ZUZvcm1TdGF0ZSk6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlQ2xpZW50LmggICAgICAgfCAgICAyICstCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMjAgKysrKysrKysrKysrKysrKwogLi4u L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwICAgICAgfCAgIDI1ICsr KysrKysrKysrKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGll bnQuaAppbmRleCBhYWI3ZDA5Li4xZWQ4OWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMTM5LDcgKzEzOSw3IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgbm90aWZ5Q29udGVudFJlbmRlcmVkKGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0 JikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCByZXNpemVTdXJmYWNlSWZOZWVkZWQoKSA9IDA7CiAK LSAgICB2aXJ0dWFsIHZvaWQgaW5wdXRGb2N1c0dhaW5lZChQbGF0Zm9ybTo6QmxhY2tCZXJyeUlu cHV0VHlwZSwgaW50IGlucHV0U3R5bGUsIFBsYXRmb3JtOjpWaXJ0dWFsS2V5Ym9hcmRUeXBlLCBQ bGF0Zm9ybTo6VmlydHVhbEtleWJvYXJkRW50ZXJLZXlUeXBlKSA9IDA7CisgICAgdmlydHVhbCB2 b2lkIGlucHV0Rm9jdXNHYWluZWQoaW50IGlucHV0U3R5bGUsIFBsYXRmb3JtOjpWaXJ0dWFsS2V5 Ym9hcmRUeXBlLCBQbGF0Zm9ybTo6VmlydHVhbEtleWJvYXJkRW50ZXJLZXlUeXBlKSA9IDA7CiAg ICAgdmlydHVhbCB2b2lkIGlucHV0Rm9jdXNMb3N0KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBp bnB1dFRleHRDaGFuZ2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBpbnB1dFNlbGVjdGlvbkNo YW5nZWQodW5zaWduZWQgc2VsZWN0aW9uU3RhcnQsIHVuc2lnbmVkIHNlbGVjdGlvbkVuZCkgPSAw OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggNzIzMmM5ZC4uYjc0MDgwYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTItMTAtMTkg IE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KIAorICAgICAgICBbQmxhY2tCZXJyeV0g TW92ZSBhbGwga2V5Ym9hcmQgdHlwZSBjYWxjdWxhdGlvbnMgaW50byBJbnB1dEhhbmRsZXIuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTg0NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDIyNzM4MS4K KworICAgICAgICBNb3ZlIGFsbCBrZXlib2FyZCB0eXBlIGNhbGN1bGF0aW9ucyBpbnRvIHdlYmtp dCBhbmQgYXZvaWQgcGFzc2luZyB0eXBlCisgICAgICAgIGluZm9ybWF0aW9uIHRvIHRoZSB3ZWJ2 aWV3LgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgTmltYSBHaGFuYXZhdGlhbi4K KworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisgICAgICAgICogV2ViS2l0U3VwcG9y dC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0Ojpjb252ZXJ0 SW5wdXRUeXBlVG9WS0JUeXBlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6c2V0RWxlbWVudEZvY3VzZWQpOgorCisyMDEyLTEw LTE5ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVy cnldIEFkZCBpbnB1dCBsb2dzIHRvIElucHV0SGFuZGxlcjo6ZW5zdXJlRm9jdXNUZXh0RWxlbWVu dFZpc2libGUuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05OTgzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA1NmViY2I5Li45ZGM1MjJlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxl ci5jcHAKQEAgLTI0Miw2ICsyNDIsMjYgQEAgc3RhdGljIGludCBpbnB1dFN0eWxlKEJsYWNrQmVy cnlJbnB1dFR5cGUgdHlwZSwgY29uc3QgRWxlbWVudCogZWxlbWVudCkKICAgICByZXR1cm4gREVG QVVMVF9TVFlMRTsKIH0KIAorc3RhdGljIFZpcnR1YWxLZXlib2FyZFR5cGUgY29udmVydElucHV0 VHlwZVRvVktCVHlwZShCbGFja0JlcnJ5SW5wdXRUeXBlIGlucHV0VHlwZSkKK3sKKyAgICBzd2l0 Y2ggKGlucHV0VHlwZSkgeworICAgIGNhc2UgSW5wdXRUeXBlVVJMOgorICAgICAgICByZXR1cm4g VktCVHlwZVVybDsKKyAgICBjYXNlIElucHV0VHlwZUVtYWlsOgorICAgICAgICByZXR1cm4gVktC VHlwZUVtYWlsOworICAgIGNhc2UgSW5wdXRUeXBlVGVsZXBob25lOgorICAgICAgICByZXR1cm4g VktCVHlwZVBob25lOworICAgIGNhc2UgSW5wdXRUeXBlUGFzc3dvcmQ6CisgICAgICAgIHJldHVy biBWS0JUeXBlUGFzc3dvcmQ7CisgICAgY2FzZSBJbnB1dFR5cGVOdW1iZXI6CisgICAgY2FzZSBJ bnB1dFR5cGVIZXhhZGVjaW1hbDoKKyAgICAgICAgcmV0dXJuIFZLQlR5cGVQaW47CisgICAgZGVm YXVsdDoKKyAgICAgICAgLy8gQWxsIG90aGVyIHR5cGVzIGFyZSB0ZXh0IGJhc2VkIHVzZSBkZWZh dWx0IGtleWJvYXJkLgorICAgICAgICByZXR1cm4gVktCVHlwZURlZmF1bHQ7CisgICAgfQorfQor CiBzdGF0aWMgVmlydHVhbEtleWJvYXJkVHlwZSBjb252ZXJ0U3RyaW5nVG9LZXlib2FyZFR5cGUo Y29uc3QgQXRvbWljU3RyaW5nJiBzdHJpbmcpCiB7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChB dG9taWNTdHJpbmcsIERlZmF1bHQsICgiZGVmYXVsdCIpKTsKQEAgLTgxMiw2ICs4MzIsOSBAQCB2 b2lkIElucHV0SGFuZGxlcjo6c2V0RWxlbWVudEZvY3VzZWQoRWxlbWVudCogZWxlbWVudCkKICAg ICBtX2N1cnJlbnRGb2N1c0VsZW1lbnRUZXh0RWRpdE1hc2sgPSBpbnB1dFN0eWxlKHR5cGUsIGVs ZW1lbnQpOwogCiAgICAgVmlydHVhbEtleWJvYXJkVHlwZSBrZXlib2FyZFR5cGUgPSBrZXlib2Fy ZFR5cGVBdHRyaWJ1dGUoZWxlbWVudCk7CisgICAgaWYgKGtleWJvYXJkVHlwZSA9PSBWS0JUeXBl Tm90U2V0KQorICAgICAgICBrZXlib2FyZFR5cGUgPSBjb252ZXJ0SW5wdXRUeXBlVG9WS0JUeXBl KHR5cGUpOworCiAgICAgVmlydHVhbEtleWJvYXJkRW50ZXJLZXlUeXBlIGVudGVyS2V5VHlwZSA9 IGtleWJvYXJkRW50ZXJLZXlUeXBlQXR0cmlidXRlKGVsZW1lbnQpOwogCiAgICAgaWYgKGVudGVy S2V5VHlwZSA9PSBWS0JFbnRlcktleU5vdFNldCAmJiB0eXBlICE9IElucHV0VHlwZVRleHRBcmVh KSB7CkBAIC04MjMsNyArODQ2LDcgQEAgdm9pZCBJbnB1dEhhbmRsZXI6OnNldEVsZW1lbnRGb2N1 c2VkKEVsZW1lbnQqIGVsZW1lbnQpCiAgICAgfQogCiAgICAgRm9jdXNMb2coTG9nTGV2ZWxJbmZv LCAiSW5wdXRIYW5kbGVyOjpzZXRFbGVtZW50Rm9jdXNlZCwgVHlwZT0lZCwgU3R5bGU9JWQsIEtl eWJvYXJkIFR5cGU9JWQsIEVudGVyIEtleT0lZCIsIHR5cGUsIG1fY3VycmVudEZvY3VzRWxlbWVu dFRleHRFZGl0TWFzaywga2V5Ym9hcmRUeXBlLCBlbnRlcktleVR5cGUpOwotICAgIG1fd2ViUGFn ZS0+bV9jbGllbnQtPmlucHV0Rm9jdXNHYWluZWQodHlwZSwgbV9jdXJyZW50Rm9jdXNFbGVtZW50 VGV4dEVkaXRNYXNrLCBrZXlib2FyZFR5cGUsIGVudGVyS2V5VHlwZSk7CisgICAgbV93ZWJQYWdl LT5tX2NsaWVudC0+aW5wdXRGb2N1c0dhaW5lZChtX2N1cnJlbnRGb2N1c0VsZW1lbnRUZXh0RWRp dE1hc2ssIGtleWJvYXJkVHlwZSwgZW50ZXJLZXlUeXBlKTsKIAogICAgIGhhbmRsZUlucHV0TG9j YWxlQ2hhbmdlZChtX3dlYlBhZ2UtPm1fd2ViU2V0dGluZ3MtPmlzV3JpdGluZ0RpcmVjdGlvblJU TCgpKTsKIAotLSAKMS43LjkuNQoK