99831 2012-10-19 05:10:49 -0700 [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active 2012-10-19 08:48:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs abecsi cmarcelo jturcotte menard webkit.review.bot oldest_to_newest 746228 0 kbalazs 2012-10-19 05:10:49 -0700 setRenderWithoutShowing and setRenderToOffscreenBuffer are overlapping and causing trouble, i.e. the early return in QQuickWebViewPrivate::setNeedsDisplay is wrong if the scene graph is active. 746240 1 169604 kbalazs 2012-10-19 05:35:05 -0700 Created attachment 169604 Patch 746262 2 169604 jturcotte 2012-10-19 06:30:35 -0700 Comment on attachment 169604 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169604&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:88 > - QQuickWebViewExperimental experimental(m_view); > - experimental.setRenderToOffscreenBuffer(true); > + if (!windowShapshotEnabled()) { > + QQuickWebViewExperimental experimental(m_view); > + experimental.setRenderToOffscreenBuffer(true); > + } It would be cleaner to move it in the else of "if (PlatformWebView::windowShapshotEnabled())" in handleStatusChanged. 746294 3 169618 kbalazs 2012-10-19 07:40:09 -0700 Created attachment 169618 Patch 746297 4 169618 jturcotte 2012-10-19 07:51:10 -0700 Comment on attachment 169618 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169618&action=review > Source/WebKit2/ChangeLog:8 > + Update the comment about renderToOffscreenBuffer to better describe it's role. it's -> its > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:445 > + // This can the case when running tests. See WTR::PlatformWebView::windowShapshotEnabled. I'm not sure what this line adds, there's a "be" missing, "when running tests" is repeated from above and windowShapshotEnabled is only indirectly related. 746333 5 kbalazs 2012-10-19 08:48:03 -0700 (In reply to comment #4) > (From update of attachment 169618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169618&action=review > > > Source/WebKit2/ChangeLog:8 > > + Update the comment about renderToOffscreenBuffer to better describe it's role. > > it's -> its I think both are correct, but fixed :) > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:445 > > + // This can the case when running tests. See WTR::PlatformWebView::windowShapshotEnabled. > > I'm not sure what this line adds, there's a "be" missing, "when running tests" is repeated from above and windowShapshotEnabled is only indirectly related. Removed. Landed in http://trac.webkit.org/changeset/131904 169604 2012-10-19 05:35:05 -0700 2012-10-19 07:40:05 -0700 Patch bug-99831-20121019143345.patch text/plain 3432 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDY1OWU3YTA1MTEwMmM4 ODY2Njc2NTFkZmVlYmMzZTlkOWQxN2MyYy4uNjUxMWE3ZWE2NzMxOTE1MDY1ZTM1NDJhZTZmNjQ2 MjNmMDc2N2NkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE5ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dUUl0gcmVu ZGVyVG9PZmZzY3JlZW5CdWZmZXIgc2hvdWxkIG5vdCBiZSBzZXQgaWYgdGhlIHJlYWwgcmVuZGVy IGxvb3AgaXMgYWN0aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVwZGF0ZSB0aGUgY29tbWVudCBhYm91dCByZW5kZXJUb09mZnNjcmVlbkJ1ZmZlciB0 byBiZXR0ZXIgZGVzY3JpYmUgaXQncyByb2xlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXRO ZWVkc0Rpc3BsYXkpOgorCiAyMDEyLTEwLTE5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTMxODQ0KTogSXQgYnJva2UgdGhlIGJ1 aWxkIG9uICFFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkgcGxhdGZvcm1zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCAwN2Vk ODMyY2U4MDExNGQ3ZDAxZDg1MzllMWNiODQ4YTg2ZDUwMzhjLi45YTA0MzNiNjYyZmE3ZjBhNzFh N2RiOWFkNTY2Y2E1NGM2ZDFhZjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTQ0MCw3ICs0NDAsOCBAQCB2b2lkIFFRdWlj a1dlYlZpZXdQcml2YXRlOjpzZXROZWVkc0Rpc3BsYXkoKQogewogICAgIFFfUShRUXVpY2tXZWJW aWV3KTsKICAgICBpZiAocmVuZGVyVG9PZmZzY3JlZW5CdWZmZXIoKSkgewotICAgICAgICAvLyBU T0RPOiB3ZSBjYW4gbWFpbnRhaW4gYSByZWFsIGltYWdlIGhlcmUgYW5kIHVzZSBpdCBmb3IgcGl4 ZWwgdGVzdHMuIFJpZ2h0IG5vdyB0aGlzIGlzIHVzZWQgb25seSBmb3IgcnVubmluZyB0aGUgcmVu ZGVyaW5nIGNvZGUtcGF0aCB3aGlsZSBydW5uaW5nIHRlc3RzLgorICAgICAgICAvLyBUaGlzIGlz IHVzZWQgb25seSB0byBtYW50YWluIHRoZSByZW5kZXJpbmcgc3luY2hyb25pc2F0aW9uIGJldHdl ZW4gdGhlIFVJIGFuZAorICAgICAgICAvLyB0aGUgd2ViIHByb2Nlc3Mgd2hlbiBydW5uaW5nIHRl c3RzIGV2ZW4gaWYgdGhlIHJlbmRlciBsb29wIGlzIG5vdCBhY3RpdmUuCiAgICAgICAgIFFJbWFn ZSBkdW1teUltYWdlKDEsIDEsIFFJbWFnZTo6Rm9ybWF0X0FSR0IzMik7CiAgICAgICAgIFFQYWlu dGVyIHBhaW50ZXIoJmR1bW15SW1hZ2UpOwogICAgICAgICBxLT5wYWdlKCktPmQtPnBhaW50KCZw YWludGVyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCA0ODQ5ZjEwMTc5ZTU1N2U5MGFjMTQ3ZTg1MzdhMmJmNTY5OTZlMjY1Li4xMDVkMTFmMGFh YmZkZWFiMDQ4ODA2NGNhMTkxZDZjYTZlYzcxMzVkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VM b2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMTkgIEJh bGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bV1RSXSBy ZW5kZXJUb09mZnNjcmVlbkJ1ZmZlciBzaG91bGQgbm90IGJlIHNldCBpZiB0aGUgcmVhbCByZW5k ZXIgbG9vcCBpcyBhY3RpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk5ODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG8gbm90IHNldCByZW5kZXJUb09mZnNjcmVlbkJ1ZmZlciBpZiB3ZSBoYXZlIGNh bGxlZCBzZXRSZW5kZXJXaXRob3V0U2hvd2luZy4KKyAgICAgICAgV2UgZG8gbm90IG5lZWQgaXQg aW4gdGhpcyBjYXNlIGFuZCB0aGVzZSB0aGluZ3MgYXJlIGFjdHVhbGx5IGNvbmZsaWN0aW5nLgor CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHA6Cisg ICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KToKKwogMjAxMi0x MC0xOSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBkaWdpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEzMTczNC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHAKaW5kZXggZTExZTZlNzRhZjc4YzM0YmQx N2ZlZGVmMDA1ZTExZGU2MDAyZTMxOC4uNzkxNmNiYjU0OWMzZjBmYjczZDNiZDU4OTY4NTE2YjMw ODJlMjQyZSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdl YlZpZXdRdC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZp ZXdRdC5jcHAKQEAgLTgyLDggKzgyLDEwIEBAIFBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJW aWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1BhZ2VHcm91cFJlZiBwYWdlR3JvCiAgICAg LCBtX3dpbmRvd0lzS2V5KHRydWUpCiAgICAgLCBtX21vZGFsRXZlbnRMb29wKDApCiB7Ci0gICAg UVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbCBleHBlcmltZW50YWwobV92aWV3KTsKLSAgICBleHBl cmltZW50YWwuc2V0UmVuZGVyVG9PZmZzY3JlZW5CdWZmZXIodHJ1ZSk7CisgICAgaWYgKCF3aW5k b3dTaGFwc2hvdEVuYWJsZWQoKSkgeworICAgICAgICBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFs IGV4cGVyaW1lbnRhbChtX3ZpZXcpOworICAgICAgICBleHBlcmltZW50YWwuc2V0UmVuZGVyVG9P ZmZzY3JlZW5CdWZmZXIodHJ1ZSk7CisgICAgfQogICAgIG1fdmlldy0+c2V0QWxsb3dBbnlIVFRQ U0NlcnRpZmljYXRlRm9yTG9jYWxIb3N0KHRydWUpOwogICAgIG1fdmlldy0+Y29tcG9uZW50Q29t cGxldGUoKTsKIH0K 169618 2012-10-19 07:40:09 -0700 2012-10-19 08:48:13 -0700 Patch bug-99831-20121019163848.patch text/plain 4281 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDY1OWU3YTA1MTEwMmM4 ODY2Njc2NTFkZmVlYmMzZTlkOWQxN2MyYy4uNjUxMWE3ZWE2NzMxOTE1MDY1ZTM1NDJhZTZmNjQ2 MjNmMDc2N2NkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE5ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dUUl0gcmVu ZGVyVG9PZmZzY3JlZW5CdWZmZXIgc2hvdWxkIG5vdCBiZSBzZXQgaWYgdGhlIHJlYWwgcmVuZGVy IGxvb3AgaXMgYWN0aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTgzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVwZGF0ZSB0aGUgY29tbWVudCBhYm91dCByZW5kZXJUb09mZnNjcmVlbkJ1ZmZlciB0 byBiZXR0ZXIgZGVzY3JpYmUgaXQncyByb2xlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXRO ZWVkc0Rpc3BsYXkpOgorCiAyMDEyLTEwLTE5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTMxODQ0KTogSXQgYnJva2UgdGhlIGJ1 aWxkIG9uICFFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkgcGxhdGZvcm1zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCAwN2Vk ODMyY2U4MDExNGQ3ZDAxZDg1MzllMWNiODQ4YTg2ZDUwMzhjLi4yOGZiMTAxZjc3YWM2ZWY1OWU1 ZDdkYWYyNzc3MWNkNTIzYjQyYjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTQ0MCw3ICs0NDAsOSBAQCB2b2lkIFFRdWlj a1dlYlZpZXdQcml2YXRlOjpzZXROZWVkc0Rpc3BsYXkoKQogewogICAgIFFfUShRUXVpY2tXZWJW aWV3KTsKICAgICBpZiAocmVuZGVyVG9PZmZzY3JlZW5CdWZmZXIoKSkgewotICAgICAgICAvLyBU T0RPOiB3ZSBjYW4gbWFpbnRhaW4gYSByZWFsIGltYWdlIGhlcmUgYW5kIHVzZSBpdCBmb3IgcGl4 ZWwgdGVzdHMuIFJpZ2h0IG5vdyB0aGlzIGlzIHVzZWQgb25seSBmb3IgcnVubmluZyB0aGUgcmVu ZGVyaW5nIGNvZGUtcGF0aCB3aGlsZSBydW5uaW5nIHRlc3RzLgorICAgICAgICAvLyBUaGlzIGlz IHVzZWQgb25seSB0byBtYW50YWluIHRoZSByZW5kZXJpbmcgc3luY2hyb25pc2F0aW9uIGJldHdl ZW4gdGhlIFVJIGFuZAorICAgICAgICAvLyB0aGUgd2ViIHByb2Nlc3Mgd2hlbiBydW5uaW5nIHRl c3RzIGV2ZW4gaWYgdGhlIHJlbmRlciBsb29wIGlzIG5vdCBhY3RpdmUuCisgICAgICAgIC8vIFRo aXMgY2FuIHRoZSBjYXNlIHdoZW4gcnVubmluZyB0ZXN0cy4gU2VlIFdUUjo6UGxhdGZvcm1XZWJW aWV3Ojp3aW5kb3dTaGFwc2hvdEVuYWJsZWQuCiAgICAgICAgIFFJbWFnZSBkdW1teUltYWdlKDEs IDEsIFFJbWFnZTo6Rm9ybWF0X0FSR0IzMik7CiAgICAgICAgIFFQYWludGVyIHBhaW50ZXIoJmR1 bW15SW1hZ2UpOwogICAgICAgICBxLT5wYWdlKCktPmQtPnBhaW50KCZwYWludGVyKTsKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ODQ5ZjEwMTc5 ZTU1N2U5MGFjMTQ3ZTg1MzdhMmJmNTY5OTZlMjY1Li42OGMwNmYxNWRjYzJlMDgwZmNkOTYxYTRk NmVhMzZhYzQ2MGNkM2E4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTkgIEJhbGF6cyBLZWxlbWVuICA8 a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bV1RSXSByZW5kZXJUb09mZnNjcmVl bkJ1ZmZlciBzaG91bGQgbm90IGJlIHNldCBpZiB0aGUgcmVhbCByZW5kZXIgbG9vcCBpcyBhY3Rp dmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5ODMx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90 IHNldCByZW5kZXJUb09mZnNjcmVlbkJ1ZmZlciBpZiB3ZSBoYXZlIGNhbGxlZCBzZXRSZW5kZXJX aXRob3V0U2hvd2luZy4KKyAgICAgICAgV2UgZG8gbm90IG5lZWQgaXQgaW4gdGhpcyBjYXNlIGFu ZCB0aGVzZSB0aGluZ3MgYXJlIGFjdHVhbGx5IGNvbmZsaWN0aW5nLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9xdC9QbGF0Zm9ybVdlYlZpZXdRdC5jcHA6CisgICAgICAgIChXVFI6Oldy YXBwZXJXaW5kb3c6OmhhbmRsZVN0YXR1c0NoYW5nZWQpOgorICAgICAgICAoV1RSOjpQbGF0Zm9y bVdlYlZpZXc6OlBsYXRmb3JtV2ViVmlldyk6CisgICAgICAgIChXVFI6OlBsYXRmb3JtV2ViVmll dzo6d2luZG93U2hhcHNob3RFbmFibGVkKTogQWRkZWQgYSBjb21tZW50CisgICAgICAgIGRlc2Ny aWJpbmcgd2h5IHRoaXMgd29ya2Fyb3VuZCBpcyBuZWVkZWQuCisKIDIwMTItMTAtMTkgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxMzE3MzQuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL3F0L1BsYXRmb3JtV2ViVmlld1F0LmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQv UGxhdGZvcm1XZWJWaWV3UXQuY3BwCmluZGV4IGUxMWU2ZTc0YWY3OGMzNGJkMTdmZWRlZjAwNWUx MWRlNjAwMmUzMTguLjAwMTc3ZGI4MWI1MGYxNjY0MDIyOGVhZjEzNDVjYWZhOWU1ODYzZGUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3Bw CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvUGxhdGZvcm1XZWJWaWV3UXQuY3BwCkBA IC02Niw2ICs2Niw5IEBAIHByaXZhdGUgUV9TTE9UUzoKICAgICAgICAgICAgIHNldFN1cmZhY2VU eXBlKE9wZW5HTFN1cmZhY2UpOwogICAgICAgICAgICAgY3JlYXRlKCk7CiAgICAgICAgICAgICBR UXVpY2tXaW5kb3dQcml2YXRlOjpnZXQodGhpcyktPnNldFJlbmRlcldpdGhvdXRTaG93aW5nKHRy dWUpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgUVF1aWNrV2ViVmlld0V4cGVyaW1l bnRhbCBleHBlcmltZW50YWwobV92aWV3KTsKKyAgICAgICAgICAgIGV4cGVyaW1lbnRhbC5zZXRS ZW5kZXJUb09mZnNjcmVlbkJ1ZmZlcih0cnVlKTsKICAgICAgICAgfQogCiAgICAgICAgIFFXaW5k b3dTeXN0ZW1JbnRlcmZhY2U6OmhhbmRsZVdpbmRvd0FjdGl2YXRlZCh0aGlzKTsKQEAgLTgyLDgg Kzg1LDYgQEAgUGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdlYlZpZXcoV0tDb250ZXh0UmVmIGNv bnRleHRSZWYsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm8KICAgICAsIG1fd2luZG93SXNLZXkodHJ1 ZSkKICAgICAsIG1fbW9kYWxFdmVudExvb3AoMCkKIHsKLSAgICBRUXVpY2tXZWJWaWV3RXhwZXJp bWVudGFsIGV4cGVyaW1lbnRhbChtX3ZpZXcpOwotICAgIGV4cGVyaW1lbnRhbC5zZXRSZW5kZXJU b09mZnNjcmVlbkJ1ZmZlcih0cnVlKTsKICAgICBtX3ZpZXctPnNldEFsbG93QW55SFRUUFNDZXJ0 aWZpY2F0ZUZvckxvY2FsSG9zdCh0cnVlKTsKICAgICBtX3ZpZXctPmNvbXBvbmVudENvbXBsZXRl KCk7CiB9CkBAIC0xNjQsNiArMTY1LDggQEAgV0tSZXRhaW5QdHI8V0tJbWFnZVJlZj4gUGxhdGZv cm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hvdEltYWdlKCkKIAogYm9vbCBQbGF0Zm9ybVdlYlZpZXc6 OndpbmRvd1NoYXBzaG90RW5hYmxlZCgpCiB7CisgICAgLy8gV2UgbmVlZCBhIHdheSB0byBkaXNh YmxlIFVJIHNpZGUgcmVuZGVyaW5nIGZvciB0ZXN0cyBiZWNhdXNlIGl0IGlzCisgICAgLy8gdG9v IHNsb3cgd2l0aG91dCBhcHByb3ByaWF0ZSBoYXJkd2FyZS4KICAgICBzdGF0aWMgYm9vbCByZXN1 bHQ7CiAgICAgc3RhdGljIGJvb2wgaGFzQ2hlY2tlZCA9IGZhbHNlOwogICAgIGlmICghaGFzQ2hl Y2tlZCkK