99826 2012-10-19 03:15:20 -0700 Web Inspector: Crash when adding a keyframes rule in the Styles pane 2012-10-23 08:57:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 746181 0 apavlov 2012-10-19 03:15:20 -0700 In the Styles pane, add a new CSS rule with the selector "@-webkit-keyframes shake" (unquoted). Bam! Upstreaming http://code.google.com/p/chromium/issues/detail?id=156516 746242 1 169605 apavlov 2012-10-19 05:43:10 -0700 Created attachment 169605 Patch 746246 2 169605 pfeldman 2012-10-19 05:52:28 -0700 Comment on attachment 169605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169605&action=review > Source/WebCore/inspector/InspectorStyleSheet.cpp:816 > + CSSParser p(m_pageStyleSheet->ownerDocument() ? CSSParserContext(m_pageStyleSheet->ownerDocument()) : strictCSSParserContext()); We use different parser constructors in this class. Why? Could we introduce factory methods with descriptive names? > Source/WebCore/inspector/InspectorStyleSheet.cpp:821 > + return 0; Do you want to extract this into a separate method? > Source/WebCore/inspector/InspectorStyleSheet.cpp:845 > + m_pageStyleSheet->deleteRule(lastRuleIndex, ec); You should assign exception code there. > LayoutTests/inspector/styles/styles-add-new-rule.html:59 > + function step6() Please add test per case. 746263 3 169610 apavlov 2012-10-19 06:31:13 -0700 Created attachment 169610 Patch 748687 4 169610 webkit.review.bot 2012-10-23 08:57:43 -0700 Comment on attachment 169610 Patch Clearing flags on attachment: 169610 Committed r132229: <http://trac.webkit.org/changeset/132229> 748688 5 webkit.review.bot 2012-10-23 08:57:47 -0700 All reviewed patches have been landed. Closing bug. 169605 2012-10-19 05:43:10 -0700 2012-10-19 06:31:09 -0700 Patch bug-99826-20121019164153.patch text/plain 5481 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZlN2RiNzI1YTk0ZjY2 YmY3N2Q3NDkzYTA1YzQzNjg4ODIyM2NjNy4uYTA5NTZjYmMwNTVkNDJjOGNjZGFhNmUyZjUzMmMy MTUyNjkyY2JkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTEwLTE5ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ3Jhc2ggd2hlbiBhZGRpbmcgYSBrZXlmcmFtZXMgcnVsZSBpbiB0aGUgU3R5bGVzIHBh bmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5ODI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNs aWVudC1zdXBwbGllZCBzZWxlY3RvciB0ZXh0IGlzIGZpcnN0IHBhcnNlZCB0byBtYWtlIHN1cmUg aXQgcmVzdWx0cyBpbiBhIHZhbGlkIHN0eWxlIHJ1bGUgc2VsZWN0b3IuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JTdHlsZVNoZWV0OjphZGRSdWxlKToKKworMjAxMi0xMC0xOSAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEludmFs aWQgUmVnZXggaW4gU0FTU1NvdXJjZU1hcHBpbmcvZGlkUmVxdWVzdENvbnRlbnQsIGJyZWFrcyBT dXBwb3J0IGZvciBTYXNzIGV4cGVyaW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5NzI5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAppbmRleCA5NWRhMTc3MGUyNzBkODEwZmRmN2RiZWNl YmMxZDkwZmFjYjY5NmZkLi40NmUzZTdlZDllYmFjNjhmZjI2ZmE0NGE2Y2RlOTcyNGU0YTMyYjJj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVl dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQu Y3BwCkBAIC04MTMsNiArODEzLDE0IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6c2V0UnVs ZVNlbGVjdG9yKGNvbnN0IEluc3BlY3RvckNTU0lkJiBpZCwgY29uc3QgU3RyaW5nCiAKIENTU1N0 eWxlUnVsZSogSW5zcGVjdG9yU3R5bGVTaGVldDo6YWRkUnVsZShjb25zdCBTdHJpbmcmIHNlbGVj dG9yLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKKyAgICBDU1NQYXJzZXIgcChtX3BhZ2VTdHlsZVNo ZWV0LT5vd25lckRvY3VtZW50KCkgPyBDU1NQYXJzZXJDb250ZXh0KG1fcGFnZVN0eWxlU2hlZXQt Pm93bmVyRG9jdW1lbnQoKSkgOiBzdHJpY3RDU1NQYXJzZXJDb250ZXh0KCkpOworICAgIENTU1Nl bGVjdG9yTGlzdCBzZWxlY3Rvckxpc3Q7CisgICAgcC5wYXJzZVNlbGVjdG9yKHNlbGVjdG9yLCBz ZWxlY3Rvckxpc3QpOworICAgIGlmICghc2VsZWN0b3JMaXN0LmZpcnN0KCkpIHsKKyAgICAgICAg ZWMgPSBTWU5UQVhfRVJSOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKICAgICBTdHJpbmcg dGV4dDsKICAgICBib29sIHN1Y2Nlc3MgPSBnZXRUZXh0KCZ0ZXh0KTsKICAgICBpZiAoIXN1Y2Nl c3MpIHsKQEAgLTgyNiw5ICs4MzQsMTkgQEAgQ1NTU3R5bGVSdWxlKiBJbnNwZWN0b3JTdHlsZVNo ZWV0OjphZGRSdWxlKGNvbnN0IFN0cmluZyYgc2VsZWN0b3IsIEV4Y2VwdGlvbkNvZGUKICAgICBp ZiAoZWMpCiAgICAgICAgIHJldHVybiAwOwogICAgIEFTU0VSVChtX3BhZ2VTdHlsZVNoZWV0LT5s ZW5ndGgoKSk7Ci0gICAgQ1NTU3R5bGVSdWxlKiBydWxlID0gSW5zcGVjdG9yQ1NTQWdlbnQ6OmFz Q1NTU3R5bGVSdWxlKG1fcGFnZVN0eWxlU2hlZXQtPml0ZW0obV9wYWdlU3R5bGVTaGVldC0+bGVu Z3RoKCkgLSAxKSk7CisgICAgdW5zaWduZWQgbGFzdFJ1bGVJbmRleCA9IG1fcGFnZVN0eWxlU2hl ZXQtPmxlbmd0aCgpIC0gMTsKKyAgICBDU1NSdWxlKiBydWxlID0gbV9wYWdlU3R5bGVTaGVldC0+ aXRlbShsYXN0UnVsZUluZGV4KTsKICAgICBBU1NFUlQocnVsZSk7CiAKKyAgICBDU1NTdHlsZVJ1 bGUqIHN0eWxlUnVsZSA9IEluc3BlY3RvckNTU0FnZW50Ojphc0NTU1N0eWxlUnVsZShydWxlKTsK KyAgICBpZiAoIXN0eWxlUnVsZSkgeworICAgICAgICAvLyBXaGF0IHdlIGp1c3QgYWRkZWQgaGFz IHRvIGJlIGEgQ1NTU3R5bGVSdWxlIC0gd2UgY2Fubm90IGhhbmRsZSBvdGhlciB0eXBlcyBvZiBy dWxlcyB5ZXQuCisgICAgICAgIC8vIElmIGl0IGlzIG5vdCBhIHN0eWxlIHJ1bGUsIHByZXRlbmQg d2UgbmV2ZXIgdG91Y2hlZCB0aGUgc3R5bGVzaGVldC4KKyAgICAgICAgbV9wYWdlU3R5bGVTaGVl dC0+ZGVsZXRlUnVsZShsYXN0UnVsZUluZGV4LCBlYyk7CisgICAgICAgIEFTU0VSVCghZWMpOwor ICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKICAgICBpZiAoIXN0eWxlU2hlZXRUZXh0LmlzRW1w dHkoKSkKICAgICAgICAgc3R5bGVTaGVldFRleHQuYXBwZW5kKCdcbicpOwogCkBAIC04MzksNyAr ODU3LDcgQEAgQ1NTU3R5bGVSdWxlKiBJbnNwZWN0b3JTdHlsZVNoZWV0OjphZGRSdWxlKGNvbnN0 IFN0cmluZyYgc2VsZWN0b3IsIEV4Y2VwdGlvbkNvZGUKIAogICAgIGZpcmVTdHlsZVNoZWV0Q2hh bmdlZCgpOwogCi0gICAgcmV0dXJuIHJ1bGU7CisgICAgcmV0dXJuIHN0eWxlUnVsZTsKIH0KIAog Ym9vbCBJbnNwZWN0b3JTdHlsZVNoZWV0OjpkZWxldGVSdWxlKGNvbnN0IEluc3BlY3RvckNTU0lk JiBpZCwgRXhjZXB0aW9uQ29kZSYgZWMpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTNmYjg3M2RjNDVjNjM1NjBlZjdkNWFk ZDM1ZTc2Y2UzZjkwZTkwZi4uNDVhN2M4NGRkNTdiOWY2YTFhMjU3N2IxMzM2MjZlNTk2NjI4MjI1 MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTE5ICBBbGV4YW5kZXIgUGF2bG92ICA8 YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ3Jhc2ggd2hl biBhZGRpbmcgYSBrZXlmcmFtZXMgcnVsZSBpbiB0aGUgU3R5bGVzIHBhbmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5ODI2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5bGVzL3N0 eWxlcy1hZGQtbmV3LXJ1bGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rvci9zdHls ZXMvc3R5bGVzLWFkZC1uZXctcnVsZS5odG1sOgorCiAyMDEyLTEwLTE5ICBaYW4gRG9iZXJzZWsg IDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVu aW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtYWRk LW5ldy1ydWxlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5 bGVzLWFkZC1uZXctcnVsZS1leHBlY3RlZC50eHQKaW5kZXggYjRjODk5YTQxOTFkMjM0M2Y5ZDI0 ZGJmMDgzYjA2ZDljMzg4NjA5NC4uMmM2MDczNmZmMWM0ZDM0ZjYwOGMwMmUzM2Y5YzA2NzI5ZDAx YWU5OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtYWRk LW5ldy1ydWxlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVz L3N0eWxlcy1hZGQtbmV3LXJ1bGUtZXhwZWN0ZWQudHh0CkBAIC0zMSw0ICszMSwxNyBAQCBkaXYg IHsgKHVzZXIgYWdlbnQgc3R5bGVzaGVldCkKIGRpc3BsYXk6IGJsb2NrOwogCiAKK1tleHBhbmRl ZF0gCitlbGVtZW50LnN0eWxlICB7ICgpCitjb2xvcjogcmVkOworCis9PT09PT09PSBNYXRjaGVk IENTUyBSdWxlcyA9PT09PT09PQorW2V4cGFuZGVkXSAKKyNvdGhlciAgeyAoaW5zcGVjdG9yLXN0 eWxlc2hlZXQ6MSkKKworW2V4cGFuZGVkXSAKK2RpdiAgeyAodXNlciBhZ2VudCBzdHlsZXNoZWV0 KQorZGlzcGxheTogYmxvY2s7CisKKwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0 b3Ivc3R5bGVzL3N0eWxlcy1hZGQtbmV3LXJ1bGUuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9zdHlsZXMvc3R5bGVzLWFkZC1uZXctcnVsZS5odG1sCmluZGV4IGY2YzBjNDFkN2M0ZjMwZDYw OWU5ODg5NmNlNWUyZmU0OTIwNjYyYjkuLjczOWZkMTY0Y2FjZDMxMTRhNWJmM2FkZmMyYzdiOTYx NDRjNjg4ODMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5bGVz LWFkZC1uZXctcnVsZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5 bGVzLWFkZC1uZXctcnVsZS5odG1sCkBAIC01Myw2ICs1MywyMiBAQCBmdW5jdGlvbiB0ZXN0KCkK ICAgICB7CiAgICAgICAgIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0KCJBZnRlciBhZGRpbmcgbmV3 IHJ1bGUgKG90aGVyKToiKTsKICAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wU2VsZWN0ZWRFbGVt ZW50U3R5bGVzKHRydWUsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5ydW5B ZnRlclBlbmRpbmdEaXNwYXRjaGVzKHN0ZXA2KTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBzdGVw NigpCisgICAgeworICAgICAgICAvLyBDbGljayAiQWRkIG5ldyBydWxlIi4KKyAgICAgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImFkZC1zdHlsZS1idXR0b24tdGVzdC1pZCIpLmNsaWNrKCk7 CisgICAgICAgIHZhciBzZWN0aW9uID0gV2ViSW5zcGVjdG9yLnBhbmVscy5lbGVtZW50cy5zaWRl YmFyUGFuZXMuc3R5bGVzLnNlY3Rpb25zWzBdWzJdOworICAgICAgICBzZWN0aW9uLl9zZWxlY3Rv ckVsZW1lbnQudGV4dENvbnRlbnQgPSAiQC13ZWJraXQta2V5ZnJhbWVzIHNoYWtlIjsKKyAgICAg ICAgc2VjdGlvbi5fc2VsZWN0b3JFbGVtZW50LmRpc3BhdGNoRXZlbnQoSW5zcGVjdG9yVGVzdC5j cmVhdGVLZXlFdmVudCgiRW50ZXIiKSk7CisgICAgICAgIEluc3BlY3RvclRlc3QucnVuQWZ0ZXJQ ZW5kaW5nRGlzcGF0Y2hlcyhzdGVwNyk7CisgICAgfQorCisgICAgZnVuY3Rpb24gc3RlcDcoKQor ICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wU2VsZWN0ZWRFbGVtZW50U3R5bGVzKHRy dWUsIGZhbHNlLCB0cnVlKTsKICAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsK ICAgICB9CiAK 169610 2012-10-19 06:31:13 -0700 2012-10-23 08:57:43 -0700 Patch bug-99826-20121019172957.patch text/plain 9295 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZlN2RiNzI1YTk0ZjY2 YmY3N2Q3NDkzYTA1YzQzNjg4ODIyM2NjNy4uNTllOWY2OTViNWE1Y2ZlOTBkYzQwMDQxZWE0NmI2 YTc3ZjJmYjY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTEwLTE5ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ3Jhc2ggd2hlbiBhZGRpbmcgYSBrZXlmcmFtZXMgcnVsZSBpbiB0aGUgU3R5bGVzIHBh bmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5ODI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNs aWVudC1zdXBwbGllZCBzZWxlY3RvciB0ZXh0IGlzIGZpcnN0IHBhcnNlZCB0byBtYWtlIHN1cmUg aXQgcmVzdWx0cyBpbiBhIHZhbGlkIHN0eWxlIHJ1bGUgc2VsZWN0b3IuCisKKyAgICAgICAgVGVz dDogaW5zcGVjdG9yL3N0eWxlcy9hZGQtbmV3LXJ1bGUtaW52YWxpZC1zZWxlY3Rvci5odG1sCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVDU1NQYXJzZXIpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JTdHlsZTo6c2V0UHJvcGVydHlUZXh0KToKKyAgICAgICAgKFdlYkNv cmU6OmNoZWNrU3R5bGVSdWxlU2VsZWN0b3IpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y U3R5bGVTaGVldDo6YWRkUnVsZSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTdHlsZVNo ZWV0OjplbnN1cmVTb3VyY2VEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclN0eWxl U2hlZXRGb3JJbmxpbmVTdHlsZTo6Z2V0U3R5bGVBdHRyaWJ1dGVSYW5nZXMpOgorCisyMDEyLTEw LTE5ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogSW52YWxpZCBSZWdleCBpbiBTQVNTU291cmNlTWFwcGluZy9kaWRSZXF1 ZXN0Q29udGVudCwgYnJlYWtzIFN1cHBvcnQgZm9yIFNhc3MgZXhwZXJpbWVudAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk3MjkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCmluZGV4IDk1ZGEx NzcwZTI3MGQ4MTBmZGY3ZGJlY2ViYzFkOTBmYWNiNjk2ZmQuLmFmMWVjOGJmZTYwZDZjYzgwNjE4 ZWM2N2ZiOWNiMzkwMDczODE1ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKQEAgLTI2Niw2ICsyNjYsMTEgQEAgc3RhdGljIHZvaWQg ZmlsbE1lZGlhTGlzdENoYWluKENTU1J1bGUqIHJ1bGUsIEFycmF5PFR5cGVCdWlsZGVyOjpDU1M6 OkNTU01lZGlhPioKICAgICB9CiB9CiAKK3N0YXRpYyBQYXNzT3duUHRyPENTU1BhcnNlcj4gY3Jl YXRlQ1NTUGFyc2VyKERvY3VtZW50KiBkb2N1bWVudCkKK3sKKyAgICByZXR1cm4gYWRvcHRQdHIo bmV3IENTU1BhcnNlcihkb2N1bWVudCA/IENTU1BhcnNlckNvbnRleHQoZG9jdW1lbnQpIDogc3Ry aWN0Q1NTUGFyc2VyQ29udGV4dCgpKSk7Cit9CisKIFBhc3NSZWZQdHI8SW5zcGVjdG9yU3R5bGU+ IEluc3BlY3RvclN0eWxlOjpjcmVhdGUoY29uc3QgSW5zcGVjdG9yQ1NTSWQmIHN0eWxlSWQsIFBh c3NSZWZQdHI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4gc3R5bGUsIEluc3BlY3RvclN0eWxlU2hlZXQq IHBhcmVudFN0eWxlU2hlZXQpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBJbnNwZWN0b3JT dHlsZShzdHlsZUlkLCBzdHlsZSwgcGFyZW50U3R5bGVTaGVldCkpOwpAQCAtMzM5LDggKzM0NCw4 IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGU6OnNldFByb3BlcnR5VGV4dCh1bnNpZ25lZCBpbmRleCwg Y29uc3QgU3RyaW5nJiBwcm9wZXJ0eVRleHQsCiAgICAgaWYgKHByb3BlcnR5VGV4dC5zdHJpcFdo aXRlU3BhY2UoKS5sZW5ndGgoKSkgewogICAgICAgICBSZWZQdHI8U3R5bGVQcm9wZXJ0eVNldD4g dGVtcE11dGFibGVTdHlsZSA9IFN0eWxlUHJvcGVydHlTZXQ6OmNyZWF0ZSgpOwogICAgICAgICBS ZWZQdHI8Q1NTUnVsZVNvdXJjZURhdGE+IHNvdXJjZURhdGEgPSBDU1NSdWxlU291cmNlRGF0YTo6 Y3JlYXRlKENTU1J1bGVTb3VyY2VEYXRhOjpTVFlMRV9SVUxFKTsKLSAgICAgICAgQ1NTUGFyc2Vy IHAoQ1NTU3RyaWN0TW9kZSk7Ci0gICAgICAgIHAucGFyc2VEZWNsYXJhdGlvbih0ZW1wTXV0YWJs ZVN0eWxlLmdldCgpLCBwcm9wZXJ0eVRleHQgKyAiICIgKyBib2d1c1Byb3BlcnR5TmFtZSArICI6 IG5vbmUiLCBzb3VyY2VEYXRhLCBtX3N0eWxlLT5wYXJlbnRTdHlsZVNoZWV0KCktPmNvbnRlbnRz KCkpOworICAgICAgICBEb2N1bWVudCogb3duZXJEb2N1bWVudCA9IG1fcGFyZW50U3R5bGVTaGVl dC0+cGFnZVN0eWxlU2hlZXQoKSA/IG1fcGFyZW50U3R5bGVTaGVldC0+cGFnZVN0eWxlU2hlZXQo KS0+b3duZXJEb2N1bWVudCgpIDogMDsKKyAgICAgICAgY3JlYXRlQ1NTUGFyc2VyKG93bmVyRG9j dW1lbnQpLT5wYXJzZURlY2xhcmF0aW9uKHRlbXBNdXRhYmxlU3R5bGUuZ2V0KCksIHByb3BlcnR5 VGV4dCArICIgIiArIGJvZ3VzUHJvcGVydHlOYW1lICsgIjogbm9uZSIsIHNvdXJjZURhdGEsIG1f c3R5bGUtPnBhcmVudFN0eWxlU2hlZXQoKS0+Y29udGVudHMoKSk7CiAgICAgICAgIFZlY3RvcjxD U1NQcm9wZXJ0eVNvdXJjZURhdGE+JiBwcm9wZXJ0eURhdGEgPSBzb3VyY2VEYXRhLT5zdHlsZVNv dXJjZURhdGEtPnByb3BlcnR5RGF0YTsKICAgICAgICAgdW5zaWduZWQgcHJvcGVydHlDb3VudCA9 IHByb3BlcnR5RGF0YS5zaXplKCk7CiAKQEAgLTgxMSw4ICs4MTYsMjAgQEAgYm9vbCBJbnNwZWN0 b3JTdHlsZVNoZWV0OjpzZXRSdWxlU2VsZWN0b3IoY29uc3QgSW5zcGVjdG9yQ1NTSWQmIGlkLCBj b25zdCBTdHJpbmcKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorc3RhdGljIGJvb2wgY2hlY2tTdHls ZVJ1bGVTZWxlY3RvcihEb2N1bWVudCogZG9jdW1lbnQsIGNvbnN0IFN0cmluZyYgc2VsZWN0b3Ip Cit7CisgICAgQ1NTU2VsZWN0b3JMaXN0IHNlbGVjdG9yTGlzdDsKKyAgICBjcmVhdGVDU1NQYXJz ZXIoZG9jdW1lbnQpLT5wYXJzZVNlbGVjdG9yKHNlbGVjdG9yLCBzZWxlY3Rvckxpc3QpOworICAg IHJldHVybiBzZWxlY3Rvckxpc3QuZmlyc3QoKTsKK30KKwogQ1NTU3R5bGVSdWxlKiBJbnNwZWN0 b3JTdHlsZVNoZWV0OjphZGRSdWxlKGNvbnN0IFN0cmluZyYgc2VsZWN0b3IsIEV4Y2VwdGlvbkNv ZGUmIGVjKQogeworICAgIGlmICghY2hlY2tTdHlsZVJ1bGVTZWxlY3RvcihtX3BhZ2VTdHlsZVNo ZWV0LT5vd25lckRvY3VtZW50KCksIHNlbGVjdG9yKSkgeworICAgICAgICBlYyA9IFNZTlRBWF9F UlI7CisgICAgICAgIHJldHVybiAwOworICAgIH0KKwogICAgIFN0cmluZyB0ZXh0OwogICAgIGJv b2wgc3VjY2VzcyA9IGdldFRleHQoJnRleHQpOwogICAgIGlmICghc3VjY2VzcykgewpAQCAtODI2 LDkgKzg0MywyMCBAQCBDU1NTdHlsZVJ1bGUqIEluc3BlY3RvclN0eWxlU2hlZXQ6OmFkZFJ1bGUo Y29uc3QgU3RyaW5nJiBzZWxlY3RvciwgRXhjZXB0aW9uQ29kZQogICAgIGlmIChlYykKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgQVNTRVJUKG1fcGFnZVN0eWxlU2hlZXQtPmxlbmd0aCgpKTsKLSAg ICBDU1NTdHlsZVJ1bGUqIHJ1bGUgPSBJbnNwZWN0b3JDU1NBZ2VudDo6YXNDU1NTdHlsZVJ1bGUo bV9wYWdlU3R5bGVTaGVldC0+aXRlbShtX3BhZ2VTdHlsZVNoZWV0LT5sZW5ndGgoKSAtIDEpKTsK KyAgICB1bnNpZ25lZCBsYXN0UnVsZUluZGV4ID0gbV9wYWdlU3R5bGVTaGVldC0+bGVuZ3RoKCkg LSAxOworICAgIENTU1J1bGUqIHJ1bGUgPSBtX3BhZ2VTdHlsZVNoZWV0LT5pdGVtKGxhc3RSdWxl SW5kZXgpOwogICAgIEFTU0VSVChydWxlKTsKIAorICAgIENTU1N0eWxlUnVsZSogc3R5bGVSdWxl ID0gSW5zcGVjdG9yQ1NTQWdlbnQ6OmFzQ1NTU3R5bGVSdWxlKHJ1bGUpOworICAgIGlmICghc3R5 bGVSdWxlKSB7CisgICAgICAgIC8vIFdoYXQgd2UganVzdCBhZGRlZCBoYXMgdG8gYmUgYSBDU1NT dHlsZVJ1bGUgLSB3ZSBjYW5ub3QgaGFuZGxlIG90aGVyIHR5cGVzIG9mIHJ1bGVzIHlldC4KKyAg ICAgICAgLy8gSWYgaXQgaXMgbm90IGEgc3R5bGUgcnVsZSwgcHJldGVuZCB3ZSBuZXZlciB0b3Vj aGVkIHRoZSBzdHlsZXNoZWV0LgorICAgICAgICBtX3BhZ2VTdHlsZVNoZWV0LT5kZWxldGVSdWxl KGxhc3RSdWxlSW5kZXgsIGVjKTsKKyAgICAgICAgQVNTRVJUKCFlYyk7CisgICAgICAgIGVjID0g U1lOVEFYX0VSUjsKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQorCiAgICAgaWYgKCFzdHlsZVNo ZWV0VGV4dC5pc0VtcHR5KCkpCiAgICAgICAgIHN0eWxlU2hlZXRUZXh0LmFwcGVuZCgnXG4nKTsK IApAQCAtODM5LDcgKzg2Nyw3IEBAIENTU1N0eWxlUnVsZSogSW5zcGVjdG9yU3R5bGVTaGVldDo6 YWRkUnVsZShjb25zdCBTdHJpbmcmIHNlbGVjdG9yLCBFeGNlcHRpb25Db2RlCiAKICAgICBmaXJl U3R5bGVTaGVldENoYW5nZWQoKTsKIAotICAgIHJldHVybiBydWxlOworICAgIHJldHVybiBzdHls ZVJ1bGU7CiB9CiAKIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6ZGVsZXRlUnVsZShjb25zdCBJ bnNwZWN0b3JDU1NJZCYgaWQsIEV4Y2VwdGlvbkNvZGUmIGVjKQpAQCAtMTE0MiwxMCArMTE3MCw4 IEBAIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6ZW5zdXJlU291cmNlRGF0YSgpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAogICAgIFJlZlB0cjxTdHlsZVNoZWV0Q29udGVudHM+IG5ld1N0eWxl U2hlZXQgPSBTdHlsZVNoZWV0Q29udGVudHM6OmNyZWF0ZSgpOwotICAgIERvY3VtZW50KiBvd25l ckRvY3VtZW50ID0gbV9wYWdlU3R5bGVTaGVldC0+b3duZXJEb2N1bWVudCgpOwotICAgIENTU1Bh cnNlciBwKG93bmVyRG9jdW1lbnQgPyAgQ1NTUGFyc2VyQ29udGV4dChvd25lckRvY3VtZW50KSA6 IHN0cmljdENTU1BhcnNlckNvbnRleHQoKSk7CiAgICAgT3duUHRyPFJ1bGVTb3VyY2VEYXRhTGlz dD4gcnVsZVNvdXJjZURhdGFSZXN1bHQgPSBhZG9wdFB0cihuZXcgUnVsZVNvdXJjZURhdGFMaXN0 KCkpOwotICAgIHAucGFyc2VTaGVldChuZXdTdHlsZVNoZWV0LmdldCgpLCBtX3BhcnNlZFN0eWxl U2hlZXQtPnRleHQoKSwgMCwgcnVsZVNvdXJjZURhdGFSZXN1bHQuZ2V0KCkpOworICAgIGNyZWF0 ZUNTU1BhcnNlcihtX3BhZ2VTdHlsZVNoZWV0LT5vd25lckRvY3VtZW50KCkpLT5wYXJzZVNoZWV0 KG5ld1N0eWxlU2hlZXQuZ2V0KCksIG1fcGFyc2VkU3R5bGVTaGVldC0+dGV4dCgpLCAwLCBydWxl U291cmNlRGF0YVJlc3VsdC5nZXQoKSk7CiAgICAgbV9wYXJzZWRTdHlsZVNoZWV0LT5zZXRTb3Vy Y2VEYXRhKHJ1bGVTb3VyY2VEYXRhUmVzdWx0LnJlbGVhc2UoKSk7CiAgICAgcmV0dXJuIG1fcGFy c2VkU3R5bGVTaGVldC0+aGFzU291cmNlRGF0YSgpOwogfQpAQCAtMTQwOCw4ICsxNDM0LDcgQEAg Ym9vbCBJbnNwZWN0b3JTdHlsZVNoZWV0Rm9ySW5saW5lU3R5bGU6OmdldFN0eWxlQXR0cmlidXRl UmFuZ2VzKENTU1J1bGVTb3VyY2VEYXQKICAgICB9CiAKICAgICBSZWZQdHI8U3R5bGVQcm9wZXJ0 eVNldD4gdGVtcERlY2xhcmF0aW9uID0gU3R5bGVQcm9wZXJ0eVNldDo6Y3JlYXRlKCk7Ci0gICAg Q1NTUGFyc2VyIHAobV9lbGVtZW50LT5kb2N1bWVudCgpKTsKLSAgICBwLnBhcnNlRGVjbGFyYXRp b24odGVtcERlY2xhcmF0aW9uLmdldCgpLCBtX3N0eWxlVGV4dCwgcmVzdWx0LCBtX2VsZW1lbnQt PmRvY3VtZW50KCktPmVsZW1lbnRTaGVldCgpLT5jb250ZW50cygpKTsKKyAgICBjcmVhdGVDU1NQ YXJzZXIobV9lbGVtZW50LT5kb2N1bWVudCgpKS0+cGFyc2VEZWNsYXJhdGlvbih0ZW1wRGVjbGFy YXRpb24uZ2V0KCksIG1fc3R5bGVUZXh0LCByZXN1bHQsIG1fZWxlbWVudC0+ZG9jdW1lbnQoKS0+ ZWxlbWVudFNoZWV0KCktPmNvbnRlbnRzKCkpOwogICAgIHJldHVybiB0cnVlOwogfQogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggNTNmYjg3M2RjNDVjNjM1NjBlZjdkNWFkZDM1ZTc2Y2UzZjkwZTkwZi4uMjVlMzc3YTI0ZmY2 OTQ4NTRmZjk1NDNlNGFiMjA1Y2ZkZTNmNTk4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEy LTEwLTE5ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgV2ViIEluc3BlY3RvcjogQ3Jhc2ggd2hlbiBhZGRpbmcgYSBrZXlmcmFtZXMgcnVsZSBpbiB0 aGUgU3R5bGVzIHBhbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk5ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3Ivc3R5bGVzL2FkZC1uZXctcnVsZS1pbnZhbGlkLXNlbGVjdG9yLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL3N0eWxlcy9hZGQtbmV3LXJ1 bGUtaW52YWxpZC1zZWxlY3Rvci5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0xOSAgWmFuIERvYmVy c2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdh cmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvYWRkLW5l dy1ydWxlLWludmFsaWQtc2VsZWN0b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL3N0eWxlcy9hZGQtbmV3LXJ1bGUtaW52YWxpZC1zZWxlY3Rvci1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNGY3MjMxZmVmNzJkYjkxMTY5MTdmYjgyOWQ2YTljZTI4ZTJlNjI3YgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvYWRkLW5ldy1ydWxlLWlu dmFsaWQtc2VsZWN0b3ItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcgQEAKK1Rlc3RzIHRoYXQg YWRkaW5nIGEgbmV3IHJ1bGUgd2l0aCBpbnZhbGlkIHNlbGVjdG9yIHdvcmtzIGFzIGV4cGVjdGVk LgorCitUZXh0CisKK1J1bm5pbmc6IGluaXQKKworUnVubmluZzoga2V5ZnJhbWVzUnVsZVNlbGVj dG9yCitbZXhwYW5kZWRdIAorZWxlbWVudC5zdHlsZSAgeyAoKQorCis9PT09PT09PSBNYXRjaGVk IENTUyBSdWxlcyA9PT09PT09PQorW2V4cGFuZGVkXSAKK2RpdiAgeyAodXNlciBhZ2VudCBzdHls ZXNoZWV0KQorZGlzcGxheTogYmxvY2s7CisKKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3Ivc3R5bGVzL2FkZC1uZXctcnVsZS1pbnZhbGlkLXNlbGVjdG9yLmh0bWwgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL2FkZC1uZXctcnVsZS1pbnZhbGlkLXNlbGVjdG9yLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMTUwMTQ2MTJkYzliNmEyZGExMjQ4ZjU3ZTUyN2QzYjc3NTEyNTEwNQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvYWRkLW5ldy1y dWxlLWludmFsaWQtc2VsZWN0b3IuaHRtbApAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10ZXN0 LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9l bGVtZW50cy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIHRlc3QoKQor eworICAgIEluc3BlY3RvclRlc3QucnVuVGVzdFN1aXRlKFsKKyAgICAgICAgZnVuY3Rpb24gaW5p dChuZXh0KQorICAgICAgICB7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd1BhbmVsKCJl bGVtZW50cyIpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5zZWxlY3ROb2RlQW5kV2FpdEZv clN0eWxlcygiaW5zcGVjdGVkIiwgbmV4dCk7CisgICAgICAgIH0sCisKKyAgICAgICAgZnVuY3Rp b24ga2V5ZnJhbWVzUnVsZVNlbGVjdG9yKG5leHQpCisgICAgICAgIHsKKyAgICAgICAgICAgIC8v IENsaWNrICJBZGQgbmV3IHJ1bGUiLgorICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImFkZC1zdHlsZS1idXR0b24tdGVzdC1pZCIpLmNsaWNrKCk7CisgICAgICAgICAgICB2YXIg c2VjdGlvbiA9IFdlYkluc3BlY3Rvci5wYW5lbHMuZWxlbWVudHMuc2lkZWJhclBhbmVzLnN0eWxl cy5zZWN0aW9uc1swXVsyXTsKKyAgICAgICAgICAgIHNlY3Rpb24uX3NlbGVjdG9yRWxlbWVudC50 ZXh0Q29udGVudCA9ICJALXdlYmtpdC1rZXlmcmFtZXMgc2hha2UiOworICAgICAgICAgICAgc2Vj dGlvbi5fc2VsZWN0b3JFbGVtZW50LmRpc3BhdGNoRXZlbnQoSW5zcGVjdG9yVGVzdC5jcmVhdGVL ZXlFdmVudCgiRW50ZXIiKSk7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnJ1bkFmdGVyUGVu ZGluZ0Rpc3BhdGNoZXMoY2FsbGJhY2spOworCisgICAgICAgICAgICBmdW5jdGlvbiBjYWxsYmFj aygpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wU2Vs ZWN0ZWRFbGVtZW50U3R5bGVzKHRydWUsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBu ZXh0KCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICBdKTsKK30KKworPC9zY3JpcHQ+ Cis8L2hlYWQ+CisKKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgorVGVzdHMgdGhhdCBh ZGRpbmcgYSBuZXcgcnVsZSB3aXRoIGludmFsaWQgc2VsZWN0b3Igd29ya3MgYXMgZXhwZWN0ZWQu Cis8L3A+CisKKzxkaXYgaWQ9Imluc3BlY3RlZCI+VGV4dDwvZGl2PgorCis8L2JvZHk+Cis8L2h0 bWw+Cg==