99824 2012-10-19 02:52:44 -0700 REGRESSION (r131836): failures in list styles tests on EFL, GTK 2012-10-25 11:41:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 1 zan msaboff benjamin ggaren msaboff naginenis webkit.review.bot oldest_to_newest 746173 0 zan 2012-10-19 02:52:44 -0700 The following 3 tests started failing on GTK and EFL after r131836 landed: fast/lists/w3-css3-list-styles-alphabetic.html fast/lists/w3-css3-list-styles-fallback-style.html fast/lists/w3-list-styles.html http://trac.webkit.org/changeset/131836 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Flists%2Fw3 The tests pass without a problem in WebKit2 on both GTK and EFL. I'd say there's something in the WebKit layer that both ports fail to do. 746366 1 169635 msaboff 2012-10-19 09:28:07 -0700 Created attachment 169635 Speculative fix to test failures Could one of the GTK and/or EFL platform people check to see if this patch addresses the test failures? 746499 2 zan 2012-10-19 11:44:23 -0700 (In reply to comment #1) > Created an attachment (id=169635) [details] > Speculative fix to test failures > > Could one of the GTK and/or EFL platform people check to see if this patch addresses the test failures? No, the failures are still there. GTK (and I think EFL as well) uses the ICU Unicode backend by default. 748986 3 170235 msaboff 2012-10-23 14:31:19 -0700 Created attachment 170235 Updated Speculative Fix Zan, can you try out this patch? 749417 4 zan 2012-10-24 00:09:39 -0700 (In reply to comment #3) > Created an attachment (id=170235) [details] > Updated Speculative Fix > > Zan, can you try out this patch? This patch works, the tests pass. 749523 5 zan 2012-10-24 04:16:45 -0700 (In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=170235) [details] [details] > > Updated Speculative Fix > > > > Zan, can you try out this patch? > > This patch works, the tests pass. Testing it a bit further, no other regressions occurred, so I think the patch is good for review. 751062 6 170235 webkit.review.bot 2012-10-25 11:41:07 -0700 Comment on attachment 170235 Updated Speculative Fix Clearing flags on attachment: 170235 Committed r132507: <http://trac.webkit.org/changeset/132507> 751063 7 webkit.review.bot 2012-10-25 11:41:11 -0700 All reviewed patches have been landed. Closing bug. 169635 2012-10-19 09:28:07 -0700 2012-10-23 14:31:19 -0700 Speculative fix to test failures 99824.patch text/plain 1613 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzE5MDQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMzE4MzYpOiBmYWlsdXJl cyBpbiBsaXN0IHN0eWxlcyB0ZXN0cyBvbiBFRkwsIEdUSworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBwbGFjZWhvbGRlciBhcmd1bWVudCBmb3Ig bmV3IGFyZ3VtZW50IGFkZGVkIHRvIGNvbnZlcnRVVEY4VG9VVEYxNigpIGluIGh0dHA6Ly90cmFj LndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMTgzNi4KKworICAgICAgICAqIHd0Zi91bmljb2RlL2ds aWIvVW5pY29kZUdMaWIuY3BwOgorICAgICAgICAoV1RGOjpVbmljb2RlOjpjb252ZXJ0Q2FzZSk6 CisKIDIwMTItMTAtMTkgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIGJ1aWxkZml4LCB1c2UgQy1zdHlsZSBjb21tZW50IGluc3RlYWQg b2YgQysrCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL2dsaWIvVW5pY29kZUdMaWIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvZ2xpYi9Vbmljb2RlR0xpYi5j cHAJKHJldmlzaW9uIDEzMTgzNikKKysrIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvZ2xpYi9Vbmlj b2RlR0xpYi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDggQEAgc3RhdGljIGludCBj b252ZXJ0Q2FzZShVQ2hhciogcmVzdWx0LCBpbgogICAgIC8vIENvbnZlcnQgdGhlIHJlc3VsdCB0 byBVVEYtMTYuCiAgICAgVUNoYXIqIHV0ZjE2VGFyZ2V0ID0gcmVzdWx0OwogICAgIGNvbnN0IGNo YXIqIHV0ZjhTb3VyY2UgPSB1dGY4UmVzdWx0LmdldCgpOwotICAgIGNvbnZlcnNpb25SZXN1bHQg PSBjb252ZXJ0VVRGOFRvVVRGMTYoJnV0ZjhTb3VyY2UsIHV0ZjhTb3VyY2UgKyB1dGY4UmVzdWx0 TGVuZ3RoLCAmdXRmMTZUYXJnZXQsIHV0ZjE2VGFyZ2V0ICsgcmVzdWx0TGVuZ3RoLCB0cnVlKTsK KyAgICBib29sIHVudXNlZElTQWxsQVNDSUk7CisgICAgY29udmVyc2lvblJlc3VsdCA9IGNvbnZl cnRVVEY4VG9VVEYxNigmdXRmOFNvdXJjZSwgdXRmOFNvdXJjZSArIHV0ZjhSZXN1bHRMZW5ndGgs ICZ1dGYxNlRhcmdldCwgdXRmMTZUYXJnZXQgKyByZXN1bHRMZW5ndGgsICZ1bnVzZWRJc0FsbEFT Q0lJLCB0cnVlKTsKICAgICBsb25nIHV0ZjE2UmVzdWx0TGVuZ3RoID0gdXRmMTZUYXJnZXQgLSBy ZXN1bHQ7CiAgICAgaWYgKGNvbnZlcnNpb25SZXN1bHQgIT0gY29udmVyc2lvbk9LKQogICAgICAg ICAqZXJyb3IgPSB0cnVlOwo= 170235 2012-10-23 14:31:19 -0700 2012-10-25 11:41:07 -0700 Updated Speculative Fix 99824-2.patch text/plain 3899 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMyMjYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTIzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIxMzE4MzYpOiBmYWlsdXJlcyBpbiBsaXN0IHN0eWxlcyB0ZXN0cyBv biBFRkwsIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTk4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTYXZlZCBzdGFydCBvZiBzdHJpbmcgc2luY2UgaXQgaXMgbW9kaWZpZWQgYnkgY2FsbCBjb252 ZXJ0VVRGOFRvVVRGMTYoKS4KKworICAgICAgICAqIEFQSS9KU1N0cmluZ1JlZi5jcHA6CisgICAg ICAgIChKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyk6CisKIDIwMTItMTAtMjMgIENocmlz dG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBSZWdy ZXNzaW9uKHIxMzIxNDMpOiBBc3NlcnRpb24gaGl0IGluIEpTQzo6SW50ZXJwcmV0ZXI6OlN0YWNr UG9saWN5OjpTdGFja1BvbGljeShKU0M6OkludGVycHJldGVyJiwgY29uc3QgV1RGOjpTdGFja0Jv dW5kcyYpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU3RyaW5nUmVmLmNwcAko cmV2aXNpb24gMTMyMTY1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1Jl Zi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDkgKzQ3LDEwIEBAIEpTU3RyaW5nUmVmIEpTU3Ry aW5nQ3JlYXRlV2l0aFVURjhDU3RyaW4KICAgICAgICAgVmVjdG9yPFVDaGFyLCAxMDI0PiBidWZm ZXIobGVuZ3RoKTsKICAgICAgICAgVUNoYXIqIHAgPSBidWZmZXIuZGF0YSgpOwogICAgICAgICBi b29sIHNvdXJjZUlzQWxsQVNDSUk7CisgICAgICAgIGNvbnN0IExDaGFyKiBzdHJpbmdTdGFydCA9 IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihzdHJpbmcpOwogICAgICAgICBpZiAoY29u dmVyc2lvbk9LID09IGNvbnZlcnRVVEY4VG9VVEYxNigmc3RyaW5nLCBzdHJpbmcgKyBsZW5ndGgs ICZwLCBwICsgbGVuZ3RoLCAmc291cmNlSXNBbGxBU0NJSSkpIHsKICAgICAgICAgICAgIGlmIChz b3VyY2VJc0FsbEFTQ0lJKQotICAgICAgICAgICAgICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6 Y3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTENoYXIqPihzdHJpbmcpLCBsZW5ndGgpLmxl YWtSZWYoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gT3BhcXVlSlNTdHJpbmc6OmNyZWF0ZShz dHJpbmdTdGFydCwgbGVuZ3RoKS5sZWFrUmVmKCk7CiAgICAgICAgICAgICByZXR1cm4gT3BhcXVl SlNTdHJpbmc6OmNyZWF0ZShidWZmZXIuZGF0YSgpLCBwIC0gYnVmZmVyLmRhdGEoKSkubGVha1Jl ZigpOwogICAgICAgICB9CiAgICAgfQpJbmRleDogU291cmNlL1dURi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjI2MCkKKysrIFNvdXJj ZS9XVEYvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMTAt MjMgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVT U0lPTiAocjEzMTgzNik6IGZhaWx1cmVzIGluIGxpc3Qgc3R5bGVzIHRlc3RzIG9uIEVGTCwgR1RL CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTgyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIEFT Q0lJIGNoZWNrLgorICAgICAgICBBZGRlZCBwbGFjZWhvbGRlciBhcmd1bWVudCBmb3IgbmV3IGFy Z3VtZW50IGFkZGVkIHRvIGNvbnZlcnRVVEY4VG9VVEYxNigpIGluIGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzEzMTgzNi4KKworICAgICAgICAqIHd0Zi91bmljb2RlL1VURjguY3Bw OgorICAgICAgICAoV1RGOjpVbmljb2RlOjpjb252ZXJ0VVRGOFRvVVRGMTYpOgorICAgICAgICAq IHd0Zi91bmljb2RlL2dsaWIvVW5pY29kZUdMaWIuY3BwOgorICAgICAgICAoV1RGOjpVbmljb2Rl Ojpjb252ZXJ0Q2FzZSk6CisKIDIwMTItMTAtMjIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMTMxNjU1KTogQ3Jhc2ggaW4gU3RyaW5n SW1wbDo6ZmluZElnbm9yaW5nQ2FzZQpJbmRleDogU291cmNlL1dURi93dGYvdW5pY29kZS9VVEY4 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL1VURjguY3BwCShyZXZp c2lvbiAxMzIxNjUpCisrKyBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL1VURjguY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNjMsNyArMzYzLDcgQEAgQ29udmVyc2lvblJlc3VsdCBjb252ZXJ0VVRGOFRv VVRGMTYoCiAgICAgKnRhcmdldFN0YXJ0ID0gdGFyZ2V0OwogCiAgICAgaWYgKHNvdXJjZUFsbEFT Q0lJKQotICAgICAgICAqc291cmNlQWxsQVNDSUkgPSAhKG9yQWxsRGF0YSAmIDB4N2YpOworICAg ICAgICAqc291cmNlQWxsQVNDSUkgPSAhKG9yQWxsRGF0YSAmIH4weDdmKTsKIAogICAgIHJldHVy biByZXN1bHQ7CiB9CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi91bmljb2RlL2dsaWIvVW5pY29kZUdM aWIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvZ2xpYi9Vbmljb2Rl R0xpYi5jcHAJKHJldmlzaW9uIDEzMjE2NSkKKysrIFNvdXJjZS9XVEYvd3RmL3VuaWNvZGUvZ2xp Yi9Vbmljb2RlR0xpYi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDggQEAgc3RhdGlj IGludCBjb252ZXJ0Q2FzZShVQ2hhciogcmVzdWx0LCBpbgogICAgIC8vIENvbnZlcnQgdGhlIHJl c3VsdCB0byBVVEYtMTYuCiAgICAgVUNoYXIqIHV0ZjE2VGFyZ2V0ID0gcmVzdWx0OwogICAgIGNv bnN0IGNoYXIqIHV0ZjhTb3VyY2UgPSB1dGY4UmVzdWx0LmdldCgpOwotICAgIGNvbnZlcnNpb25S ZXN1bHQgPSBjb252ZXJ0VVRGOFRvVVRGMTYoJnV0ZjhTb3VyY2UsIHV0ZjhTb3VyY2UgKyB1dGY4 UmVzdWx0TGVuZ3RoLCAmdXRmMTZUYXJnZXQsIHV0ZjE2VGFyZ2V0ICsgcmVzdWx0TGVuZ3RoLCB0 cnVlKTsKKyAgICBib29sIHVudXNlZElTQWxsQVNDSUk7CisgICAgY29udmVyc2lvblJlc3VsdCA9 IGNvbnZlcnRVVEY4VG9VVEYxNigmdXRmOFNvdXJjZSwgdXRmOFNvdXJjZSArIHV0ZjhSZXN1bHRM ZW5ndGgsICZ1dGYxNlRhcmdldCwgdXRmMTZUYXJnZXQgKyByZXN1bHRMZW5ndGgsICZ1bnVzZWRJ c0FsbEFTQ0lJLCB0cnVlKTsKICAgICBsb25nIHV0ZjE2UmVzdWx0TGVuZ3RoID0gdXRmMTZUYXJn ZXQgLSByZXN1bHQ7CiAgICAgaWYgKGNvbnZlcnNpb25SZXN1bHQgIT0gY29udmVyc2lvbk9LKQog ICAgICAgICAqZXJyb3IgPSB0cnVlOwo=