99820 2012-10-19 00:54:50 -0700 REGRESSION(r131844): It broke the build on !ENABLE(NETSCAPE_PLUGIN_API) platforms 2012-10-19 03:30:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 1 hnandor ossy abecsi andersca benjamin cmarcelo hausmann menard noam ossy vestbo webkit.review.bot zherczeg oldest_to_newest 746106 0 hnandor 2012-10-19 00:54:50 -0700 Log from Mac bot: /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:39:16: error: use of undeclared identifier 'PluginInfoStore' Vector<String> PluginInfoStore::pluginsDirectories() Log from Win bot: C:\WebKitBuildSlave\szeged-windows-1\qt-windows-32bit-release\build\Source\WebKit2\UIProcess\Launcher\qt\ProcessLauncherQt.cpp(116) : error C2065: 'PluginProcess' : undeclared identifier Could you check it, please? 746158 1 169582 ossy 2012-10-19 02:31:08 -0700 Created attachment 169582 Patch 746163 2 169582 jturcotte 2012-10-19 02:42:01 -0700 Comment on attachment 169582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169582&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1321 > +#if PLATFORM(MAC) || ENABLE(NETSCAPE_PLUGIN_API) > WebPage* webPage = m_frame->page(); > ASSERT(webPage); > - > +#endif Nitpick: we could also use m_frame->page() directly to call layerHostingMode and createPlugin. 746187 3 ossy 2012-10-19 03:30:13 -0700 Fixed patch landed in https://trac.webkit.org/changeset/131884 169582 2012-10-19 02:31:08 -0700 2012-10-19 03:30:22 -0700 Patch bug-99820-20121019022951.patch text/plain 4564 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDExYzViZWQzMmY0YTFl ZDZlYzlkMGUzMmJlMDkxM2RjODQwYmEzNy4uOTFhYTE3MzEyZmMyMzA5NmQ0ZWNmMDEwN2EyZGZl NTY5NWZhMTgxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTMxODQ0KTogSXQgYnJva2UgdGhlIGJ1aWxkIG9uICFFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05OTgyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKTogQWRkIG1pc3Npbmcg RU5BQkxFKFBMVUdJTl9QUk9DRVNTKSBndWFyZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvUGx1Z2lu cy91bml4L1BsdWdpbkluZm9TdG9yZVVuaXguY3BwOiBUaGUgd2hvbGUgZmlsZSBzaG91bGQgYmUg RU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpIGd1YXJkZWQgYXMgdGhlIFBsdWdpbkluZm9TdG9y ZSBjbGFzcy4KKyAgICAgICAgKFdlYktpdDo6UGx1Z2luSW5mb1N0b3JlOjpnZXRQbHVnaW5JbmZv KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZVBs dWdpbik6IHdlYlBhZ2UgaXMgdW51c2VkIHZhcmlhYmxlIChidWlsZCBmYWlsIHdpdGggLVdlcnJv cikgaWYgIShQTEFURk9STShNQUMpfHxFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkpLgorCiAy MDEyLTEwLTE4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBXZWJQYWdlUHJveHk6OmNhblNob3dNSU1FVHlwZSgpIHNob3VsZCByZXR1cm4gZmFs c2UgZm9yIHBsdWdpbnMgd2hlbiB0aGV5IGFyZSBkaXNhYmxlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1bmNoZXJRdC5jcHAK aW5kZXggNjBjZGU1ZmEwMjE5NmZlZmM1Mzc3MmJkYjhiOTBjYTMwZTQwNmRjZC4uMGI2ZWUxYmQ1 MTRkZjJmODdiNjEwZTRjMmRkZGRlN2IyODhlY2Q5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3BwCkBA IC0xMTMsOSArMTEzLDExIEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKCkK ICAgICBpZiAobV9sYXVuY2hPcHRpb25zLnByb2Nlc3NUeXBlID09IFdlYlByb2Nlc3MpIHsKICAg ICAgICAgUUJ5dGVBcnJheSB3ZWJQcm9jZXNzUHJlZml4ID0gcWdldGVudigiUVRfV0VCS0lUMl9X UF9DTURfUFJFRklYIik7CiAgICAgICAgIGNvbW1hbmRMaW5lID0gY29tbWFuZExpbmUuYXJnKFFM YXRpbjFTdHJpbmcod2ViUHJvY2Vzc1ByZWZpeC5jb25zdERhdGEoKSkpLmFyZyhRU3RyaW5nKGV4 ZWN1dGFibGVQYXRoT2ZXZWJQcm9jZXNzKCkpKTsKKyNpZiBFTkFCTEUoUExVR0lOX1BST0NFU1Mp CiAgICAgfSBlbHNlIGlmIChtX2xhdW5jaE9wdGlvbnMucHJvY2Vzc1R5cGUgPT0gUGx1Z2luUHJv Y2VzcykgewogICAgICAgICBRQnl0ZUFycmF5IHBsdWdpblByb2Nlc3NQcmVmaXggPSBxZ2V0ZW52 KCJRVF9XRUJLSVQyX1BQX0NNRF9QUkVGSVgiKTsKICAgICAgICAgY29tbWFuZExpbmUgPSBjb21t YW5kTGluZS5hcmcoUUxhdGluMVN0cmluZyhwbHVnaW5Qcm9jZXNzUHJlZml4LmNvbnN0RGF0YSgp KSkuYXJnKFFTdHJpbmcoZXhlY3V0YWJsZVBhdGhPZlBsdWdpblByb2Nlc3MoKSkpOworI2VuZGlm CiAgICAgfSBlbHNlCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpbkluZm9TdG9yZVVu aXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5JbmZv U3RvcmVVbml4LmNwcAppbmRleCBhZmFlZDZkMjE2NjkxZjRhZWMwYjI0YjBjMDgwNjhjZDQwODNh ZDliLi5kNGM5ZWMyYzVmMmU1MmZmMGFjYTQ1OWJlNzQyNmMzMWE5ZmEzZTRjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpbkluZm9TdG9yZVVu aXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2lu SW5mb1N0b3JlVW5peC5jcHAKQEAgLTI2LDYgKzI2LDkgQEAKIC8vIE5vdGU6IHRoaXMgZmlsZSBp cyBvbmx5IGZvciBVTklYLiBPbiBvdGhlciBwbGF0Zm9ybXMgd2UgY2FuIHJldXNlIHRoZSBuYXRp dmUgaW1wbGVtZW50YXRpb24uCiAKICNpbmNsdWRlICJjb25maWcuaCIKKworI2lmIEVOQUJMRShO RVRTQ0FQRV9QTFVHSU5fQVBJKQorCiAjaW5jbHVkZSAiUGx1Z2luSW5mb1N0b3JlLmgiCiAKICNp bmNsdWRlICJOZXRzY2FwZVBsdWdpbk1vZHVsZS5oIgpAQCAtOTUsMTMgKzk4LDcgQEAgVmVjdG9y PFN0cmluZz4gUGx1Z2luSW5mb1N0b3JlOjppbmRpdmlkdWFsUGx1Z2luUGF0aHMoKQogCiBib29s IFBsdWdpbkluZm9TdG9yZTo6Z2V0UGx1Z2luSW5mbyhjb25zdCBTdHJpbmcmIHBsdWdpblBhdGgs IFBsdWdpbk1vZHVsZUluZm8mIHBsdWdpbikKIHsKLSNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lO X0FQSSkKICAgICByZXR1cm4gTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmdldFBsdWdpbkluZm8ocGx1 Z2luUGF0aCwgcGx1Z2luKTsKLSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKHBsdWdpblBhdGgpOwot ICAgIFVOVVNFRF9QQVJBTShwbHVnaW4pOwotICAgIHJldHVybiBmYWxzZTsKLSNlbmRpZgogfQog CiBib29sIFBsdWdpbkluZm9TdG9yZTo6c2hvdWxkVXNlUGx1Z2luKFZlY3RvcjxQbHVnaW5Nb2R1 bGVJbmZvPiYgLyphbHJlYWR5TG9hZGVkUGx1Z2lucyovLCBjb25zdCBQbHVnaW5Nb2R1bGVJbmZv JiAvKnBsdWdpbiovKQpAQCAtMTExLDMgKzEwOCw1IEBAIGJvb2wgUGx1Z2luSW5mb1N0b3JlOjpz aG91bGRVc2VQbHVnaW4oVmVjdG9yPFBsdWdpbk1vZHVsZUluZm8+JiAvKmFscmVhZHlMb2FkZWRQ CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYgLy8gRU5BQkxFKE5FVFNDQVBF X1BMVUdJTl9BUEkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IGU1YTJi NzQ3OTZhZjgzNjIyMzNjOTlhN2Y2ZmM0YWMwYjUyZWRkMWUuLjk2YzY4ZWU3ZDg5MDhiYzY0ZDVk MWY2YWExNjI1Zjg5OTgxYWIwYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3Bw CkBAIC0xMzE0LDEwICsxMzE0LDExIEBAIFBhc3NSZWZQdHI8RnJhbWU+IFdlYkZyYW1lTG9hZGVy Q2xpZW50OjpjcmVhdGVGcmFtZShjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFN0cmluCiBQYXNzUmVm UHRyPFdpZGdldD4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZVBsdWdpbihjb25zdCBJbnRT aXplJiwgSFRNTFBsdWdJbkVsZW1lbnQqIHBsdWdpbkVsZW1lbnQsIGNvbnN0IEtVUkwmIHVybCwg Y29uc3QgVmVjdG9yPFN0cmluZz4mIHBhcmFtTmFtZXMsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBw YXJhbVZhbHVlcywgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgYm9vbCBsb2FkTWFudWFsbHkpCiB7 CiAgICAgQVNTRVJUKHBhcmFtTmFtZXMuc2l6ZSgpID09IHBhcmFtVmFsdWVzLnNpemUoKSk7Ci0g ICAgCisKKyNpZiBQTEFURk9STShNQUMpIHx8IEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQog ICAgIFdlYlBhZ2UqIHdlYlBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCk7CiAgICAgQVNTRVJUKHdlYlBh Z2UpOwotICAgIAorI2VuZGlmCiAgICAgUGx1Z2luOjpQYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CiAg ICAgcGFyYW1ldGVycy51cmwgPSB1cmw7CiAgICAgcGFyYW1ldGVycy5uYW1lcyA9IHBhcmFtTmFt ZXM7Cg==