99819 2012-10-19 00:39:25 -0700 [V8] Simplify GCPrologueVisitor 2012-10-19 01:25:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dcarney eric esprehn haraken japhet webkit.review.bot oldest_to_newest 746100 0 abarth 2012-10-19 00:39:25 -0700 [V8] Simplify GCPrologueVisitor 746101 1 169570 abarth 2012-10-19 00:41:27 -0700 Created attachment 169570 Patch 746103 2 169570 haraken 2012-10-19 00:46:56 -0700 Comment on attachment 169570 Patch Looks OK 746115 3 169570 webkit.review.bot 2012-10-19 01:24:58 -0700 Comment on attachment 169570 Patch Clearing flags on attachment: 169570 Committed r131873: <http://trac.webkit.org/changeset/131873> 746116 4 webkit.review.bot 2012-10-19 01:25:02 -0700 All reviewed patches have been landed. Closing bug. 169570 2012-10-19 00:41:27 -0700 2012-10-19 01:24:58 -0700 Patch bug-99819-20121019004020.patch text/plain 5977 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkyN2M1Nzk5MDU2YTRk M2U0OGU0NjY1YjE0YjM5OWU2ZTkwNGYxMC4uYTgwNGUzYzAzNTQ4ODcxYjc3OTc2NmUwMDBmNGFl OGZhOWFhNTlhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTE5ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBTaW1wbGlmeSBHQ1By b2xvZ3VlVmlzaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTk4MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQcmV2aW91c2x5LCBHQ1Byb2xvZ3VlVmlzaXRvciB1c2VkIGEgY29tcGxpY2F0ZWQgdHJh aXRzLWJhc2VkIHRlbXBsYXRlCisgICAgICAgIGRlc2lnbi4gVGhhdCdzIG5vdCBuZWNlc3Nhcnku IFdlIGNhbiBqdXN0IGltcGxlbWVudCBpdCBkaXJlY3RseSB3aXRob3V0CisgICAgICAgIHRlbXBs YXRlIG1hZ2ljLgorCisgICAgICAgIFRoZSBvbmUgc3VidGx5IGhlcmUgaXMgdGhhdCBNZXNzYWdl UG9ydCBpcyBub3QgYWN0dWFsbHkgYSBzdWJjbGFzcyBvZgorICAgICAgICBBY3RpdmVET01PYmpl Y3QuIFRoZSBuZXh0IHN0YWdlIG9mIHRoaXMgY2xlYW51cCBpcyB0byBtYWtlIE1lc3NhZ2VQb3J0 CisgICAgICAgIGluaGVyaXQgZnJvbSBBY3RpdmVET01PYmplY3QgYW5kIHJlbW92ZSB0aGlzIHNw ZWNpYWwgY2FzZSBlbnRpcmVseS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVuc3VyZVdlYWtET01Ob2RlVmlzaXRvcjo6dmlz aXRET01XcmFwcGVyKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6QWN0 aXZlRE9NT2JqZWN0UHJvbG9ndWVWaXNpdG9yOjp2aXNpdERPTVdyYXBwZXIpOgorICAgICAgICAo V2ViQ29yZTo6Tm9kZVZpc2l0b3I6OnZpc2l0RE9NV3JhcHBlcik6CisgICAgICAgIChXZWJDb3Jl OjpWOEdDQ29udHJvbGxlcjo6Z2NQcm9sb2d1ZSk6CisKIDIwMTItMTAtMTggIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBbVjhdIERPTU9iamVjdFZpc2l0b3IgZG9l cyBub3RoaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5j cHAKaW5kZXggZmI2YWQxMzkyNDAwZjI2OWIzYWI0YTEwNGIyYTU4NDRhMTMxMTQ5MS4uOTAwN2Rh Yjk3ZGU3ZWQzMDAzNWM5YTVkODAxZGUwMzliMTI2N2FlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtNzAsNjAgKzcwLDM0IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgRW5zdXJlV2Vha0RPTU5vZGVWaXNpdG9yIDogcHVibGlj IERPTVdyYXBwZXJNYXA8Tm9kZT46OlZpc2l0b3IgewogcHVibGljOgotICAgIHZvaWQgdmlzaXRE T01XcmFwcGVyKERPTURhdGFTdG9yZSogc3RvcmUsIE5vZGUqIG9iamVjdCwgdjg6OlBlcnNpc3Rl bnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKKyAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRh U3RvcmUqLCBOb2RlKiwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKICAgICB7 Ci0gICAgICAgIFVOVVNFRF9QQVJBTShvYmplY3QpOwogICAgICAgICBBU1NFUlQod3JhcHBlci5J c1dlYWsoKSk7CiAgICAgfQogfTsKIAogI2VuZGlmIC8vIE5ERUJVRwogCi1jbGFzcyBTcGVjaWFs Q2FzZVByb2xvZ3VlT2JqZWN0SGFuZGxlciB7Cit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgorY2xhc3Mg QWN0aXZlRE9NT2JqZWN0UHJvbG9ndWVWaXNpdG9yIDogcHVibGljIERPTVdyYXBwZXJNYXA8VD46 OlZpc2l0b3IgewogcHVibGljOgotICAgIHN0YXRpYyBib29sIHByb2Nlc3Modm9pZCogb2JqZWN0 LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyLCBXcmFwcGVyVHlwZUluZm8qIHR5 cGVJbmZvKQotICAgIHsKLSAgICAgICAgLy8gQWRkaXRpb25hbCBoYW5kbGluZyBvZiBtZXNzYWdl IHBvcnQgZW5zdXJpbmcgdGhhdCBlbnRhbmdsZWQgcG9ydHMgYWxzbwotICAgICAgICAvLyBoYXZl IHRoZWlyIHdyYXBwZXJzIGVudGFuZ2xlZC4gVGhpcyBzaG91bGQgaWRlYWxseSBiZSBoYW5kbGVk IHdoZW4gdGhlCi0gICAgICAgIC8vIHBvcnRzIGFyZSBhY3R1YWxseSBlbnRhbmdsZWQgaW4gTWVz c2FnZVBvcnQ6OmVudGFuZ2xlLCBidXQgdG8gYXZvaWQKLSAgICAgICAgLy8gZm9ya2luZyBNZXNz YWdlUG9ydC4qIHRoaXMgaXMgcG9zdHBvbmVkIHRvIEdDIHRpbWUuIEhhdmluZyB0aGlzIHBvc3Rw b25lZAotICAgICAgICAvLyBoYXMgdGhlIGRyYXdiYWNrIHRoYXQgdGhlIHdyYXBwZXJzIGFyZSAi ZW50YW5nbGVkL3VuZW50YW5nbGVkIiBmb3IgZWFjaAotICAgICAgICAvLyBHQyBldmVuIHRob3Vn aCB0aGVpciBlbnRhZ2xlbWVudCBtb3N0IGxpa2VseSBpcyBzdGlsbCB0aGUgc2FtZS4KLSAgICAg ICAgaWYgKFY4TWVzc2FnZVBvcnQ6OmluZm8uZXF1YWxzKHR5cGVJbmZvKSkgewotICAgICAgICAg ICAgLy8gTWFyayBlYWNoIHBvcnQgYXMgaW4tdXNlIGlmIGl0J3MgZW50YW5nbGVkLiBGb3Igc2lt cGxpY2l0eSdzIHNha2UsIHdlIGFzc3VtZSBhbGwgcG9ydHMgYXJlIHJlbW90ZWx5IGVudGFuZ2xl ZCwKLSAgICAgICAgICAgIC8vIHNpbmNlIHRoZSBDaHJvbWl1bSBwb3J0IGltcGxlbWVudGF0aW9u IGNhbid0IHRlbGwgdGhlIGRpZmZlcmVuY2UuCi0gICAgICAgICAgICBNZXNzYWdlUG9ydCogcG9y dDEgPSBzdGF0aWNfY2FzdDxNZXNzYWdlUG9ydCo+KG9iamVjdCk7Ci0gICAgICAgICAgICBpZiAo cG9ydDEtPmlzRW50YW5nbGVkKCkgfHwgcG9ydDEtPmhhc1BlbmRpbmdBY3Rpdml0eSgpKQotICAg ICAgICAgICAgICAgIHdyYXBwZXIuQ2xlYXJXZWFrKCk7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKLSAgICAgICAgfQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotfTsKLQotY2xhc3Mg U3BlY2lhbENhc2VQcm9sb2d1ZU5vZGVIYW5kbGVyIHsKLXB1YmxpYzoKLSAgICBzdGF0aWMgYm9v bCBwcm9jZXNzKE5vZGUqIG9iamVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBl ciwgV3JhcHBlclR5cGVJbmZvKiB0eXBlSW5mbykKLSAgICB7Ci0gICAgICAgIFVOVVNFRF9QQVJB TShvYmplY3QpOwotICAgICAgICBVTlVTRURfUEFSQU0od3JhcHBlcik7Ci0gICAgICAgIFVOVVNF RF9QQVJBTSh0eXBlSW5mbyk7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci19OwotCi10 ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBTPgotY2xhc3MgR0NQcm9sb2d1ZVZpc2l0b3Ig OiBwdWJsaWMgRE9NV3JhcHBlck1hcDxUPjo6VmlzaXRvciB7Ci1wdWJsaWM6Ci0gICAgdm9pZCB2 aXNpdERPTVdyYXBwZXIoRE9NRGF0YVN0b3JlKiBzdG9yZSwgVCogb2JqZWN0LCB2ODo6UGVyc2lz dGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQorICAgIHZvaWQgdmlzaXRET01XcmFwcGVyKERPTURh dGFTdG9yZSosIFQqIG9iamVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikK ICAgICB7CiAgICAgICAgIFdyYXBwZXJUeXBlSW5mbyogdHlwZUluZm8gPSBWOERPTVdyYXBwZXI6 OmRvbVdyYXBwZXJUeXBlKHdyYXBwZXIpOyAgCiAKLSAgICAgICAgaWYgKCFTOjpwcm9jZXNzKG9i amVjdCwgd3JhcHBlciwgdHlwZUluZm8pKSB7Ci0gICAgICAgICAgICBBY3RpdmVET01PYmplY3Qq IGFjdGl2ZURPTU9iamVjdCA9IHR5cGVJbmZvLT50b0FjdGl2ZURPTU9iamVjdCh3cmFwcGVyKTsK LSAgICAgICAgICAgIGlmIChhY3RpdmVET01PYmplY3QgJiYgYWN0aXZlRE9NT2JqZWN0LT5oYXNQ ZW5kaW5nQWN0aXZpdHkoKSkKKyAgICAgICAgaWYgKFY4TWVzc2FnZVBvcnQ6OmluZm8uZXF1YWxz KHR5cGVJbmZvKSkgeworICAgICAgICAgICAgLy8gTWFyayBlYWNoIHBvcnQgYXMgaW4tdXNlIGlm IGl0J3MgZW50YW5nbGVkLiBGb3Igc2ltcGxpY2l0eSdzIHNha2UsCisgICAgICAgICAgICAvLyB3 ZSBhc3N1bWUgYWxsIHBvcnRzIGFyZSByZW1vdGVseSBlbnRhbmdsZWQsIHNpbmNlIHRoZSBDaHJv bWl1bSBwb3J0CisgICAgICAgICAgICAvLyBpbXBsZW1lbnRhdGlvbiBjYW4ndCB0ZWxsIHRoZSBk aWZmZXJlbmNlLgorICAgICAgICAgICAgTWVzc2FnZVBvcnQqIHBvcnQgPSByZWludGVycHJldF9j YXN0PE1lc3NhZ2VQb3J0Kj4ob2JqZWN0KTsKKyAgICAgICAgICAgIGlmIChwb3J0LT5pc0VudGFu Z2xlZCgpIHx8IHBvcnQtPmhhc1BlbmRpbmdBY3Rpdml0eSgpKQogICAgICAgICAgICAgICAgIHdy YXBwZXIuQ2xlYXJXZWFrKCk7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KKworICAg ICAgICBBY3RpdmVET01PYmplY3QqIGFjdGl2ZURPTU9iamVjdCA9IHR5cGVJbmZvLT50b0FjdGl2 ZURPTU9iamVjdCh3cmFwcGVyKTsKKyAgICAgICAgaWYgKGFjdGl2ZURPTU9iamVjdCAmJiBhY3Rp dmVET01PYmplY3QtPmhhc1BlbmRpbmdBY3Rpdml0eSgpKQorICAgICAgICAgICAgd3JhcHBlci5D bGVhcldlYWsoKTsKICAgICB9CiB9OwogCkBAIC0yNTQsNyArMjI4LDcgQEAgcHVibGljOgogCiBj bGFzcyBOb2RlVmlzaXRvciA6IHB1YmxpYyBET01XcmFwcGVyTWFwPE5vZGU+OjpWaXNpdG9yIHsK IHB1YmxpYzoKLSAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRhU3RvcmUqIHN0b3JlLCBO b2RlKiBub2RlLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQorICAgIHZvaWQg dmlzaXRET01XcmFwcGVyKERPTURhdGFTdG9yZSosIE5vZGUqIG5vZGUsIHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IHdyYXBwZXIpCiAgICAgewogICAgICAgICBpZiAobm9kZS0+aGFzRXZlbnRM aXN0ZW5lcnMoKSkgewogICAgICAgICAgICAgVmVjdG9yPHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1 ZT4gPiBsaXN0ZW5lcnM7CkBAIC0zMjksMTIgKzMwMywxMCBAQCB2b2lkIFY4R0NDb250cm9sbGVy OjpnY1Byb2xvZ3VlKCkKIAogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKIAotICAgIC8vIFJ1 biB0aHJvdWdoIGFsbCBvYmplY3RzIHdpdGggcG9zc2libGUgcGVuZGluZyBhY3Rpdml0eSBtYWtp bmcgdGhlaXIKLSAgICAvLyB3cmFwcGVycyBub24gd2VhayBpZiB0aGVyZSBpcyBwZW5kaW5nIGFj dGl2aXR5LgotICAgIEdDUHJvbG9ndWVWaXNpdG9yPHZvaWQsIFNwZWNpYWxDYXNlUHJvbG9ndWVP YmplY3RIYW5kbGVyPiBwcm9sb2d1ZU9iamVjdFZpc2l0b3I7Ci0gICAgdmlzaXRBY3RpdmVET01P YmplY3RzKCZwcm9sb2d1ZU9iamVjdFZpc2l0b3IpOwotICAgIEdDUHJvbG9ndWVWaXNpdG9yPE5v ZGUsIFNwZWNpYWxDYXNlUHJvbG9ndWVOb2RlSGFuZGxlcj4gcHJvbG9ndWVOb2RlVmlzaXRvcjsK LSAgICB2aXNpdEFjdGl2ZURPTU5vZGVzKCZwcm9sb2d1ZU5vZGVWaXNpdG9yKTsKKyAgICBBY3Rp dmVET01PYmplY3RQcm9sb2d1ZVZpc2l0b3I8dm9pZD4gYWN0aXZlT2JqZWN0VmlzaXRvcjsKKyAg ICB2aXNpdEFjdGl2ZURPTU9iamVjdHMoJmFjdGl2ZU9iamVjdFZpc2l0b3IpOworICAgIEFjdGl2 ZURPTU9iamVjdFByb2xvZ3VlVmlzaXRvcjxOb2RlPiBhY3RpdmVOb2RlVmlzaXRvcjsKKyAgICB2 aXNpdEFjdGl2ZURPTU5vZGVzKCZhY3RpdmVOb2RlVmlzaXRvcik7CiAKICAgICBOb2RlVmlzaXRv ciBub2RlVmlzaXRvcjsKICAgICB2aXNpdERPTU5vZGVzKCZub2RlVmlzaXRvcik7Cg==