99812 2012-10-18 23:17:24 -0700 [V8] DOMObjectVisitor does nothing 2012-10-19 00:07:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dcarney eric esprehn haraken webkit.review.bot oldest_to_newest 746032 0 abarth 2012-10-18 23:17:24 -0700 [V8] DOMObjectVisitor does nothing 746035 1 169554 abarth 2012-10-18 23:18:34 -0700 Created attachment 169554 Patch 746043 2 169554 webkit.review.bot 2012-10-18 23:24:20 -0700 Comment on attachment 169554 Patch Rejecting attachment 169554 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/V8GCController.cpp Hunk #1 succeeded at 71 (offset 3 lines). Hunk #2 FAILED at 325. Hunk #3 succeeded at 435 (offset 3 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8GCController.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14462327 746068 3 dcarney 2012-10-18 23:55:13 -0700 (In reply to comment #0) > [V8] DOMObjectVisitor does nothing I have no idea what the original intention of this was, but it may have been that the author wanted the ASSERT for V8DOMWrapper::maybeDOMWrapper in V8DOMWrapper::domWrapperType? 746078 4 abarth 2012-10-19 00:06:32 -0700 (In reply to comment #3) > (In reply to comment #0) > > [V8] DOMObjectVisitor does nothing > > I have no idea what the original intention of this was, but it may have been that the author wanted the ASSERT for V8DOMWrapper::maybeDOMWrapper in V8DOMWrapper::domWrapperType? It's possible, but as far as I know, this thing has never caught any bugs. 746080 5 169554 abarth 2012-10-19 00:07:53 -0700 Comment on attachment 169554 Patch Clearing flags on attachment: 169554 Committed r131866: <http://trac.webkit.org/changeset/131866> 746081 6 abarth 2012-10-19 00:07:56 -0700 All reviewed patches have been landed. Closing bug. 169554 2012-10-18 23:18:34 -0700 2012-10-19 00:07:53 -0700 Patch bug-99812-20121018231727.patch text/plain 2606 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjMyZGE3ZTY4YTJkZjk2 MzNhOWFlYWIxMDFmNjI5MDk3YzM1MWE2Yy4uYjkyN2M1Nzk5MDU2YTRkM2U0OGU0NjY1YjE0YjM5 OWU2ZTkwNGYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTEwLTE4ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBET01PYmplY3RWaXNp dG9yIGRvZXMgbm90aGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTk4MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGNvZGUgZG9lc24ndCBkbyBhbnl0aGluZywgZXZlbiBpbiBEZWJ1ZyEgV2Ug c2hvdWxkIGp1c3QgcmVtb3ZlIGl0LgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEdDQ29u dHJvbGxlcjo6Z2NQcm9sb2d1ZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEdDQ29udHJvbGxlcjo6 Z2NFcGlsb2d1ZSk6CisKKzIwMTItMTAtMTggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKwogICAgICAgICBbVjhdIEdyb3VwZXJWaXNpdG9yIGlzIHNlY3JldGx5IHR3byBlbnRpcmVs eSBzZXBhcmF0ZSBvYmplY3RzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05OTgxMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEdDQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29u dHJvbGxlci5jcHAKaW5kZXggMTI4MjNiMzI5NGEwMTNiNGYwYmYzNTk2NThiNjY0Y2I1YzQ2OTkz Ny4uZmI2YWQxMzkyNDAwZjI2OWIzYWI0YTEwNGIyYTU4NDRhMTMxMTQ5MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtNjgsMTYgKzY4LDYg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWZuZGVmIE5ERUJVRwogCi1jbGFzcyBET01PYmpl Y3RWaXNpdG9yIDogcHVibGljIERPTVdyYXBwZXJNYXA8dm9pZD46OlZpc2l0b3IgewotcHVibGlj OgotICAgIHZvaWQgdmlzaXRET01XcmFwcGVyKERPTURhdGFTdG9yZSogc3RvcmUsIHZvaWQqIG9i amVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKLSAgICB7Ci0gICAgICAg IFdyYXBwZXJUeXBlSW5mbyogdHlwZSA9IFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUod3Jh cHBlcik7Ci0gICAgICAgIFVOVVNFRF9QQVJBTSh0eXBlKTsKLSAgICAgICAgVU5VU0VEX1BBUkFN KG9iamVjdCk7Ci0gICAgfQotfTsKLQogY2xhc3MgRW5zdXJlV2Vha0RPTU5vZGVWaXNpdG9yIDog cHVibGljIERPTVdyYXBwZXJNYXA8Tm9kZT46OlZpc2l0b3IgewogcHVibGljOgogICAgIHZvaWQg dmlzaXRET01XcmFwcGVyKERPTURhdGFTdG9yZSogc3RvcmUsIE5vZGUqIG9iamVjdCwgdjg6OlBl cnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKQEAgLTMzNSwxNCArMzI1LDkgQEAgcHJpdmF0 ZToKIC8vIENyZWF0ZSBvYmplY3QgZ3JvdXBzIGZvciBET00gdHJlZSBub2Rlcy4KIHZvaWQgVjhH Q0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUoKQogewotICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsK LQogICAgIFRSQUNFX0VWRU5UX0JFR0lOMCgidjgiLCAiR0MiKTsKIAotI2lmbmRlZiBOREVCVUcK LSAgICBET01PYmplY3RWaXNpdG9yIGRvbU9iamVjdFZpc2l0b3I7Ci0gICAgdmlzaXRET01PYmpl Y3RzKCZkb21PYmplY3RWaXNpdG9yKTsKLSNlbmRpZgorICAgIHY4OjpIYW5kbGVTY29wZSBzY29w ZTsKIAogICAgIC8vIFJ1biB0aHJvdWdoIGFsbCBvYmplY3RzIHdpdGggcG9zc2libGUgcGVuZGlu ZyBhY3Rpdml0eSBtYWtpbmcgdGhlaXIKICAgICAvLyB3cmFwcGVycyBub24gd2VhayBpZiB0aGVy ZSBpcyBwZW5kaW5nIGFjdGl2aXR5LgpAQCAtNDQyLDE3ICs0MjcsMTEgQEAgdm9pZCBWOEdDQ29u dHJvbGxlcjo6Z2NFcGlsb2d1ZSgpCiAjZW5kaWYKIAogI2lmbmRlZiBOREVCVUcKLSAgICAvLyBD aGVjayBhbGwgc3Vydml2YWxzIGFyZSB3ZWFrLgotICAgIERPTU9iamVjdFZpc2l0b3IgZG9tT2Jq ZWN0VmlzaXRvcjsKLSAgICB2aXNpdERPTU9iamVjdHMoJmRvbU9iamVjdFZpc2l0b3IpOwotCiAg ICAgRW5zdXJlV2Vha0RPTU5vZGVWaXNpdG9yIHdlYWtET01Ob2RlVmlzaXRvcjsKICAgICB2aXNp dERPTU5vZGVzKCZ3ZWFrRE9NTm9kZVZpc2l0b3IpOwogI2VuZGlmCiAKLSNpZiBQTEFURk9STShD SFJPTUlVTSkKICAgICBUUkFDRV9FVkVOVF9FTkQwKCJ2OCIsICJHQyIpOwotI2VuZGlmCiB9CiAK IHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmNoZWNrTWVtb3J5VXNhZ2UoKQo=