99810 2012-10-18 23:12:32 -0700 [V8] GrouperVisitor is secretly two entirely separate objects 2012-10-18 23:40:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dcarney eric esprehn haraken japhet webkit.review.bot oldest_to_newest 746025 0 abarth 2012-10-18 23:12:32 -0700 [V8] GrouperVisitor is secretly two entirely separate objects 746029 1 169553 abarth 2012-10-18 23:13:11 -0700 Created attachment 169553 Patch 746031 2 169553 haraken 2012-10-18 23:16:37 -0700 Comment on attachment 169553 Patch Good refactoring. 746058 3 169553 webkit.review.bot 2012-10-18 23:40:53 -0700 Comment on attachment 169553 Patch Clearing flags on attachment: 169553 Committed r131863: <http://trac.webkit.org/changeset/131863> 746060 4 webkit.review.bot 2012-10-18 23:40:56 -0700 All reviewed patches have been landed. Closing bug. 169553 2012-10-18 23:13:11 -0700 2012-10-18 23:40:53 -0700 Patch bug-99810-20121018231205.patch text/plain 3340 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZmYzI2Y2I3NzdkODNj MmRiYTBjMmUwNzA5OWUxNWNhMDQ4NmQ2Zi4uYjMyZGE3ZTY4YTJkZjk2MzNhOWFlYWIxMDFmNjI5 MDk3YzM1MWE2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTEwLTE4ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBHcm91cGVyVmlzaXRv ciBpcyBzZWNyZXRseSB0d28gZW50aXJlbHkgc2VwYXJhdGUgb2JqZWN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk4MTAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4gc2VwYXJhdGUgb3V0IHRo ZSB0d28gdGhpbmdzIHRoYXQgR3JvdXBlclZpc2l0b3IgaXMgdHJ5aW5nIHRvIGRvCisgICAgICAg IGJlY2F1c2UgdGhleSBoYXZlIG5vdGhpbmcgdG8gZG8gd2l0aCBlYWNoIG90aGVyLgorCisgICAg ICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoT2JqZWN0Vmlz aXRvcik6CisgICAgICAgIChXZWJDb3JlOjpPYmplY3RWaXNpdG9yOjp2aXNpdERPTVdyYXBwZXIp OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpWOEdDQ29udHJvbGxlcjo6 Z2NQcm9sb2d1ZSk6CisKKzIwMTItMTAtMTggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKwogICAgICAgICBbVjhdIFJlbW92ZSB1bnVzZWQgdHlwZWRlZiBmcm9tIFY4R0NDb250cm9s bGVyLmNwcAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTk4MDgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3Bw CmluZGV4IDljMTQ1NTRlMTNhMTFlZGQyY2U1YTkxMGU0NzI3ZDNiZDliODc1M2EuLjEyODIzYjMy OTRhMDEzYjRmMGJmMzU5NjU4YjY2NGNiNWM0Njk5MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKQEAgLTI1NCw3ICsyNTQsMTUgQEAgc3RhdGlj IEdyb3VwSWQgY2FsY3VsYXRlR3JvdXBJZChOb2RlKiBub2RlKQogICAgIHJldHVybiBHcm91cElk KHJvb3QpOwogfQogCi1jbGFzcyBHcm91cGVyVmlzaXRvciA6IHB1YmxpYyBET01XcmFwcGVyTWFw PE5vZGU+OjpWaXNpdG9yLCBwdWJsaWMgRE9NV3JhcHBlck1hcDx2b2lkPjo6VmlzaXRvciB7Citj bGFzcyBPYmplY3RWaXNpdG9yIDogcHVibGljIERPTVdyYXBwZXJNYXA8dm9pZD46OlZpc2l0b3Ig eworcHVibGljOgorICAgIHZvaWQgdmlzaXRET01XcmFwcGVyKERPTURhdGFTdG9yZSogc3RvcmUs IHZvaWQqIG9iamVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKKyAgICB7 CisgICAgICAgIFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUod3JhcHBlciktPnZpc2l0RE9N V3JhcHBlcihzdG9yZSwgb2JqZWN0LCB3cmFwcGVyKTsKKyAgICB9Cit9OworCitjbGFzcyBOb2Rl VmlzaXRvciA6IHB1YmxpYyBET01XcmFwcGVyTWFwPE5vZGU+OjpWaXNpdG9yIHsKIHB1YmxpYzoK ICAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRhU3RvcmUqIHN0b3JlLCBOb2RlKiBub2Rl LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAgIHsKQEAgLTI3OSwxMiAr Mjg3LDYgQEAgcHVibGljOgogICAgICAgICBtX2dyb3VwZXIuYXBwZW5kKEdyb3VwZXJJdGVtKGdy b3VwSWQsIHdyYXBwZXIpKTsKICAgICB9CiAKLSAgICB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01E YXRhU3RvcmUqIHN0b3JlLCB2b2lkKiBvYmplY3QsIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+ IHdyYXBwZXIpCi0gICAgewotICAgICAgICBXcmFwcGVyVHlwZUluZm8qIGluZm8gPSBWOERPTVdy YXBwZXI6OmRvbVdyYXBwZXJUeXBlKHdyYXBwZXIpOwotICAgICAgICBpbmZvLT52aXNpdERPTVdy YXBwZXIoc3RvcmUsIG9iamVjdCwgd3JhcHBlcik7Ci0gICAgfQotCiAgICAgdm9pZCBhcHBseUdy b3VwaW5nKCkKICAgICB7CiAgICAgICAgIC8vIEdyb3VwIGJ5IHNvcnRpbmcgYnkgdGhlIGdyb3Vw IGlkLgpAQCAtMzM1LDkgKzMzNyw3IEBAIHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUo KQogewogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKIAotI2lmIFBMQVRGT1JNKENIUk9NSVVN KQogICAgIFRSQUNFX0VWRU5UX0JFR0lOMCgidjgiLCAiR0MiKTsKLSNlbmRpZgogCiAjaWZuZGVm IE5ERUJVRwogICAgIERPTU9iamVjdFZpc2l0b3IgZG9tT2JqZWN0VmlzaXRvcjsKQEAgLTM1MSwx NCArMzUxLDE0IEBAIHZvaWQgVjhHQ0NvbnRyb2xsZXI6OmdjUHJvbG9ndWUoKQogICAgIEdDUHJv bG9ndWVWaXNpdG9yPE5vZGUsIFNwZWNpYWxDYXNlUHJvbG9ndWVOb2RlSGFuZGxlcj4gcHJvbG9n dWVOb2RlVmlzaXRvcjsKICAgICB2aXNpdEFjdGl2ZURPTU5vZGVzKCZwcm9sb2d1ZU5vZGVWaXNp dG9yKTsKIAotICAgIC8vIENyZWF0ZSBvYmplY3QgZ3JvdXBzLgotICAgIEdyb3VwZXJWaXNpdG9y IGdyb3VwZXJWaXNpdG9yOwotICAgIHZpc2l0RE9NTm9kZXMoJmdyb3VwZXJWaXNpdG9yKTsKLSAg ICB2aXNpdEFjdGl2ZURPTU5vZGVzKCZncm91cGVyVmlzaXRvcik7Ci0gICAgdmlzaXRET01PYmpl Y3RzKCZncm91cGVyVmlzaXRvcik7Ci0gICAgZ3JvdXBlclZpc2l0b3IuYXBwbHlHcm91cGluZygp OworICAgIE5vZGVWaXNpdG9yIG5vZGVWaXNpdG9yOworICAgIHZpc2l0RE9NTm9kZXMoJm5vZGVW aXNpdG9yKTsKKyAgICB2aXNpdEFjdGl2ZURPTU5vZGVzKCZub2RlVmlzaXRvcik7CisgICAgbm9k ZVZpc2l0b3IuYXBwbHlHcm91cGluZygpOworCisgICAgT2JqZWN0VmlzaXRvciBvYmplY3RWaXNp dG9yOworICAgIHZpc2l0RE9NT2JqZWN0cygmb2JqZWN0VmlzaXRvcik7CiAKLSAgICAvLyBDbGVh biBzaW5nbGUgZWxlbWVudCBjYWNoZSBmb3Igc3RyaW5nIGNvbnZlcnNpb25zLgogICAgIFY4UGVy SXNvbGF0ZURhdGEqIGRhdGEgPSBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7CiAgICAgZGF0 YS0+c3RyaW5nQ2FjaGUoKS0+Y2xlYXJPbkdDKCk7CiB9Cg==