99794 2012-10-18 18:50:05 -0700 String(CFStringRef) should try to converting to an 8 bit string before converting to 16 bit string 2012-10-19 16:19:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 745875 0 msaboff 2012-10-18 18:50:05 -0700 Similar to the change in http://trac.webkit.org/changeset/131656, String::String(CFStringRef) should first try to convert to a Latin1 representation before converting to a UTF16 representation. 745877 1 169531 msaboff 2012-10-18 18:52:26 -0700 Created attachment 169531 Patch 746736 2 169531 webkit.review.bot 2012-10-19 16:19:47 -0700 Comment on attachment 169531 Patch Clearing flags on attachment: 169531 Committed r131954: <http://trac.webkit.org/changeset/131954> 746738 3 webkit.review.bot 2012-10-19 16:19:50 -0700 All reviewed patches have been landed. Closing bug. 169531 2012-10-18 18:52:26 -0700 2012-10-19 16:19:47 -0700 Patch 99794.patch text/plain 1800 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTgzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE4ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZyhDRlN0cmluZ1Jl Zikgc2hvdWxkIHRyeSB0byBjb252ZXJ0aW5nIHRvIGFuIDggYml0IHN0cmluZyBiZWZvcmUgY29u dmVydGluZyB0byAgMTYgYml0IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTk3OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUcnkgZ2V0dGluZyBhIExhdGluMSBieXRlIHN0cmluZyBiZWZvcmUg Z2V0dGluZyBhIFVURjE2IChVQ2hhciopIHN0cmluZy4KKworICAgICAgICBObyBuZXcgdGVzdCwg YWRkZWQgOCBiaXQgcGF0aC4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvY2YvU3RyaW5nQ0Yu Y3BwOgorICAgICAgICAoV1RGOjpTdHJpbmc6OlN0cmluZyk6CisKIDIwMTItMTAtMTggIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2hlcyBp biBXZWJQcm9jZXNzIGF0IGNvbS5hcHBsZS5XZWJDb3JlOiAtW0FjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyIHJlbW90ZUFjY2Vzc2liaWxpdHlQYXJlbnRPYmplY3RdICsgNzgKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvY2YvU3RyaW5nQ0YuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvY2YvU3RyaW5nQ0YuY3BwCShyZXZpc2lvbiAxMzE4 MzYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2NmL1N0cmluZ0NGLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzcsNiArMzcsMTQgQEAgU3RyaW5nOjpTdHJpbmcoQ0ZTdHJpbmdSZWYg c3RyKQogICAgIGlmIChzaXplID09IDApCiAgICAgICAgIG1faW1wbCA9IFN0cmluZ0ltcGw6OmVt cHR5KCk7CiAgICAgZWxzZSB7CisgICAgICAgIFZlY3RvcjxMQ2hhciwgMTAyND4gbGNoYXJCdWZm ZXIoc2l6ZSk7CisgICAgICAgIENGSW5kZXggdXNlZEJ1ZkxlbjsKKyAgICAgICAgQ0ZJbmRleCBj b252ZXJ0ZWRzaXplID0gQ0ZTdHJpbmdHZXRCeXRlcyhzdHIsIENGUmFuZ2VNYWtlKDAsIHNpemUp LCBrQ0ZTdHJpbmdFbmNvZGluZ0lTT0xhdGluMSwgMCwgZmFsc2UsIGxjaGFyQnVmZmVyLmRhdGEo KSwgc2l6ZSwgJnVzZWRCdWZMZW4pOworICAgICAgICBpZiAoKGNvbnZlcnRlZHNpemUgPT0gc2l6 ZSkgJiYgKHVzZWRCdWZMZW4gPT0gc2l6ZSkpIHsKKyAgICAgICAgICAgIG1faW1wbCA9IFN0cmlu Z0ltcGw6OmNyZWF0ZShsY2hhckJ1ZmZlci5kYXRhKCksIHNpemUpOworICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICB9CisKICAgICAgICAgVmVjdG9yPFVDaGFyLCAxMDI0PiBidWZmZXIoc2l6 ZSk7CiAgICAgICAgIENGU3RyaW5nR2V0Q2hhcmFjdGVycyhzdHIsIENGUmFuZ2VNYWtlKDAsIHNp emUpLCAoVW5pQ2hhciopYnVmZmVyLmRhdGEoKSk7CiAgICAgICAgIG1faW1wbCA9IFN0cmluZ0lt cGw6OmNyZWF0ZShidWZmZXIuZGF0YSgpLCBzaXplKTsK